Aggregation of cosmetic changes made during work on REPL PRs: misc. #64275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
reviewed
Sep 8, 2019
| @@ -256,10 +256,10 @@ pub trait BuilderMethods<'a, 'tcx>: | |||
| fn atomic_fence(&mut self, order: AtomicOrdering, scope: SynchronizationScope); | |||
| fn set_invariant_load(&mut self, load: Self::Value); | |||
|
|
|||
| /// Called for `StorageLive` | |||
There was a problem hiding this comment.
Revert removal of backticks.
| impl rustc_serialize::UseSpecializedDecodable for Fingerprint { } | ||
|
|
||
| impl rustc_serialize::SpecializedEncoder<Fingerprint> for Encoder { | ||
| #[inline] |
| fn specialized_encode(&mut self, f: &Fingerprint) -> Result<(), Self::Error> { | ||
| f.encode_opaque(self) | ||
| } | ||
| } | ||
|
|
||
| impl<'a> rustc_serialize::SpecializedDecoder<Fingerprint> for Decoder<'a> { | ||
| #[inline] |
| /// Can be used run `rustc_interface` queries. | ||
| /// Created by passing `Config` to `run_compiler`. | ||
| pub struct Compiler { | ||
| pub(crate) sess: Lrc<Session>, | ||
| codegen_backend: Lrc<Box<dyn CodegenBackend>>, | ||
| source_map: Lrc<SourceMap>, | ||
| pub codegen_backend: Lrc<Box<dyn CodegenBackend>>, |
| @@ -71,7 +71,7 @@ impl<T> Default for Query<T> { | |||
| } | |||
|
|
|||
| #[derive(Default)] | |||
| pub(crate) struct Queries { | |||
| pub struct Queries { | |||
| @@ -1031,18 +1030,18 @@ impl Decodable for SourceFile { | |||
| Ok(lines) | |||
| })?; | |||
| let multibyte_chars: Vec<MultiByteChar> = | |||
| d.read_struct_field("multibyte_chars", 7, |d| Decodable::decode(d))?; | |||
| d.read_struct_field("multibyte_chars", 6, |d| Decodable::decode(d))?; | |||
There was a problem hiding this comment.
Semantic changes here, revert.
| let non_narrow_chars: Vec<NonNarrowChar> = | ||
| d.read_struct_field("non_narrow_chars", 8, |d| Decodable::decode(d))?; | ||
| d.read_struct_field("non_narrow_chars", 7, |d| Decodable::decode(d))?; |
There was a problem hiding this comment.
Semantic changes here, revert.
| let name_hash: u128 = | ||
| d.read_struct_field("name_hash", 9, |d| Decodable::decode(d))?; | ||
| d.read_struct_field("name_hash", 8, |d| Decodable::decode(d))?; |
There was a problem hiding this comment.
Semantic changes here, revert.
| @@ -1,6 +1,6 @@ | |||
| // compile-flags: -Z span_free_formats -Z mir-emit-retag | |||
|
|
|||
| // Tests that MIR inliner fixes up `Retag`'s `fn_entry` flag | |||
| // Tests that MIR inliner fixes up Retag's `fn_entry` flag. | |||
There was a problem hiding this comment.
revert; should have backticks.
| @@ -1,4 +1,4 @@ | |||
| // Whenever a `StorageDead` MIR statement destroys a value `x`, | |||
| // Whenever a StorageDead MIR statement destroys a value `x`, | |||
There was a problem hiding this comment.
revert, should have backticks.
|
Thanks for the PR. Unfortunately, as per our rules set up in #58619, I am closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factored out from hacking on rustc for work on the REPL.
r? @Centril