Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid opaque types in extern "C" blocks #64359

Merged
merged 4 commits into from
Sep 12, 2019
Merged

Forbid opaque types in extern "C" blocks #64359

merged 4 commits into from
Sep 12, 2019

Conversation

varkor
Copy link
Member

@varkor varkor commented Sep 10, 2019

Fixes #64338.

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 10, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@estebank
Copy link
Contributor

r=me with comments addressed and green CI

@varkor
Copy link
Member Author

varkor commented Sep 11, 2019

@bors r=estebank

@bors
Copy link
Contributor

bors commented Sep 11, 2019

📌 Commit 9d71217 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 11, 2019
@Centril
Rollup merge of rust-lang#64359 - varkor:opaque-ty-in-extern, r=estebank
78e6b44 
Forbid opaque types in `extern "C"` blocks

Fixes rust-lang#64338.
@Centril Centril mentioned this pull request Sep 11, 2019
Closed
@bors
Copy link
Contributor

bors commented Sep 12, 2019

⌛ Testing commit 9d71217 with merge eb48d6b...

bors added a commit that referenced this pull request Sep 12, 2019
@bors
Auto merge of #64359 - varkor:opaque-ty-in-extern, r=estebank
eb48d6b 
Forbid opaque types in `extern "C"` blocks

Fixes #64338.
@bors
Copy link
Contributor

bors commented Sep 12, 2019

☀️ Test successful - checks-azure
Approved by: estebank
Pushing eb48d6b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 12, 2019
@bors bors merged commit 9d71217 into rust-lang:master Sep 12, 2019
@varkor varkor deleted the opaque-ty-in-extern branch September 12, 2019 16:47
@Centril Centril added the F-type_alias_impl_trait `#[feature(type_alias_impl_trait)]` label Nov 10, 2019
@hanna-kruppe hanna-kruppe mentioned this pull request Jun 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebank estebank estebank left review comments

Assignees

@estebank estebank

Labels
F-type_alias_impl_trait `#[feature(type_alias_impl_trait)]` merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
type alias impl trait stabilization
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ffi safe lint ICE with type alias impl trait
5 participants
@varkor @rust-highfive @estebank @bors @Centril