Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #64626

Closed
wants to merge 24 commits into from
Closed

Commits on Sep 12, 2019

  1. Configuration menu
    Copy the full SHA
    e608549 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    96526d4 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2019

  1. Document From trait for LhsExpr

    crgl committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    194d357 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2019

  1. rustbuild: Turn down compression on exe installers

    The Windows dist builders are the slowest builders right now, and the
    distribution phase of them is enormously slow clocking in at around 20
    minutes to build all the related installers. This commit starts to
    optimize these by turning down the compression level in the `exe`
    installers. These aren't super heavily used so there's no great need for
    them to be so ultra-compressed, so let's dial back the compression
    parameters to get closer to the rest of our xz archives. This brings the
    installer in line with the gz tarball installer locally, and also brings
    the compression settings on par with the rest of our xz installers.
    alexcrichton committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    8112f71 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1ab5593 View commit details
    Browse the repository at this point in the history
  3. rustbuild: Turn down compression on msi installers

    This is the same as rust-lang#64615 except applied to our MSI installers. The
    same fix is applied effectively bringing these installers in line with
    the gz tarball installers, which are about 3x faster to produce locally
    and likely much faster to produce on CI.
    alexcrichton committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    fde8cfe View commit details
    Browse the repository at this point in the history
  4. rustbuild: Improve output of dist step

    * Pass `/Q` to `iscc` on Windows to supress the thousands of lines of
      output about compressing documentation.
    * Print out what's happening before long steps
    * Use `timeit` to print out timing information for long-running
      installer assemblies.
    alexcrichton committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    255dd3f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    02e3fb8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    fa496c9 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5976e0e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2fbd692 View commit details
    Browse the repository at this point in the history
  9. review comments

    estebank committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    c1ed439 View commit details
    Browse the repository at this point in the history
  10. review comments

    estebank committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    09f05d2 View commit details
    Browse the repository at this point in the history
  11. remove duplicated code

    estebank committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    d64c90d View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    3db2c13 View commit details
    Browse the repository at this point in the history
  13. add comments

    estebank committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    c34d9e6 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2019

  1. Rollup merge of rust-lang#64136 - crgl:doc-from-parser-lhs, r=Centril

    Document From trait for LhsExpr in parser
    
    Add doc for From trait for converting P<Expr> and Option<ThinVec<Attribute>> to LhsExpr
    
    As part of issue rust-lang#51430 (cc @skade).
    
    Both of these should just be moving an address and setting a discriminant in an enum. The main thing I'm not sure about is whether it's worth documenting the branch in the From<Option<ThinVec<Attribute>>. As far as I can tell it doesn't seem like it is optimized away (although if the discriminant happened to work out you could just copy the pointer and the discriminant which might be cheaper, but that's not guaranteed). So it seems like if it's being called often, it's doubling the number of possible branch mispredictions on this Option, which could be a significant cost.
    
    Let me know if there's anything that needs fixing and I'll get to it as soon as possible!
    Centril committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    bd4090b View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#64342 - glorv:master, r=varkor

    factor out pluralisation remains after rust-lang#64280
    
    there are two case that doesn't not match the original macro pattern at [here](https://github.com/rust-lang/rust/blob/master/src/librustc_lint/unused.rs#L146) and [here](https://github.com/rust-lang/rust/blob/master/src/libsyntax/parse/diagnostics.rs#L539) as the provided param is already a bool or the check condition is not `x != 1`, so I change the macro accept a boolean expr instead of number to fit all the cases.
    
    @Centril  please review
    
    Fixes rust-lang#64238.
    Centril committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    906f74c View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#64387 - nathanwhit:redundant-semi-fix, r=va…

    …rkor
    
    Fix redundant semicolon lint interaction with proc macro attributes
    
    Fixes rust-lang#63967 and fixes rust-lang#63947, both of which were caused by the lint's changes to the parser interacting poorly with proc macro attributes and causing span information to be lost
    
    r? @varkor
    Centril committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    fa5d8ab View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#64498 - estebank:point-at-arg, r=Centril

    When possible point at argument causing item obligation failure
    
    Fix rust-lang#41781, fix rust-lang#42855, fix rust-lang#46658, fix rust-lang#48099, fix rust-lang#63143.
    Centril committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    c54aa52 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#64615 - alexcrichton:smaller-exe, r=Mark-Si…

    …mulacrum
    
    rustbuild: Turn down compression on exe installers
    
    The Windows dist builders are the slowest builders right now, and the
    distribution phase of them is enormously slow clocking in at around 20
    minutes to build all the related installers. This commit starts to
    optimize these by turning down the compression level in the `exe`
    installers. These aren't super heavily used so there's no great need for
    them to be so ultra-compressed, so let's dial back the compression
    parameters to get closer to the rest of our xz archives. This brings the
    installer in line with the gz tarball installer locally, and also brings
    the compression settings on par with the rest of our xz installers.
    Centril committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    539aaff View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#64617 - alexcrichton:smaller-msi, r=Mark-Si…

    …mulacrum
    
    rustbuild: Turn down compression on msi installers
    
    This is the same as rust-lang#64615 except applied to our MSI installers. The
    same fix is applied effectively bringing these installers in line with
    the gz tarball installers, which are about 3x faster to produce locally
    and likely much faster to produce on CI.
    Centril committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    5a667aa View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#64618 - alexcrichton:improve-dist-output, r…

    …=Mark-Simulacrum
    
    rustbuild: Improve output of `dist` step
    
    * Pass `/Q` to `iscc` on Windows to supress the thousands of lines of
      output about compressing documentation.
    * Print out what's happening before long steps
    * Use `timeit` to print out timing information for long-running
      installer assemblies.
    * Try to scope output of `Dist ...` to not also encompass actual build steps
    Centril committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    0c5f9a9 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5c610c8 View commit details
    Browse the repository at this point in the history