Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize UdpSocket::peer_addr #64728

Merged
merged 2 commits into from Oct 6, 2019

Conversation

@messense
Copy link
Contributor

commented Sep 24, 2019

Fixes #59127

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Sep 24, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @withoutboats (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

src/libstd/net/udp.rs Outdated Show resolved Hide resolved
@jonas-schievink jonas-schievink modified the milestones: 1.40, 1.39 Sep 24, 2019
@Centril Centril modified the milestones: 1.39, 1.40 Sep 26, 2019
src/libstd/net/udp.rs Outdated Show resolved Hide resolved
@Centril

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

Picking randomly from T-libs... r? @dtolnay

Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
@dtolnay
dtolnay approved these changes Oct 4, 2019
Copy link
Member

left a comment

Thanks!

@dtolnay

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

Libs fcp was already completed in #59127 (comment).

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2019

📌 Commit 1de6f74 has been approved by dtolnay

@bors

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2019

⌛️ Testing commit 1de6f74 with merge 079eef1...

bors added a commit that referenced this pull request Oct 5, 2019
Stabilize UdpSocket::peer_addr

Fixes #59127
@bors

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2019

💥 Test timed out

@bors bors removed the S-waiting-on-bors label Oct 5, 2019
@tmandry

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2019

@bors r=dtolnay

@bors

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: #65139
@bors

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2019

📌 Commit 1de6f74 has been approved by dtolnay

tmandry added a commit to tmandry/rust that referenced this pull request Oct 6, 2019
Stabilize UdpSocket::peer_addr

Fixes rust-lang#59127
bors added a commit that referenced this pull request Oct 6, 2019
Rollup of 18 pull requests

This contains changes from all the successful runs that bors marked as timed out, plus a revert of #63649 which appears to be the immediate cause of the timeouts.

Successful merges:

 - #64708 (Stabilize `Option::as_deref` and `Option::as_deref_mut`)
 - #64728 (Stabilize UdpSocket::peer_addr)
 - #64765 (std: Reduce checks for `feature = "backtrace"`)
 - #64909 (When encountering chained operators use heuristics to recover from bad turbofish)
 - #65011 (Do not ICE when dereferencing non-Copy raw pointer)
 - #65064 (permit asyncawait-ondeck to be added by anyone)
 - #65066 ([const-prop] Fix ICE when trying to eval polymorphic promoted MIR)
 - #65100 (Replace GeneratorSubsts with SubstsRef)
 - #65105 (Split out some passes from librustc)
 - #65106 (Allow unused attributes to avoid incremental bug)
 - #65113 (Fix lonely backtick)
 - #65116 (Remove unneeded visit_statement definition)
 - #65118 (Update the documented default of -Z mutable-noalias)
 - #65123 (Account for macro invocation in `let mut $pat` diagnostic.)
 - #65124 (Replace some instances of `as *[const | mut] _` with `.cast()`)
 - #65126 (Fix typo on `now()` comments)
 - #65130 (lint: extern non-exhaustive types are improper)
 - #65151 (Revert #63649 - "Upgrade Emscripten targets to use upstream LLVM backend")

Failed merges:

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2019

⌛️ Testing commit 1de6f74 with merge 5a8fb7c...

@bors bors merged commit 1de6f74 into rust-lang:master Oct 6, 2019
4 of 5 checks passed
4 of 5 checks passed
homu Testing commit 1de6f74ca47718ae22d7d76eff2986847c659390 with merge 5a8fb7c24d85d0bd911ca465c4a077c7cee608ae...
Details
pr Build #20190926.7 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
@messense messense deleted the messense:udp-peer-addr branch Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.