Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Rest In Peace, AST borrowck (2012-2019) #64790
After having served us for 7 years, the AST borrow-checker is no more.
This PR starts from the commit
Migrate mode is not removed yet as it may be useful for NLL => polonius and it is also used for the
Click to expand the log.
@jhpratt My understanding is that it will allow us to do cleanups in more places, e.g. with respect to rvalue-promotion and whatnot and that might make us more nimble in terms of improvements.
For end-users there should be no change other than closing some soundness holes but that is done first as a part of #64221 which this PR depends on.
This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.
How do I rebase?
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.
Please avoid the "Resolve conflicts" button on GitHub. It uses
Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how
Rest In Peace, AST borrowck (2012-2019) After having served us for 7 years, the AST borrow-checker is no more. This PR starts from the commit `rm -rf librustc_ast_borrowck`, building on #64221, and is probably best read commit by commit. Migrate mode is not removed yet as it may be useful for NLL => polonius and it is also used for the `mutable_borrow_reservation_conflict` issue (#59159). r? @matthewjasper ------------------------ ![ast-borrowck-rip](https://user-images.githubusercontent.com/855702/65646791-91a87600-dffc-11e9-9814-deed6b821c80.png)