Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #65115

Closed
wants to merge 31 commits into from
Closed

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Oct 4, 2019

Successful merges:

Failed merges:

r? @ghost

SimonSapin and others added 30 commits September 23, 2019 17:14
The tracking issue rust-lang#50264
still has unresolved question for the corresponding `Result` methods.
Still debating if this is the right approach
Co-Authored-By: Pietro Albini <pietro@pietroalbini.org>
Stabilize `Option::as_deref` and `Option::as_deref_mut`

The tracking issue rust-lang#50264 still has unresolved question for the corresponding `Result` methods.
When encountering chained operators use heuristics to recover from bad turbofish
Do not ICE when dereferencing non-Copy raw pointer

CC rust-lang#52262. Confirmed to remove the unnecessary ICE, but without a repro case.
…by-anyone, r=nikomatsakis

permit asyncawait-ondeck to be added by anyone

Still debating if this is the right approach

but r? @pietroalbini to check the format
…olymorphic_promoted_mir, r=oli-obk

[const-prop] Fix ICE when trying to eval polymorphic promoted MIR

Fixes rust-lang#64908

r? @oli-obk
cc @nikomatsakis @pnkfelix
…ikomatsakis

Split out some passes from librustc

This is just moving them out to librustc_passes -- I've not measured compile time or run time. I don't expect any significant impact, but this seems prudent regardless.
…r=Centril

Allow unused attributes to avoid incremental bug

cc rust-lang#65023

This isn't labeled as fixing that issue because it's not really a fix, just a patch.
@Centril
Copy link
Contributor Author

Centril commented Oct 4, 2019

@bors r+ p=8 rollup=never

@bors
Copy link
Contributor

bors commented Oct 4, 2019

📌 Commit f320add has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 4, 2019
@Centril Centril added the rollup A PR which is a rollup label Oct 4, 2019
@bors
Copy link
Contributor

bors commented Oct 5, 2019

⌛ Testing commit f320add with merge e5d94a8f85e610ad330ed6596cb11ba2210305d3...

@bors
Copy link
Contributor

bors commented Oct 5, 2019

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 5, 2019
@Centril
Copy link
Contributor Author

Centril commented Oct 5, 2019

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2019
@bors
Copy link
Contributor

bors commented Oct 5, 2019

⌛ Testing commit f320add with merge 4a9ab0f...

bors added a commit that referenced this pull request Oct 5, 2019
Rollup of 8 pull requests

Successful merges:

 - #64708 (Stabilize `Option::as_deref` and `Option::as_deref_mut`)
 - #64909 (When encountering chained operators use heuristics to recover from bad turbofish)
 - #65011 (Do not ICE when dereferencing non-Copy raw pointer)
 - #65064 (permit asyncawait-ondeck to be added by anyone)
 - #65066 ([const-prop] Fix ICE when trying to eval polymorphic promoted MIR)
 - #65100 (Replace GeneratorSubsts with SubstsRef)
 - #65105 (Split out some passes from librustc)
 - #65106 (Allow unused attributes to avoid incremental bug)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Oct 5, 2019

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 5, 2019
@tmandry tmandry closed this Oct 5, 2019
@Centril Centril deleted the rollup-gezozgl branch October 5, 2019 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants