Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 6 pull requests #65177

Closed
wants to merge 24 commits into from
Closed

Rollup of 6 pull requests #65177

wants to merge 24 commits into from

Commits on Oct 2, 2019

  1. remove 'as_str' when it's already a str type. 

    fix rust-lang#62642
    Guanqun Lu committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    a5d9310 View commit details
    Browse the repository at this point in the history

  2. add test files

    Guanqun Lu committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    bb3c030 View commit details
    Browse the repository at this point in the history

  3. comment fixes

    Guanqun Lu committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    4cb86c9 View commit details
    Browse the repository at this point in the history

  4. add FIXME and use 'span_label'

    Guanqun Lu committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    5abc5e9 View commit details
    Browse the repository at this point in the history

  5. fix unit tests

    Guanqun Lu committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    51482d0 View commit details
    Browse the repository at this point in the history

  6. typo fix in the code

    Guanqun Lu committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    11c2d43 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2019

  1. Note when a mutable trait object is needed

    @estebank
    estebank committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    55ecb79 View commit details
    Browse the repository at this point in the history

  2. Tweak wording

    @estebank
    estebank committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    f5e372a View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2019

  1. Correctly estimate required space for string 

    `.len()` returns length in bytes so it overestimates the required space
    @AnthonyMikh
    AnthonyMikh committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    4414068 View commit details
    Browse the repository at this point in the history

  2. Obligation must apply modulo regions

    @estebank
    estebank committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    35a3b58 View commit details
    Browse the repository at this point in the history

  3. review comments

    @estebank
    estebank committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    169b040 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2019

  1. Suggest dereferencing boolean reference when used in 'if' or 'while' 

    Change-Id: I0c5c4d767be2647e6f017ae7bf83558c56dbca97
    @XiangQingW
    XiangQingW committed Oct 6, 2019
    Configuration menu
    Copy the full SHA
    0b0aeac View commit details
    Browse the repository at this point in the history

  2. Suggest dereferencing boolean reference when used in 'if' or 'while' 

    Change-Id: I0c5c4d767be2647e6f017ae7bf83558c56dbca97
    @XiangQingW
    XiangQingW committed Oct 6, 2019
    Configuration menu
    Copy the full SHA
    8a164ac View commit details
    Browse the repository at this point in the history

  3. Suggest dereferencing boolean reference when used in 'if' or 'while' 

    Change-Id: I0c5c4d767be2647e6f017ae7bf83558c56dbca97
    @XiangQingW
    XiangQingW committed Oct 6, 2019
    Configuration menu
    Copy the full SHA
    bbb69d1 View commit details
    Browse the repository at this point in the history

  4. Add long error explanation for E0566

    @GuillaumeGomez
    GuillaumeGomez committed Oct 6, 2019
    Configuration menu
    Copy the full SHA
    c5e0d6e View commit details
    Browse the repository at this point in the history

  5. Update ui tests

    @GuillaumeGomez
    GuillaumeGomez committed Oct 6, 2019
    Configuration menu
    Copy the full SHA
    57cb881 View commit details
    Browse the repository at this point in the history

  6. Update reference 

    - 771c5d1 Add macros in extern blocks and new proc-macro support.
- 8caabd6 Update for "modern" `meta` matcher.
- 1b44947 Update await desugaring after rust-lang#64292
    @tmandry
    tmandry committed Oct 6, 2019
    Configuration menu
    Copy the full SHA
    8baf7bf View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2019

  1. review comments

    @estebank
    estebank committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    6efcb02 View commit details
    Browse the repository at this point in the history

  2. Rollup merge of rust-lang#64739 - guanqun:remove-as-str, r=estebank 

    Remove as_str if the type is already &str

Fix rust-lang#62642

r? @estebank

do you think the suggestion tip is good enough?
    @Centril
    Centril committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    c100831 View commit details
    Browse the repository at this point in the history

  3. Rollup merge of rust-lang#65077 - estebank:mut-trait-expected, r=niko… 

    …matsakis

Note when a mutable trait object is needed

Fix rust-lang#63619, fix rust-lang#37914. CC rust-lang#64068.
    @Centril
    Centril committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    fa961fa View commit details
    Browse the repository at this point in the history

  4. Rollup merge of rust-lang#65120 - AnthonyMikh:fix_65119, r=estebank 

    Correctly estimate the required space for string in `StyledBuffer::prepend`

Fix rust-lang#65119

r? @estebank
    @Centril
    Centril committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    a3d0c90 View commit details
    Browse the repository at this point in the history

  5. Rollup merge of rust-lang#65150 - XiangQingW:master, r=estebank 

    Suggest dereferencing boolean reference when used in 'if' or 'while'

Implements rust-lang#64557
    @Centril
    Centril committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    934f3c2 View commit details
    Browse the repository at this point in the history

  6. Rollup merge of rust-lang#65164 - GuillaumeGomez:long-err-explanation… 

    …-E0566, r=estebank

Add long error explanation for E0566

Part of rust-lang#61137.
    @Centril
    Centril committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    00315c3 View commit details
    Browse the repository at this point in the history

  7. Rollup merge of rust-lang#65173 - tmandry:reffy-ref, r=tmandry 

    Update reference

- Add macros in extern blocks and new proc-macro support.
- Update for "modern" `meta` matcher.
- Update await desugaring after rust-lang#64292
    @Centril
    Centril committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    ca3f01a View commit details
    Browse the repository at this point in the history