Package non-rust objects #65337

jethrogb · 2019-10-12T14:04:02Z

I'd like to use this opportunity to talk about increasing test coverage of tier 2 targets to at least make sure a "hello world" binary can be succesfully linked. There have been similar issues for individual targets in the past, but now we have one affecting several tier 2 targets (and even a tier 1 target).

r? @Mark-Simulacrum
cc @cuviper

jethrogb · 2019-10-12T14:05:19Z

Not sure how to properly test this.

pietroalbini · 2019-10-12T14:15:56Z

The best way to test this I think is to open another PR with the same commits as this one but targeting a tmp-publish branch instead of master. Then we can r+ it, and once it's merged we can publish the build on dev-static so it's installable with rustup for all the platforms we distribute.

This is going to take time though, so I'd like (as proposed in #65335 (comment)) to rollback #64823 in the meantime.

Mark-Simulacrum · 2019-10-12T14:53:41Z

The changes here look reasonable, even if it is presumably a bit unknown as to whether they actually fully fix things or not. I'm going to @bors r+ p=1 this PR with the goal of landing it nightly tonight. I believe we have enough time left that we can do the following:

land this PR, get a dev-static release with it, check if that fixes things -- if so, stop here
if things are not fixed by this PR, land a revert to it and the rustc-dev component PR, fixing tonight's nightly

This seems like a fast and reasonable approach to getting a working nightly tonight no matter what.

bors · 2019-10-12T14:53:42Z

📌 Commit d3cae76a7ece0b65b882c3e16f3dbd682c666fc5 has been approved by Mark-Simulacrum

Mark-Simulacrum · 2019-10-12T14:54:42Z

@bors p=50

bors · 2019-10-12T15:09:09Z

⌛ Testing commit d3cae76a7ece0b65b882c3e16f3dbd682c666fc5 with merge 64b6a78b008d714e9e1a4ee15e17361dfa896887...

rust-highfive · 2019-10-12T15:20:30Z

The job dist-x86_64-musl of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-10-12T15:18:56.5517007Z    Compiling test v0.0.0 (/checkout/src/libtest)
2019-10-12T15:19:10.6588421Z [RUSTC-TIMING] test test:false 14.103
2019-10-12T15:19:10.6606017Z     Finished release [optimized + debuginfo] target(s) in 1m 30s
2019-10-12T15:19:10.6743818Z Copying stage0 std from stage0 (x86_64-unknown-linux-musl -> x86_64-unknown-linux-musl / x86_64-unknown-linux-musl)
2019-10-12T15:19:10.6756233Z thread 'main' panicked at 'src.symlink_metadata() failed with No such file or directory (os error 2)', src/bootstrap/lib.rs:1148:24
2019-10-12T15:19:10.7001045Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --build x86_64-unknown-linux-musl
2019-10-12T15:19:10.7001804Z Build completed unsuccessfully in 0:01:32
2019-10-12T15:19:10.7055085Z == clock drift check ==
2019-10-12T15:19:10.7073596Z   local time: Sat Oct 12 15:19:10 UTC 2019
2019-10-12T15:19:10.7073596Z   local time: Sat Oct 12 15:19:10 UTC 2019
2019-10-12T15:19:10.8723848Z   network time: Sat, 12 Oct 2019 15:19:10 GMT
2019-10-12T15:19:10.8724299Z == end clock drift check ==
2019-10-12T15:19:11.6303780Z ##[error]Bash exited with code '1'.
2019-10-12T15:19:11.6355761Z ##[section]Starting: Upload CPU usage statistics
2019-10-12T15:19:11.6373706Z ==============================================================================
2019-10-12T15:19:11.6373824Z Task         : Bash
2019-10-12T15:19:11.6373902Z Description  : Run a Bash script on macOS, Linux, or Windows

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-10-12T15:20:46Z

💔 Test failed - checks-azure

jethrogb · 2019-10-12T15:22:27Z

I've seen this error in my internal CI when the source file inside copy_third_party_objects doesn't exist.

jethrogb · 2019-10-12T17:45:41Z

src/bootstrap/lib.rs

@@ -1144,6 +1144,7 @@ impl Build {
    pub fn copy(&self, src: &Path, dst: &Path) {
        if self.config.dry_run { return; }
        self.verbose_than(1, &format!("Copy {:?} to {:?}", src, dst));
+        if src == dst { return; }


Not sure why this is now necessary, but hey, it appears to work!

pietroalbini · 2019-10-12T17:51:35Z

@bors try

bors · 2019-10-12T17:51:44Z

⌛ Trying commit 8d4210a with merge 64d69a848361a21d478014cce5b51a11e10aec51...

bors · 2019-10-12T20:26:39Z

☀️ Try build successful - checks-azure
Build commit: 64d69a848361a21d478014cce5b51a11e10aec51 (64d69a848361a21d478014cce5b51a11e10aec51)

gnzlbg · 2019-10-14T08:23:07Z

I'd like to use this opportunity to talk about increasing test coverage of tier 2 targets to at least make sure a "hello world" binary can be successfully linked. There have been similar issues for individual targets in the past, but now we have one affecting several tier 2 targets (and even a tier 1 target).

+1. Ideally we would run these tests with the post build artifacts in a clean environment to be able to diagnose PRs that change how things are packaged.

Any chance of merging this soon ?

jethrogb · 2019-10-14T08:29:46Z

@gnzlbg the PR that broke everything was reverted in #65342, tonight's nightly should work again. I don't think people are in a hurry to re-land it.

gnzlbg · 2019-10-14T08:30:32Z

Ah sorry, I missed that. Thanks for the info.

[dev-nightly] Testing out rustc-dev This PR targets a non-official branch such that we can run full CI and eventually build a nightly from the branch on dev-static; this will hopefully allow us to iron out kinks prior to merging this PR's commits into master proper. cc #64823 and #65337

Mark-Simulacrum · 2019-10-19T16:11:33Z

Closing in favor of #65474 which includes this.

Split the rustc target libraries into separate rustc-dev component This is re-applies a squashed version of #64823 as well as including #65337 to fix bugs noted after merging the first PR. The second PR is confirmed as fixing windows-gnu, and presumably also fixes other platforms, such as musl (i.e. #65335 should be fixed); `RUSTUP_DIST_SERVER=https://dev-static.rust-lang.org rustup toolchain install nightly-2019-10-16` can be installed to confirm that this is indeed the case.

rust-highfive assigned Mark-Simulacrum Oct 12, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 12, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 12, 2019

Centril mentioned this pull request Oct 12, 2019

Tracking issue for "minimize the rust-std component" #65343

Closed

Package non-rust objects

bcc11ac

jethrogb force-pushed the jb/package-non-rust-objects branch from d3cae76 to bcc11ac Compare October 12, 2019 17:45

jethrogb commented Oct 12, 2019

View reviewed changes

Temporarily add dist-various-2 to try builders

8d4210a

Mark-Simulacrum mentioned this pull request Oct 15, 2019

[dev-nightly] Testing out rustc-dev #65453

Merged

Mark-Simulacrum mentioned this pull request Oct 16, 2019

Split the rustc target libraries into separate rustc-dev component #65474

Merged

Mark-Simulacrum closed this Oct 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Package non-rust objects #65337

Package non-rust objects #65337

jethrogb commented Oct 12, 2019 •

edited

Loading

jethrogb commented Oct 12, 2019

pietroalbini commented Oct 12, 2019

Mark-Simulacrum commented Oct 12, 2019

bors commented Oct 12, 2019

Mark-Simulacrum commented Oct 12, 2019

bors commented Oct 12, 2019

rust-highfive commented Oct 12, 2019

bors commented Oct 12, 2019

jethrogb commented Oct 12, 2019

jethrogb Oct 12, 2019

pietroalbini commented Oct 12, 2019

bors commented Oct 12, 2019

bors commented Oct 12, 2019

gnzlbg commented Oct 14, 2019 •

edited

Loading

jethrogb commented Oct 14, 2019

gnzlbg commented Oct 14, 2019

Mark-Simulacrum commented Oct 19, 2019

Package non-rust objects #65337

Package non-rust objects #65337

Conversation

jethrogb commented Oct 12, 2019 • edited Loading

jethrogb commented Oct 12, 2019

pietroalbini commented Oct 12, 2019

Mark-Simulacrum commented Oct 12, 2019

bors commented Oct 12, 2019

Mark-Simulacrum commented Oct 12, 2019

bors commented Oct 12, 2019

rust-highfive commented Oct 12, 2019

bors commented Oct 12, 2019

jethrogb commented Oct 12, 2019

jethrogb Oct 12, 2019

Choose a reason for hiding this comment

pietroalbini commented Oct 12, 2019

bors commented Oct 12, 2019

bors commented Oct 12, 2019

gnzlbg commented Oct 14, 2019 • edited Loading

jethrogb commented Oct 14, 2019

gnzlbg commented Oct 14, 2019

Mark-Simulacrum commented Oct 19, 2019

jethrogb commented Oct 12, 2019 •

edited

Loading

gnzlbg commented Oct 14, 2019 •

edited

Loading