Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid non-`structural_match` types in const generics #65627

Merged

Conversation

@varkor
Copy link
Member

varkor commented Oct 20, 2019

Fixes #60286.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Oct 20, 2019

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Oct 20, 2019

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Oct 20, 2019

IIRC, resolve had some hack making sure that generic parameters cannot be used in const generics.
It should be possible to remove it now because generic parameters are not structural_match.

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Oct 20, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-10-20T16:18:33.6129403Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-20T16:18:33.6311969Z ##[command]git config gc.auto 0
2019-10-20T16:18:33.6402262Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-20T16:18:33.6469375Z ##[command]git config --get-all http.proxy
2019-10-20T16:18:33.6600942Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65627/merge:refs/remotes/pull/65627/merge
---
2019-10-20T16:25:01.7522979Z    Compiling serde_json v1.0.40
2019-10-20T16:25:03.5002560Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-10-20T16:25:15.1959807Z     Finished release [optimized] target(s) in 1m 30s
2019-10-20T16:25:15.2050824Z tidy check
2019-10-20T16:25:16.2692558Z tidy error: duplicate error code: 739
2019-10-20T16:25:16.2692719Z tidy error: /checkout/src/librustc/error_codes.rs:2222:     E0739, // invalid track_caller application/syntax
2019-10-20T16:25:16.2692827Z tidy error: /checkout/src/librustc_typeck/error_codes.rs:4977: E0739: r##"
2019-10-20T16:25:17.5759164Z Found 482 error codes
2019-10-20T16:25:17.5759251Z Found 0 error codes with no tests
2019-10-20T16:25:17.5759331Z Done!
2019-10-20T16:25:17.5759371Z some tidy checks failed
2019-10-20T16:25:17.5759371Z some tidy checks failed
2019-10-20T16:25:17.5766832Z 
2019-10-20T16:25:17.5772043Z 
2019-10-20T16:25:17.5773610Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-10-20T16:25:17.5773763Z 
2019-10-20T16:25:17.5773809Z 
2019-10-20T16:25:17.5778710Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-10-20T16:25:17.5778939Z Build completed unsuccessfully in 0:01:34
2019-10-20T16:25:17.5778939Z Build completed unsuccessfully in 0:01:34
2019-10-20T16:25:17.5826084Z == clock drift check ==
2019-10-20T16:25:17.5852354Z   local time: Sun Oct 20 16:25:17 UTC 2019
2019-10-20T16:25:17.8649310Z   network time: Sun, 20 Oct 2019 16:25:17 GMT
2019-10-20T16:25:17.8652453Z == end clock drift check ==
2019-10-20T16:25:19.2164542Z 
2019-10-20T16:25:19.2271080Z ##[error]Bash exited with code '1'.
2019-10-20T16:25:19.2304280Z ##[section]Starting: Checkout
2019-10-20T16:25:19.2306006Z ==============================================================================
2019-10-20T16:25:19.2306064Z Task         : Get sources
2019-10-20T16:25:19.2306114Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@varkor

This comment has been minimized.

Copy link
Member Author

varkor commented Oct 20, 2019

@petrochenkov: just remembered this too — working on that now.

@Centril

This comment has been minimized.

Copy link
Member

Centril commented Oct 20, 2019

Shouldn't this use the mechanism in #65519?

@Centril

This comment has been minimized.

Copy link
Member

Centril commented Oct 20, 2019

(cc @pnkfelix)

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Oct 20, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-10-20T17:19:07.3849784Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-20T17:19:07.4077299Z ##[command]git config gc.auto 0
2019-10-20T17:19:07.4136684Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-20T17:19:07.4194244Z ##[command]git config --get-all http.proxy
2019-10-20T17:19:07.4331377Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65627/merge:refs/remotes/pull/65627/merge
---
2019-10-20T18:25:45.2588593Z .................................................................................................... 1600/9203
2019-10-20T18:25:50.9771703Z .................................................................................................... 1700/9203
2019-10-20T18:26:04.8149317Z ................................i...............i................................................... 1800/9203
2019-10-20T18:26:12.6096540Z .................................................................................................... 1900/9203
2019-10-20T18:26:27.6054214Z ......................iiiii......................................................................... 2000/9203
2019-10-20T18:26:38.7541233Z .................................................................................................... 2200/9203
2019-10-20T18:26:41.4939370Z .................................................................................................... 2300/9203
2019-10-20T18:26:46.8282332Z .................................................................................................... 2400/9203
2019-10-20T18:27:10.3865730Z .................................................................................................... 2500/9203
---
2019-10-20T18:30:17.2147210Z .........................i...............i.......................................................... 4800/9203
2019-10-20T18:30:29.9717875Z .................................................................................................... 4900/9203
2019-10-20T18:30:36.7075293Z .................................................................................................... 5000/9203
2019-10-20T18:30:46.8415110Z .................................................................................................... 5100/9203
2019-10-20T18:30:54.7760159Z .........................ii.ii...................................................................... 5200/9203
2019-10-20T18:31:05.4076613Z .................................................................................................... 5400/9203
2019-10-20T18:31:16.4326197Z ...........................................................................................i........ 5500/9203
2019-10-20T18:31:25.2028694Z .................................................................................................... 5600/9203
2019-10-20T18:31:30.2662242Z .................................................................................................... 5700/9203
2019-10-20T18:31:30.2662242Z .................................................................................................... 5700/9203
2019-10-20T18:31:41.4686989Z ........................................................................................ii...i..ii.. 5800/9203
2019-10-20T18:32:09.3326071Z .................................................................................................... 6000/9203
2019-10-20T18:32:19.0752626Z .................................................................................................... 6100/9203
2019-10-20T18:32:27.5147831Z .................................................................................................... 6200/9203
2019-10-20T18:32:27.5147831Z .................................................................................................... 6200/9203
2019-10-20T18:32:42.2748852Z ..........i..ii..................................................................................... 6300/9203
2019-10-20T18:33:03.1977926Z ......................................................................i............................. 6500/9203
2019-10-20T18:33:05.4610960Z .................................................................................................... 6600/9203
2019-10-20T18:33:07.9679706Z .............................................i...................................................... 6700/9203
2019-10-20T18:33:11.6522574Z .................................................................................................... 6800/9203
---
2019-10-20T18:37:57.9718383Z  finished in 5.974
2019-10-20T18:37:57.9923071Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-20T18:37:58.1753845Z 
2019-10-20T18:37:58.1754799Z running 153 tests
2019-10-20T18:38:01.5577572Z i....iii......iii..iiii...i.............................i..i..................i....i...........ii.i. 100/153
2019-10-20T18:38:03.7568231Z i..iiii..............i.........iii.i.........ii......
2019-10-20T18:38:03.7642528Z 
2019-10-20T18:38:03.7642586Z  finished in 5.679
2019-10-20T18:38:03.7642933Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-20T18:38:03.8623575Z 
---
2019-10-20T18:38:05.9839636Z  finished in 2.292
2019-10-20T18:38:06.0031110Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-20T18:38:06.7648713Z 
2019-10-20T18:38:06.7648848Z running 9 tests
2019-10-20T18:38:06.7649714Z iiiiiiiii
2019-10-20T18:38:06.7650683Z 
2019-10-20T18:38:06.7650906Z  finished in 0.173
2019-10-20T18:38:06.7651870Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-20T18:38:06.7651923Z 
---
2019-10-20T18:38:25.7646467Z  finished in 18.939
2019-10-20T18:38:25.7646874Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-20T18:38:25.7647054Z 
2019-10-20T18:38:25.7647184Z running 123 tests
2019-10-20T18:38:50.9209121Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-10-20T18:38:55.8663418Z i.i.i......iii.i.....ii
2019-10-20T18:38:55.8664565Z 
2019-10-20T18:38:55.8668922Z  finished in 30.707
2019-10-20T18:38:55.8679193Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-20T18:38:55.8679830Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-10-20T18:46:39.1879485Z ---- [rustdoc] rustdoc/const-generics/const-impl.rs stdout ----
2019-10-20T18:46:39.1879690Z 
2019-10-20T18:46:39.1880211Z error: rustdoc failed!
2019-10-20T18:46:39.1880551Z status: exit code: 1
2019-10-20T18:46:39.1881528Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/const-generics/const-impl/auxiliary" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/const-generics/const-impl" "/checkout/src/test/rustdoc/const-generics/const-impl.rs"
2019-10-20T18:46:39.1882434Z ------------------------------------------
2019-10-20T18:46:39.1882495Z 
2019-10-20T18:46:39.1882718Z ------------------------------------------
2019-10-20T18:46:39.1882764Z stderr:
---
2019-10-20T18:46:39.1883601Z 
2019-10-20T18:46:39.1883649Z error[E0740]: the types of const generic parameters must derive `PartialEq` and `Eq`
2019-10-20T18:46:39.1883915Z   --> /checkout/src/test/rustdoc/const-generics/const-impl.rs:15:33
2019-10-20T18:46:39.1883971Z    |
2019-10-20T18:46:39.1884015Z 15 | pub struct VSet<T, const ORDER: Order> {
2019-10-20T18:46:39.1884406Z    |                                 ^^^^^ `Order` doesn't derive both `PartialEq` and `Eq`
2019-10-20T18:46:39.1884491Z error: aborting due to previous error
2019-10-20T18:46:39.1884520Z 
2019-10-20T18:46:39.1884778Z For more information about this error, try `rustc --explain E0740`.
2019-10-20T18:46:39.1884813Z 
---
2019-10-20T18:46:39.1891463Z 
2019-10-20T18:46:39.1891541Z 
2019-10-20T18:46:39.1891856Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-10-20T18:46:39.1891921Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-10-20T18:46:39.1898554Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/rustdoc" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "rustdoc" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-10-20T18:46:39.1932593Z 
2019-10-20T18:46:39.1932895Z 
2019-10-20T18:46:39.1935113Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-10-20T18:46:39.1935372Z Build completed unsuccessfully in 1:20:25
2019-10-20T18:46:39.1935372Z Build completed unsuccessfully in 1:20:25
2019-10-20T18:46:39.1960459Z == clock drift check ==
2019-10-20T18:46:39.1991124Z   local time: Sun Oct 20 18:46:39 UTC 2019
2019-10-20T18:46:39.3477393Z   network time: Sun, 20 Oct 2019 18:46:39 GMT
2019-10-20T18:46:39.3483482Z == end clock drift check ==
2019-10-20T18:46:42.2969495Z 
2019-10-20T18:46:42.3100302Z ##[error]Bash exited with code '1'.
2019-10-20T18:46:42.3140984Z ##[section]Starting: Checkout
2019-10-20T18:46:42.3143039Z ==============================================================================
2019-10-20T18:46:42.3143112Z Task         : Get sources
2019-10-20T18:46:42.3143159Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@varkor

This comment has been minimized.

Copy link
Member Author

varkor commented Oct 20, 2019

@Centril: this is compatible with that PR (up to rebasing).

@bors

This comment was marked as resolved.

Copy link
Contributor

bors commented Oct 20, 2019

☔️ The latest upstream changes (presumably #65632) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Oct 20, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-10-20T22:22:43.5058923Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-20T22:22:43.5252556Z ##[command]git config gc.auto 0
2019-10-20T22:22:43.5322628Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-20T22:22:43.5372119Z ##[command]git config --get-all http.proxy
2019-10-20T22:22:43.5536950Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65627/merge:refs/remotes/pull/65627/merge
---
2019-10-20T23:26:14.3280364Z .................................................................................................... 1600/9204
2019-10-20T23:26:19.7165935Z .................................................................................................... 1700/9204
2019-10-20T23:26:32.7474491Z .................................i...............i.................................................. 1800/9204
2019-10-20T23:26:40.4051466Z .................................................................................................... 1900/9204
2019-10-20T23:26:54.7079251Z .......................iiiii........................................................................ 2000/9204
2019-10-20T23:27:05.2954380Z .................................................................................................... 2200/9204
2019-10-20T23:27:07.9333111Z .................................................................................................... 2300/9204
2019-10-20T23:27:12.9076736Z .................................................................................................... 2400/9204
2019-10-20T23:27:35.0496472Z .................................................................................................... 2500/9204
---
2019-10-20T23:30:30.5356391Z ..........................i...............i......................................................... 4800/9204
2019-10-20T23:30:42.5459218Z .................................................................................................... 4900/9204
2019-10-20T23:30:49.0672006Z .................................................................................................... 5000/9204
2019-10-20T23:30:58.2943980Z .................................................................................................... 5100/9204
2019-10-20T23:31:06.0634951Z ..........................ii.ii..................................................................... 5200/9204
2019-10-20T23:31:16.2261065Z .................................................................................................... 5400/9204
2019-10-20T23:31:26.6648475Z ............................................................................................i....... 5500/9204
2019-10-20T23:31:34.7733725Z .................................................................................................... 5600/9204
2019-10-20T23:31:39.5787023Z .................................................................................................... 5700/9204
2019-10-20T23:31:39.5787023Z .................................................................................................... 5700/9204
2019-10-20T23:31:50.3011217Z .........................................................................................ii...i..ii. 5800/9204
2019-10-20T23:32:16.5079467Z .................................................................................................... 6000/9204
2019-10-20T23:32:25.9269661Z .................................................................................................... 6100/9204
2019-10-20T23:32:32.2600809Z .................................................................................................... 6200/9204
2019-10-20T23:32:32.2600809Z .................................................................................................... 6200/9204
2019-10-20T23:32:46.3754735Z ...........i..ii.................................................................................... 6300/9204
2019-10-20T23:33:06.1556854Z .......................................................................i............................ 6500/9204
2019-10-20T23:33:08.3352012Z .................................................................................................... 6600/9204
2019-10-20T23:33:10.7497358Z ..............................................i..................................................... 6700/9204
2019-10-20T23:33:14.2013020Z .................................................................................................... 6800/9204
---
2019-10-20T23:37:47.7353234Z  finished in 5.611
2019-10-20T23:37:47.7545481Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-20T23:37:47.9182296Z 
2019-10-20T23:37:47.9182554Z running 153 tests
2019-10-20T23:37:51.2006947Z i....iii......iii..iiii...i.............................i..i..................i....i...........ii.i. 100/153
2019-10-20T23:37:53.2105271Z i..iiii..............i..........iiii.........ii......
2019-10-20T23:37:53.2107085Z 
2019-10-20T23:37:53.2111368Z  finished in 5.456
2019-10-20T23:37:53.2308913Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-20T23:37:53.3882331Z 
---
2019-10-20T23:37:55.4910683Z  finished in 2.259
2019-10-20T23:37:55.5112977Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-20T23:37:55.6893773Z 
2019-10-20T23:37:55.6894614Z running 9 tests
2019-10-20T23:37:55.6895680Z iiiiiiiii
2019-10-20T23:37:55.6896604Z 
2019-10-20T23:37:55.6900072Z  finished in 0.178
2019-10-20T23:37:55.7119761Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-20T23:37:55.8974307Z 
---
2019-10-20T23:38:13.9466851Z  finished in 18.236
2019-10-20T23:38:13.9663721Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-20T23:38:14.1315293Z 
2019-10-20T23:38:14.1315583Z running 123 tests
2019-10-20T23:38:38.3974296Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-10-20T23:38:43.3264117Z i.i.i......iii.i.....ii
2019-10-20T23:38:43.3265982Z 
2019-10-20T23:38:43.3266323Z  finished in 29.360
2019-10-20T23:38:43.3277290Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-10-20T23:38:43.3279812Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-10-20T23:46:07.8755280Z ---- [rustdoc] rustdoc/const-generics/const-impl.rs stdout ----
2019-10-20T23:46:07.8755321Z 
2019-10-20T23:46:07.8755366Z error: rustdoc failed!
2019-10-20T23:46:07.8755434Z status: exit code: 1
2019-10-20T23:46:07.8756044Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/const-generics/const-impl/auxiliary" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/const-generics/const-impl" "/checkout/src/test/rustdoc/const-generics/const-impl.rs"
2019-10-20T23:46:07.8756625Z ------------------------------------------
2019-10-20T23:46:07.8756677Z 
2019-10-20T23:46:07.8756982Z ------------------------------------------
2019-10-20T23:46:07.8757033Z stderr:
2019-10-20T23:46:07.8757033Z stderr:
2019-10-20T23:46:07.8757266Z ------------------------------------------
2019-10-20T23:46:07.8757319Z error: `derive` may only be applied to structs, enums and unions
2019-10-20T23:46:07.8757652Z   |
2019-10-20T23:46:07.8757697Z 7 | #![derive(PartialEq, Eq)]
2019-10-20T23:46:07.8757767Z   | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try an outer attribute: `#[derive(PartialEq, Eq)]`
2019-10-20T23:46:07.8757802Z 
---
2019-10-20T23:46:07.8765848Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-10-20T23:46:07.8765980Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-10-20T23:46:07.8771951Z 
2019-10-20T23:46:07.8772064Z 
2019-10-20T23:46:07.8777265Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/rustdoc" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "rustdoc" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-10-20T23:46:07.8777626Z 
2019-10-20T23:46:07.8777675Z 
2019-10-20T23:46:07.8789179Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-10-20T23:46:07.8789265Z Build completed unsuccessfully in 1:16:28
2019-10-20T23:46:07.8789265Z Build completed unsuccessfully in 1:16:28
2019-10-20T23:46:07.8843437Z == clock drift check ==
2019-10-20T23:46:07.8858815Z   local time: Sun Oct 20 23:46:07 UTC 2019
2019-10-20T23:46:08.0220074Z   network time: Sun, 20 Oct 2019 23:46:08 GMT
2019-10-20T23:46:08.0230096Z == end clock drift check ==
2019-10-20T23:46:10.4023767Z 
2019-10-20T23:46:10.4154006Z ##[error]Bash exited with code '1'.
2019-10-20T23:46:10.4194844Z ##[section]Starting: Checkout
2019-10-20T23:46:10.4197266Z ==============================================================================
2019-10-20T23:46:10.4197347Z Task         : Get sources
2019-10-20T23:46:10.4197399Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@varkor varkor force-pushed the varkor:const-generics-forbid-non-structural_match branch 2 times, most recently from 9e66c91 to ee55bcc Oct 21, 2019
@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Oct 21, 2019

The job LinuxTools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-10-21T09:18:18.1692169Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-21T09:18:18.1881683Z ##[command]git config gc.auto 0
2019-10-21T09:18:18.1985105Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-21T09:18:18.2077760Z ##[command]git config --get-all http.proxy
2019-10-21T09:18:18.2226925Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65627/merge:refs/remotes/pull/65627/merge
---
2019-10-21T11:07:35.6699493Z     Finished release [optimized] target(s) in 8m 50s
2019-10-21T11:09:27.9870038Z Error: there are broken links
2019-10-21T11:09:27.9871920Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/parse/struct.ParseSess.html" returned 404 Not Found
2019-10-21T11:09:27.9872915Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/parse/struct.ParseSess.html#method.buffer_lint" returned 404 Not Found
2019-10-21T11:09:27.9873612Z  Caused By: "***/tree/master/src/libsyntax/ext/tt" returned 404 Not Found
2019-10-21T11:09:27.9874644Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/ext/tt/macro_parser/fn.parse.html" returned 404 Not Found
2019-10-21T11:09:27.9875105Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/ext/tt/macro_rules/" returned 404 Not Found
2019-10-21T11:09:27.9875558Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/ext/tt/macro_parser/" returned 404 Not Found
2019-10-21T11:09:27.9876019Z  Caused By: "https://github.com/rust-lang/chalk/blob/master/src/test/wf.rs" returned 404 Not Found
---
2019-10-21T11:55:04.4510781Z Verifying status of rustfmt...
2019-10-21T11:55:04.4523661Z Verifying status of clippy-driver...
2019-10-21T11:55:04.4537305Z This PR updated 'src/tools/clippy', verifying if status is 'test-pass'...
2019-10-21T11:55:04.4549937Z 
2019-10-21T11:55:04.4550513Z ⚠️ We detected that this PR updated 'clippy-driver', but its tests failed.
2019-10-21T11:55:04.4550557Z 
2019-10-21T11:55:04.4550872Z If you do intend to update 'clippy-driver', please check the error messages above and
2019-10-21T11:55:04.4550929Z commit another update.
2019-10-21T11:55:04.4550958Z 
2019-10-21T11:55:04.4551237Z If you do NOT intend to update 'clippy-driver', please ensure you did not accidentally
2019-10-21T11:55:04.4552409Z change the submodule at 'src/tools/clippy'. You may ask your reviewer for the
2019-10-21T11:55:04.4552469Z proper steps.
2019-10-21T11:55:04.4571168Z   local time: Mon Oct 21 11:55:04 UTC 2019
2019-10-21T11:55:04.7546302Z   network time: Mon, 21 Oct 2019 11:55:04 GMT
2019-10-21T11:55:04.7550153Z == end clock drift check ==
2019-10-21T11:55:06.1847331Z 
2019-10-21T11:55:06.1847331Z 
2019-10-21T11:55:06.1958304Z ##[error]Bash exited with code '3'.
2019-10-21T11:55:06.1997589Z ##[section]Starting: Checkout
2019-10-21T11:55:06.1999773Z ==============================================================================
2019-10-21T11:55:06.1999878Z Task         : Get sources
2019-10-21T11:55:06.1999931Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@varkor varkor force-pushed the varkor:const-generics-forbid-non-structural_match branch from ee55bcc to 161fab9 Oct 21, 2019
@varkor

This comment has been minimized.

Copy link
Member Author

varkor commented Oct 21, 2019

@petrochenkov: I've removed the hack from resolve.

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Oct 22, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-10-22T11:01:46.0069080Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-22T11:01:46.0265594Z ##[command]git config gc.auto 0
2019-10-22T11:01:46.0333631Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-22T11:01:46.0401731Z ##[command]git config --get-all http.proxy
2019-10-22T11:01:46.0529179Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65627/merge:refs/remotes/pull/65627/merge
---
2019-10-22T11:08:07.7078156Z    Compiling serde_json v1.0.40
2019-10-22T11:08:09.3997784Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-10-22T11:08:20.6663755Z     Finished release [optimized] target(s) in 1m 27s
2019-10-22T11:08:20.6748365Z tidy check
2019-10-22T11:08:21.7466678Z tidy error: duplicate error code: 740
2019-10-22T11:08:21.7466806Z tidy error: /checkout/src/librustc_typeck/error_codes.rs:4866: E0740: r##"
2019-10-22T11:08:21.7466862Z tidy error: /checkout/src/librustc_typeck/error_codes.rs:4981: E0740: r##"
2019-10-22T11:08:23.0193757Z Found 483 error codes
2019-10-22T11:08:23.0195522Z Found 0 error codes with no tests
2019-10-22T11:08:23.0195871Z Done!
2019-10-22T11:08:23.0196358Z some tidy checks failed
2019-10-22T11:08:23.0196358Z some tidy checks failed
2019-10-22T11:08:23.0197571Z 
2019-10-22T11:08:23.0197866Z 
2019-10-22T11:08:23.0199121Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-10-22T11:08:23.0199712Z 
2019-10-22T11:08:23.0199935Z 
2019-10-22T11:08:23.0200916Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-10-22T11:08:23.0201207Z Build completed unsuccessfully in 0:01:30
2019-10-22T11:08:23.0201207Z Build completed unsuccessfully in 0:01:30
2019-10-22T11:08:23.0244616Z == clock drift check ==
2019-10-22T11:08:23.0253687Z   local time: Tue Oct 22 11:08:23 UTC 2019
2019-10-22T11:08:23.2896209Z   network time: Tue, 22 Oct 2019 11:08:23 GMT
2019-10-22T11:08:23.2903120Z == end clock drift check ==
2019-10-22T11:08:24.7084510Z 
2019-10-22T11:08:24.7195218Z ##[error]Bash exited with code '1'.
2019-10-22T11:08:24.7226114Z ##[section]Starting: Checkout
2019-10-22T11:08:24.7227735Z ==============================================================================
2019-10-22T11:08:24.7227784Z Task         : Get sources
2019-10-22T11:08:24.7227826Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@varkor varkor force-pushed the varkor:const-generics-forbid-non-structural_match branch from 54eac6a to 2dda8ad Oct 22, 2019
@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Oct 22, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 22, 2019

📌 Commit 2dda8ad has been approved by petrochenkov

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 22, 2019

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@varkor

This comment has been minimized.

Copy link
Member Author

varkor commented Oct 23, 2019

@bors rollup

Centril added a commit to Centril/rust that referenced this pull request Oct 24, 2019
…ructural_match, r=petrochenkov

Forbid non-`structural_match` types in const generics

Fixes rust-lang#60286.
Centril added a commit to Centril/rust that referenced this pull request Oct 24, 2019
…ructural_match, r=petrochenkov

Forbid non-`structural_match` types in const generics

Fixes rust-lang#60286.
bors added a commit that referenced this pull request Oct 25, 2019
Rollup of 8 pull requests

Successful merges:

 - #65625 (Turn crate store into a resolver output)
 - #65627 (Forbid non-`structural_match` types in const generics)
 - #65710 (Update cargo)
 - #65729 (Update test cases for vxWorks)
 - #65746 (Tweak format string error to point at arguments always)
 - #65753 (Don't assert for different instance on impl trait alias)
 - #65755 (Avoid ICE when adjusting bad self ty)
 - #65766 (Update hashbrown to 0.6.2)

Failed merges:

r? @ghost
@bors bors merged commit 2dda8ad into rust-lang:master Oct 25, 2019
4 checks passed
4 checks passed
pr Build #20191022.44 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.