Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: make DefPathData (and friends) Copy (now that it uses Symbol). #65824

Merged
merged 2 commits into from
Oct 26, 2019

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Oct 25, 2019

Spotted this while working on something else.

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 25, 2019
@varkor
Copy link
Member

varkor commented Oct 25, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 25, 2019

📌 Commit 595d19e has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2019
@bors
Copy link
Contributor

bors commented Oct 26, 2019

⌛ Testing commit 595d19e with merge 8448719bd5fbeb9c46bae750f519f54aa5168126...

@rust-highfive
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-10-26T04:44:27.5984284Z do so (now or later) by using -b with the checkout command again. Example:
2019-10-26T04:44:27.5984483Z 
2019-10-26T04:44:27.5984701Z   git checkout -b <new-branch-name>
2019-10-26T04:44:27.5984852Z 
2019-10-26T04:44:27.5985033Z HEAD is now at 8448719bd Auto merge of #65824 - eddyb:def-key-copy, r=varkor
2019-10-26T04:44:27.6341880Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-10-26T04:44:27.6446364Z ==============================================================================
2019-10-26T04:44:27.6446475Z Task         : Bash
2019-10-26T04:44:27.6446549Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-10-26T04:46:06.5131906Z Chocolatey installed 0/1 packages. 1 packages failed.
2019-10-26T04:46:06.5132162Z  See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
2019-10-26T04:46:06.5137065Z 
2019-10-26T04:46:06.5140795Z Failures
2019-10-26T04:46:06.5146771Z  - msys2 (exited 1) - msys2 not installed. An error occurred during installation:
2019-10-26T04:46:06.5147040Z  The remote server returned an error: (503) Server Unavailable. Service Unavailable
2019-10-26T04:46:07.0190886Z 
2019-10-26T04:46:07.0263897Z ##[error]Bash exited with code '1'.
2019-10-26T04:46:07.0451373Z ##[section]Starting: Upload CPU usage statistics
2019-10-26T04:46:07.0554390Z ==============================================================================
2019-10-26T04:46:07.0554497Z Task         : Bash
2019-10-26T04:46:07.0554581Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-10-26T04:46:07.3278435Z ========================== Starting Command Output ===========================
2019-10-26T04:46:07.3282935Z [command]"C:\Program Files\Git\bin\bash.exe" --noprofile --norc /d/a/_temp/f5eee86c-1361-42b7-8083-01aed6bde0f5.sh
2019-10-26T04:46:07.3693851Z /d/a/_temp/f5eee86c-1361-42b7-8083-01aed6bde0f5.sh: line 1: aws: command not found
2019-10-26T04:46:07.3737521Z 
2019-10-26T04:46:07.3755903Z ##[error]Bash exited with code '127'.
2019-10-26T04:46:07.3821127Z ##[section]Starting: Checkout
2019-10-26T04:46:07.3915528Z ==============================================================================
2019-10-26T04:46:07.3915629Z Task         : Get sources
2019-10-26T04:46:07.3915709Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Oct 26, 2019

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 26, 2019
@eddyb
Copy link
Member Author

eddyb commented Oct 26, 2019

@bors retry (spurious network error)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 26, 2019
rustc: make DefPathData (and friends) Copy (now that it uses Symbol).

Spotted this while working on something else.
bors added a commit that referenced this pull request Oct 26, 2019
Rollup of 8 pull requests

Successful merges:

 - #65743 (rustc_typeck: don't record direct callees in generator_interior.)
 - #65761 (libsyntax: Enhance documentation of the AST module)
 - #65772 (Remove the last remaining READMEs)
 - #65773 (Increase spacing for suggestions in diagnostics)
 - #65791 (Adding doc on keyword continue)
 - #65824 (rustc: make DefPathData (and friends) Copy (now that it uses Symbol).)
 - #65828 (Derive Eq and Hash for SourceInfo again)
 - #65842 (Add more information on rustdoc search)

Failed merges:

 - #65825 (rustc: use IndexVec<DefIndex, T> instead of Vec<T>.)

r? @ghost
@bors bors merged commit 595d19e into rust-lang:master Oct 26, 2019
@eddyb eddyb deleted the def-key-copy branch October 27, 2019 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants