Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Clang & build MSVC LLVM with it #66194

Merged
merged 2 commits into from Nov 9, 2019
Merged

Update Clang & build MSVC LLVM with it #66194

merged 2 commits into from Nov 9, 2019

Conversation

alexcrichton
Copy link
Member

This is a general update of our builders to Clang 9, and then it also attempts to tackle a bit of #66192 by building LLVM for rustc with Clang, not with the system cl.exe on MSVC.

@alexcrichton

This comment has been minimized.

Sign in to view
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 7, 2019
@bors

This comment has been minimized.

Sign in to view
@alexcrichton

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@alexcrichton

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@alexcrichton
Copy link
Member Author

Ok I think the >- vs > did the trick in terms of trailing newlines. This is gonna time out a few times while all the caches are primed, and I'd like to avoid merging until I get some more timing information for #66192 as well.

@Mark-Simulacrum
Copy link
Member

Changes look quite reasonable (and I expect the LLVM bit might help us out on our builders), r=me when ready.

@alexcrichton
Update clang to build LLVM to 9.0.0
1e4c2ae 
This also ensure that we're using the same clang version for all our
major platforms instead of 8.0 on Linux and 7.0 on OSX/Windows.
@alexcrichton
Attempt to fix *.yml confguration on Azure
a7b0bea 
Currently the `RUST_CONFIGURE_ARGS` variable apparently has a trailing
newline at the end of it due to the way it's configured in yaml. This
causes issues with MSVC's `install-clang.sh` step where the way the bash
syntax works out means that we drop the arg we're trying to add and it
doesn't actually get added!

The hopeful fix here is to tweak how we specify the yaml syntax to not
have a trailing newline, we'll see what CI says about this...
@alexcrichton

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@Centril

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
bors added a commit that referenced this pull request Nov 7, 2019
@bors
Auto merge of #66194 - alexcrichton:update-clang, r=<try>
bc17558 
Update Clang & build MSVC LLVM with it

This is a general update of our builders to Clang 9, and then it also attempts to tackle a bit of #66192 by building LLVM for rustc with Clang, not with the system `cl.exe` on MSVC.
@Centril

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@alexcrichton
Copy link
Member Author

@bors: try

@bors
Copy link
Contributor

bors commented Nov 8, 2019

⌛ Trying commit 3cf7f98 with merge 33a975a...

bors added a commit that referenced this pull request Nov 8, 2019
@bors
Auto merge of #66194 - alexcrichton:update-clang, r=<try>
33a975a 
Update Clang & build MSVC LLVM with it

This is a general update of our builders to Clang 9, and then it also attempts to tackle a bit of #66192 by building LLVM for rustc with Clang, not with the system `cl.exe` on MSVC.
@alexcrichton
Copy link
Member Author

@bors: r=Mark-Simulacrum

Ok I think everything is configured right now, but this PR will take some time to prime various caches. Unfortunately this is only about a 5% win on MSVC, so something else is still awry with respect to #66192 I think.

@bors
Copy link
Contributor

bors commented Nov 8, 2019

📌 Commit a7b0bea has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2019
@Centril
Copy link
Contributor

Centril commented Nov 8, 2019

@bors rollup=never (wrt. caches)

@alexcrichton alexcrichton mentioned this pull request Nov 8, 2019
Open
@bors
Copy link
Contributor

bors commented Nov 8, 2019

⌛ Testing commit a7b0bea with merge 5a8b630e4396a2d17c9b60a11fc639ef52795038...

@bors bors mentioned this pull request Nov 8, 2019
Merged
@bors
Copy link
Contributor

bors commented Nov 8, 2019

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 8, 2019
@Centril
Copy link
Contributor

Centril commented Nov 8, 2019

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2019
@Centril
Copy link
Contributor

Centril commented Nov 8, 2019

@bors p=30

@bors
Copy link
Contributor

bors commented Nov 8, 2019

⌛ Testing commit a7b0bea with merge 475c713...

bors added a commit that referenced this pull request Nov 8, 2019
@bors
Auto merge of #66194 - alexcrichton:update-clang, r=Mark-Simulacrum
475c713 
Update Clang & build MSVC LLVM with it

This is a general update of our builders to Clang 9, and then it also attempts to tackle a bit of #66192 by building LLVM for rustc with Clang, not with the system `cl.exe` on MSVC.
@bors
Copy link
Contributor

bors commented Nov 9, 2019

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 475c713 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 9, 2019
@bors bors merged commit a7b0bea into rust-lang:master Nov 9, 2019
@bors bors mentioned this pull request Nov 9, 2019
Merged
@alexcrichton alexcrichton deleted the update-clang branch January 14, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alexcrichton @rust-highfive @bors @Mark-Simulacrum @Centril