Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow global references via ForeignItem and Item for the same symbol name during LLVM codegen #66534

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Allow global references via ForeignItem and Item for the same symbol name during LLVM codegen #66534

merged 1 commit into from
Nov 28, 2019

Commits on Nov 19, 2019

  1. Allow different global references to the same name 

    Combining CGUs can result in code that references a static variable through both
an Item and a ForeignItem with the same name. We don't care that the global was
already created by a ForeignItem reference when we see the Item reference, as
long as the LLVM types of the ForeignItem and Item match.

Fixes rust-lang#66464
    @rinon
    rinon committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    32168a3 View commit details
    Browse the repository at this point in the history