Add feature gate for mut refs in const fn #66606

pvdrz · 2019-11-21T13:46:12Z

r? @oli-obk

src/test/ui/consts/const_fn_mut_refs.rs

src/test/ui/consts/const-eval/feature-gate-const_fn_mut_refs.rs

src/libsyntax/feature_gate/active.rs

src/test/ui/consts/const_fn_mut_refs.rs

src/test/ui/consts/const-mut-refs/const_mut_refs.rs

oli-obk · 2019-11-23T16:47:47Z

A test for &mut self would be good, too

Centril · 2019-11-23T22:29:13Z

Seems like rebase gone wrong?

pvdrz · 2019-11-23T23:06:25Z

Seems like rebase gone wrong?

Yep D: I think I fixed it

pvdrz · 2019-11-25T13:16:16Z

@oli-obk @Centril Is it there anything else to be done here?

src/librustc_mir/transform/check_consts/ops.rs

src/test/ui/consts/const-mut-refs/mutable_references_ice.rs

src/librustc_mir/transform/check_consts/validation.rs

Centril · 2019-11-26T16:09:07Z

src/test/ui/consts/const-mut-refs/feature-gate-const_mut_refs.stderr

+   |              ^
+   |
+   = note: for more information, see issue https://github.com/rust-lang/rust/issues/57563
+   = help: add `#![feature(const_fn)]` to the crate attributes to enable


Hmm... it's quite unfortunate that the wrong feature gate is suggested.

yes :( I'd like to fix it

Edit: I think I found how to do it, working on it.

I was able to fix it when mutable borrows are done inside constant contexts but not when they are function arguments. This is because that check is done by the const fn qualification and it always suggests the const_fn flag.

rust-highfive · 2019-11-27T04:58:03Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-27T03:44:39.5124345Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-27T03:44:39.5347921Z ##[command]git config gc.auto 0
2019-11-27T03:44:40.5380989Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-27T03:44:40.5389260Z ##[command]git config --get-all http.proxy
2019-11-27T03:44:40.5395396Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66606/merge:refs/remotes/pull/66606/merge
---
2019-11-27T03:49:20.3859141Z Successfully built 91817817496b
2019-11-27T03:49:20.4660158Z Successfully tagged rust-ci:latest
2019-11-27T03:49:20.5358490Z Built container sha256:91817817496b887c0d78e5c266c845e3af407d0ed64b8c6401584401fd133e5c
2019-11-27T03:49:20.5376385Z Uploading finished image to https://rust-lang-ci-sccache2.s3.amazonaws.com/docker/6b5affe011ff1d5f3b21dfc83ec51b259362cc85cfb8f36f49672c02efc91e505476306baee6903f09190f74e5a67b9efc5b48aff5c2d6d0c38ad646ffda3ea7
2019-11-27T03:50:04.7185010Z upload failed: - to s3://rust-lang-ci-sccache2/docker/6b5affe011ff1d5f3b21dfc83ec51b259362cc85cfb8f36f49672c02efc91e505476306baee6903f09190f74e5a67b9efc5b48aff5c2d6d0c38ad646ffda3ea7 An error occurred (InvalidAccessKeyId) when calling the CreateMultipartUpload operation: The AWS Access Key Id you provided does not exist in our records.
2019-11-27T03:50:05.8187046Z [CI_JOB_NAME=x86_64-gnu-llvm-6.0]
2019-11-27T03:50:05.8214724Z == clock drift check ==
2019-11-27T03:50:05.8224321Z   local time: Wed Nov 27 03:50:05 UTC 2019
2019-11-27T03:50:06.0999934Z   network time: Wed, 27 Nov 2019 03:50:06 GMT
---
2019-11-27T04:46:37.7146633Z .................................................................................................... 1600/9297
2019-11-27T04:46:42.3976803Z .................................................................................................... 1700/9297
2019-11-27T04:46:54.8395376Z ..................................i................................................................. 1800/9297
2019-11-27T04:47:02.4972513Z .................................................................................................... 1900/9297
2019-11-27T04:47:16.2255676Z ...................iiiii............................................................................ 2000/9297
2019-11-27T04:47:26.0929044Z .................................................................................................... 2200/9297
2019-11-27T04:47:28.5615267Z ............F....................................................................................... 2300/9297
2019-11-27T04:47:33.4700861Z .................................................................................................... 2400/9297
2019-11-27T04:47:54.6679993Z .................................................................................................... 2500/9297
---
2019-11-27T04:50:33.5653804Z ....................i...............i............................................................... 4800/9297
2019-11-27T04:50:43.7074670Z .................................................................................................... 4900/9297
2019-11-27T04:50:49.5200170Z .................................................................................................... 5000/9297
2019-11-27T04:50:57.9021573Z .................................................................................................... 5100/9297
2019-11-27T04:51:05.2620786Z .........................ii.ii...........i.......................................................... 5200/9297
2019-11-27T04:51:14.4683211Z .................................................................................................... 5400/9297
2019-11-27T04:51:25.1246353Z .................................................................................................... 5500/9297
2019-11-27T04:51:32.1372667Z .......i............................................................................................ 5600/9297
2019-11-27T04:51:38.3858375Z .................................................................................................... 5700/9297
2019-11-27T04:51:38.3858375Z .................................................................................................... 5700/9297
2019-11-27T04:51:49.2302355Z .............................................................................................ii...i. 5800/9297
2019-11-27T04:52:02.0625557Z .ii...........i..................................................................................... 5900/9297
2019-11-27T04:52:20.0253979Z .................................................................................................... 6100/9297
2019-11-27T04:52:26.2294593Z .................................................................................................... 6200/9297
2019-11-27T04:52:26.2294593Z .................................................................................................... 6200/9297
2019-11-27T04:52:40.0787977Z ................i..ii............................................................................... 6300/9297
2019-11-27T04:52:59.6009745Z ....................................................................................i............... 6500/9297
2019-11-27T04:53:01.9302892Z .................................................................................................... 6600/9297
2019-11-27T04:53:04.3202190Z ...........................................................................i........................ 6700/9297
2019-11-27T04:53:07.0737686Z .................................................................................................... 6800/9297
---
2019-11-27T04:57:53.7539023Z - error[E0017]: references in statics may only refer to immutable values
2019-11-27T04:57:53.7539199Z + error[E0658]: references in statics may only refer to immutable values
2019-11-27T04:57:53.7539573Z 2   --> $DIR/check-static-immutable-mut-slices.rs:3:37
2019-11-27T04:57:53.7539756Z 3    |
2019-11-27T04:57:53.7540103Z 4 LL | static TEST: &'static mut [isize] = &mut [];
2019-11-27T04:57:53.7540404Z 5    |                                     ^^^^^^^ statics require immutable values
2019-11-27T04:57:53.7540527Z +    |
2019-11-27T04:57:53.7540527Z +    |
2019-11-27T04:57:53.7541022Z +    = note: for more information, see ***/issues/57349
2019-11-27T04:57:53.7541206Z +    = help: add `#![feature(const_mut_refs)]` to the crate attributes to enable
2019-11-27T04:57:53.7541471Z 7 error: aborting due to previous error
2019-11-27T04:57:53.7541593Z 8 
2019-11-27T04:57:53.7541695Z 
2019-11-27T04:57:53.7542578Z - For more information about this error, try `rustc --explain E0017`.
2019-11-27T04:57:53.7542578Z - For more information about this error, try `rustc --explain E0017`.
2019-11-27T04:57:53.7543052Z + For more information about this error, try `rustc --explain E0658`.
2019-11-27T04:57:53.7543222Z 10 
2019-11-27T04:57:53.7543374Z 
2019-11-27T04:57:53.7543486Z 
2019-11-27T04:57:53.7543618Z The actual stderr differed from the expected stderr.
2019-11-27T04:57:53.7544090Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/check-static-immutable-mut-slices/check-static-immutable-mut-slices.stderr
2019-11-27T04:57:53.7544532Z To update references, rerun the tests and pass the `--bless` flag
2019-11-27T04:57:53.7547842Z To only update this specific test, also pass `--test-args check-static-immutable-mut-slices.rs`
2019-11-27T04:57:53.7550298Z error: 1 errors occurred comparing output.
2019-11-27T04:57:53.7550359Z status: exit code: 1
2019-11-27T04:57:53.7550359Z status: exit code: 1
2019-11-27T04:57:53.7551330Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/check-static-immutable-mut-slices.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/check-static-immutable-mut-slices" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/check-static-immutable-mut-slices/auxiliary" "-A" "unused"
2019-11-27T04:57:53.7551850Z ------------------------------------------
2019-11-27T04:57:53.7552352Z 
2019-11-27T04:57:53.7552665Z ------------------------------------------
2019-11-27T04:57:53.7552713Z stderr:
2019-11-27T04:57:53.7552713Z stderr:
2019-11-27T04:57:53.7552931Z ------------------------------------------
2019-11-27T04:57:53.7553001Z error[E0658]: references in statics may only refer to immutable values
2019-11-27T04:57:53.7553260Z   --> /checkout/src/test/ui/check-static-immutable-mut-slices.rs:3:37
2019-11-27T04:57:53.7553311Z    |
2019-11-27T04:57:53.7553553Z LL | static TEST: &'static mut [isize] = &mut [];
2019-11-27T04:57:53.7553608Z    |                                     ^^^^^^^ statics require immutable values
2019-11-27T04:57:53.7553664Z    |
2019-11-27T04:57:53.7553994Z    = note: for more information, see ***/issues/57349
2019-11-27T04:57:53.7554178Z    = help: add `#![feature(const_mut_refs)]` to the crate attributes to enable
2019-11-27T04:57:53.7554263Z error: aborting due to previous error
2019-11-27T04:57:53.7554309Z 
2019-11-27T04:57:53.7554602Z For more information about this error, try `rustc --explain E0658`.
2019-11-27T04:57:53.7554636Z 
---
2019-11-27T04:57:53.7555602Z - error[E0017]: references in constants may only refer to immutable values
2019-11-27T04:57:53.7555652Z + error[E0658]: references in constants may only refer to immutable values
2019-11-27T04:57:53.7555859Z 2   --> $DIR/E0017.rs:4:30
2019-11-27T04:57:53.7555910Z 3    |
2019-11-27T04:57:53.7556234Z 4 LL | const CR: &'static mut i32 = &mut C;
2019-11-27T04:57:53.7556333Z 5    |                              ^^^^^^ constants require immutable values
2019-11-27T04:57:53.7556376Z +    |
2019-11-27T04:57:53.7556376Z +    |
2019-11-27T04:57:53.7556663Z +    = note: for more information, see ***/issues/57349
2019-11-27T04:57:53.7556739Z +    = help: add `#![feature(const_mut_refs)]` to the crate attributes to enable
2019-11-27T04:57:53.7557075Z - error[E0017]: references in statics may only refer to immutable values
2019-11-27T04:57:53.7557146Z + error[E0658]: references in statics may only refer to immutable values
2019-11-27T04:57:53.7557371Z 8   --> $DIR/E0017.rs:5:39
2019-11-27T04:57:53.7557415Z 9    |
2019-11-27T04:57:53.7557415Z 9    |
2019-11-27T04:57:53.7557673Z 10 LL | static STATIC_REF: &'static mut i32 = &mut X;
2019-11-27T04:57:53.7557708Z 
2019-11-27T04:57:53.7557756Z 11    |                                       ^^^^^^ statics require immutable values
2019-11-27T04:57:53.7557810Z +    |
2019-11-27T04:57:53.7558131Z +    = note: for more information, see ***/issues/57349
2019-11-27T04:57:53.7558196Z +    = help: add `#![feature(const_mut_refs)]` to the crate attributes to enable
2019-11-27T04:57:53.7558305Z 13 error[E0596]: cannot borrow immutable static item `X` as mutable
2019-11-27T04:57:53.7558544Z 14   --> $DIR/E0017.rs:5:39
2019-11-27T04:57:53.7558576Z 
2019-11-27T04:57:53.7558830Z 16 LL | static STATIC_REF: &'static mut i32 = &mut X;
---
2019-11-27T04:57:53.7559848Z 22 LL | static CONST_REF: &'static mut i32 = &mut C;
2019-11-27T04:57:53.7559968Z 
2019-11-27T04:57:53.7560013Z 23    |                                      ^^^^^^ statics require immutable values
2019-11-27T04:57:53.7560080Z +    |
2019-11-27T04:57:53.7560379Z +    = note: for more information, see ***/issues/57349
2019-11-27T04:57:53.7560433Z +    = help: add `#![feature(const_mut_refs)]` to the crate attributes to enable
2019-11-27T04:57:53.7560531Z 25 error: aborting due to 4 previous errors
2019-11-27T04:57:53.7560569Z 26 
2019-11-27T04:57:53.7560593Z 
2019-11-27T04:57:53.7560838Z - Some errors have detailed explanations: E0017, E0596.
2019-11-27T04:57:53.7560838Z - Some errors have detailed explanations: E0017, E0596.
2019-11-27T04:57:53.7561066Z - For more information about an error, try `rustc --explain E0017`.
2019-11-27T04:57:53.7561113Z + Some errors have detailed explanations: E0596, E0658.
2019-11-27T04:57:53.7561354Z + For more information about an error, try `rustc --explain E0596`.
2019-11-27T04:57:53.7561396Z 29 
2019-11-27T04:57:53.7561419Z 
2019-11-27T04:57:53.7561451Z 
2019-11-27T04:57:53.7561509Z The actual stderr differed from the expected stderr.
2019-11-27T04:57:53.7562329Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/error-codes/E0017/E0017.stderr
2019-11-27T04:57:53.7562693Z To update references, rerun the tests and pass the `--bless` flag
2019-11-27T04:57:53.7562982Z To only update this specific test, also pass `--test-args error-codes/E0017.rs`
2019-11-27T04:57:53.7563061Z error: 1 errors occurred comparing output.
2019-11-27T04:57:53.7563122Z status: exit code: 1
2019-11-27T04:57:53.7563122Z status: exit code: 1
2019-11-27T04:57:53.7563855Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/error-codes/E0017.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/error-codes/E0017" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/error-codes/E0017/auxiliary" "-A" "unused"
2019-11-27T04:57:53.7564195Z ------------------------------------------
2019-11-27T04:57:53.7564229Z 
2019-11-27T04:57:53.7564442Z ------------------------------------------
2019-11-27T04:57:53.7564504Z stderr:
2019-11-27T04:57:53.7564504Z stderr:
2019-11-27T04:57:53.7564714Z ------------------------------------------
2019-11-27T04:57:53.7564766Z error[E0658]: references in constants may only refer to immutable values
2019-11-27T04:57:53.7565017Z   --> /checkout/src/test/ui/error-codes/E0017.rs:4:30
2019-11-27T04:57:53.7565065Z    |
2019-11-27T04:57:53.7565409Z LL | const CR: &'static mut i32 = &mut C; //~ ERROR E0017
2019-11-27T04:57:53.7565476Z    |                              ^^^^^^ constants require immutable values
2019-11-27T04:57:53.7565517Z    |
2019-11-27T04:57:53.7565789Z    = note: for more information, see ***/issues/57349
2019-11-27T04:57:53.7565868Z    = help: add `#![feature(const_mut_refs)]` to the crate attributes to enable
2019-11-27T04:57:53.7565939Z error[E0658]: references in statics may only refer to immutable values
2019-11-27T04:57:53.7566196Z   --> /checkout/src/test/ui/error-codes/E0017.rs:5:39
2019-11-27T04:57:53.7566240Z    |
2019-11-27T04:57:53.7566240Z    |
2019-11-27T04:57:53.7566466Z LL | static STATIC_REF: &'static mut i32 = &mut X; //~ ERROR E0017
2019-11-27T04:57:53.7566534Z    |                                       ^^^^^^ statics require immutable values
2019-11-27T04:57:53.7566576Z    |
2019-11-27T04:57:53.7566836Z    = note: for more information, see ***/issues/57349
2019-11-27T04:57:53.7566904Z    = help: add `#![feature(const_mut_refs)]` to the crate attributes to enable
2019-11-27T04:57:53.7566976Z error[E0596]: cannot borrow immutable static item `X` as mutable
2019-11-27T04:57:53.7567324Z   --> /checkout/src/test/ui/error-codes/E0017.rs:5:39
2019-11-27T04:57:53.7567385Z    |
2019-11-27T04:57:53.7567385Z    |
2019-11-27T04:57:53.7567748Z LL | static STATIC_REF: &'static mut i32 = &mut X; //~ ERROR E0017
2019-11-27T04:57:53.7567848Z 
2019-11-27T04:57:53.7567899Z error[E0658]: references in statics may only refer to immutable values
2019-11-27T04:57:53.7568127Z   --> /checkout/src/test/ui/error-codes/E0017.rs:7:38
2019-11-27T04:57:53.7601422Z    |
2019-11-27T04:57:53.7601422Z    |
2019-11-27T04:57:53.7602104Z LL | static CONST_REF: &'static mut i32 = &mut C; //~ ERROR E0017
2019-11-27T04:57:53.7602170Z    |                                      ^^^^^^ statics require immutable values
2019-11-27T04:57:53.7602229Z    |
2019-11-27T04:57:53.7602579Z    = note: for more information, see ***/issues/57349
2019-11-27T04:57:53.7602640Z    = help: add `#![feature(const_mut_refs)]` to the crate attributes to enable
2019-11-27T04:57:53.7602732Z error: aborting due to 4 previous errors
2019-11-27T04:57:53.7602761Z 
2019-11-27T04:57:53.7602804Z Some errors have detailed explanations: E0596, E0658.
2019-11-27T04:57:53.7603105Z For more information about an error, try `rustc --explain E0596`.
---
2019-11-27T04:57:53.7604172Z - error[E0017]: references in constants may only refer to immutable values
2019-11-27T04:57:53.7604226Z + error[E0658]: references in constants may only refer to immutable values
2019-11-27T04:57:53.7604432Z 2   --> $DIR/E0388.rs:4:30
2019-11-27T04:57:53.7604475Z 3    |
2019-11-27T04:57:53.7604709Z 4 LL | const CR: &'static mut i32 = &mut C;
2019-11-27T04:57:53.7604788Z 5    |                              ^^^^^^ constants require immutable values
2019-11-27T04:57:53.7604843Z +    |
2019-11-27T04:57:53.7604843Z +    |
2019-11-27T04:57:53.7605254Z +    = note: for more information, see ***/issues/57349
2019-11-27T04:57:53.7605437Z +    = help: add `#![feature(const_mut_refs)]` to the crate attributes to enable
2019-11-27T04:57:53.7605738Z - error[E0017]: references in statics may only refer to immutable values
2019-11-27T04:57:53.7605789Z + error[E0658]: references in statics may only refer to immutable values
2019-11-27T04:57:53.7605987Z 8   --> $DIR/E0388.rs:5:39
2019-11-27T04:57:53.7606027Z 9    |
2019-11-27T04:57:53.7606027Z 9    |
2019-11-27T04:57:53.7606238Z 10 LL | static STATIC_REF: &'static mut i32 = &mut X;
2019-11-27T04:57:53.7606268Z 
2019-11-27T04:57:53.7606319Z 11    |                                       ^^^^^^ statics require immutable values
2019-11-27T04:57:53.7606360Z +    |
2019-11-27T04:57:53.7606621Z +    = note: for more information, see ***/issues/57349
2019-11-27T04:57:53.7606684Z +    = help: add `#![feature(const_mut_refs)]` to the crate attributes to enable
2019-11-27T04:57:53.7606783Z 13 error[E0596]: cannot borrow immutable static item `X` as mutable
2019-11-27T04:57:53.7607123Z 14   --> $DIR/E0388.rs:5:39
2019-11-27T04:57:53.7607153Z 
2019-11-27T04:57:53.7607376Z 16 LL | static STATIC_REF: &'static mut i32 = &mut X;
---
2019-11-27T04:57:53.7609030Z 22 LL | static CONST_REF: &'static mut i32 = &mut C;
2019-11-27T04:57:53.7609133Z 
2019-11-27T04:57:53.7609197Z 23    |                                      ^^^^^^ statics require immutable values
2019-11-27T04:57:53.7609250Z +    |
2019-11-27T04:57:53.7609683Z +    = note: for more information, see ***/issues/57349
2019-11-27T04:57:53.7609957Z +    = help: add `#![feature(const_mut_refs)]` to the crate attributes to enable
2019-11-27T04:57:53.7610071Z 25 error: aborting due to 4 previous errors
2019-11-27T04:57:53.7610130Z 26 
2019-11-27T04:57:53.7610160Z 
2019-11-27T04:57:53.7610566Z - Some errors have detailed explanations: E0017, E0596.
2019-11-27T04:57:53.7610566Z - Some errors have detailed explanations: E0017, E0596.
2019-11-27T04:57:53.7610907Z - For more information about an error, try `rustc --explain E0017`.
2019-11-27T04:57:53.7610966Z + Some errors have detailed explanations: E0596, E0658.
2019-11-27T04:57:53.7611238Z + For more information about an error, try `rustc --explain E0596`.
2019-11-27T04:57:53.7611304Z 29 
2019-11-27T04:57:53.7611332Z 
2019-11-27T04:57:53.7611360Z 
2019-11-27T04:57:53.7611408Z The actual stderr differed from the expected stderr.
2019-11-27T04:57:53.7611749Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/error-codes/E0388/E0388.stderr
2019-11-27T04:57:53.7612031Z To update references, rerun the tests and pass the `--bless` flag
2019-11-27T04:57:53.7612891Z To only update this specific test, also pass `--test-args error-codes/E0388.rs`
2019-11-27T04:57:53.7613142Z error: 1 errors occurred comparing output.
2019-11-27T04:57:53.7613202Z status: exit code: 1
2019-11-27T04:57:53.7613202Z status: exit code: 1
2019-11-27T04:57:53.7614078Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/error-codes/E0388.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/error-codes/E0388" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/error-codes/E0388/auxiliary" "-A" "unused"
2019-11-27T04:57:53.7614439Z ------------------------------------------
2019-11-27T04:57:53.7614477Z 
2019-11-27T04:57:53.7614737Z ------------------------------------------
2019-11-27T04:57:53.7614786Z stderr:
2019-11-27T04:57:53.7614786Z stderr:
2019-11-27T04:57:53.7615039Z ------------------------------------------
2019-11-27T04:57:53.7615106Z error[E0658]: references in constants may only refer to immutable values
2019-11-27T04:57:53.7615373Z   --> /checkout/src/test/ui/error-codes/E0388.rs:4:30
2019-11-27T04:57:53.7615439Z    |
2019-11-27T04:57:53.7615701Z LL | const CR: &'static mut i32 = &mut C; //~ ERROR E0017
2019-11-27T04:57:53.7615802Z    |                              ^^^^^^ constants require immutable values
2019-11-27T04:57:53.7615861Z    |
2019-11-27T04:57:53.7616198Z    = note: for more information, see ***/issues/57349
2019-11-27T04:57:53.7616263Z    = help: add `#![feature(const_mut_refs)]` to the crate attributes to enable
2019-11-27T04:57:53.7616363Z error[E0658]: references in statics may only refer to immutable values
2019-11-27T04:57:53.7616646Z   --> /checkout/src/test/ui/error-codes/E0388.rs:5:39
2019-11-27T04:57:53.7616718Z    |
2019-11-27T04:57:53.7616718Z    |
2019-11-27T04:57:53.7616989Z LL | static STATIC_REF: &'static mut i32 = &mut X; //~ ERROR E0017
2019-11-27T04:57:53.7617051Z    |                                       ^^^^^^ statics require immutable values
2019-11-27T04:57:53.7617122Z    |
2019-11-27T04:57:53.7617438Z    = note: for more information, see ***/issues/57349
2019-11-27T04:57:53.7617500Z    = help: add `#![feature(const_mut_refs)]` to the crate attributes to enable
2019-11-27T04:57:53.7617599Z error[E0596]: cannot borrow immutable static item `X` as mutable
2019-11-27T04:57:53.7617876Z   --> /checkout/src/test/ui/error-codes/E0388.rs:5:39
2019-11-27T04:57:53.7617926Z    |
2019-11-27T04:57:53.7617926Z    |
2019-11-27T04:57:53.7618203Z LL | static STATIC_REF: &'static mut i32 = &mut X; //~ ERROR E0017
2019-11-27T04:57:53.7618296Z 
2019-11-27T04:57:53.7618357Z error[E0658]: references in statics may only refer to immutable values
2019-11-27T04:57:53.7618760Z   --> /checkout/src/test/ui/error-codes/E0388.rs:7:38
2019-11-27T04:57:53.7618810Z    |
2019-11-27T04:57:53.7618810Z    |
2019-11-27T04:57:53.7619084Z LL | static CONST_REF: &'static mut i32 = &mut C; //~ ERROR E0017
2019-11-27T04:57:53.7619154Z    |                                      ^^^^^^ statics require immutable values
2019-11-27T04:57:53.7619231Z    |
2019-11-27T04:57:53.7619572Z    = note: for more information, see ***/issues/57349
2019-11-27T04:57:53.7619633Z    = help: add `#![feature(const_mut_refs)]` to the crate attributes to enable
2019-11-27T04:57:53.7619717Z error: aborting due to 4 previous errors
2019-11-27T04:57:53.7619760Z 
2019-11-27T04:57:53.7619808Z Some errors have detailed explanations: E0596, E0658.
2019-11-27T04:57:53.7620100Z For more information about an error, try `rustc --explain E0596`.
---
2019-11-27T04:57:53.7621198Z - error[E0017]: references in constants may only refer to immutable values
2019-11-27T04:57:53.7621284Z + error[E0658]: references in constants may only refer to immutable values
2019-11-27T04:57:53.7621573Z 2   --> $DIR/issue-17718-const-bad-values.rs:1:34
2019-11-27T04:57:53.7621623Z 3    |
2019-11-27T04:57:53.7621882Z 4 LL | const C1: &'static mut [usize] = &mut [];
2019-11-27T04:57:53.7621971Z 5    |                                  ^^^^^^^ constants require immutable values
2019-11-27T04:57:53.7622021Z +    |
2019-11-27T04:57:53.7622021Z +    |
2019-11-27T04:57:53.7622732Z +    = note: for more information, see ***/issues/57349
2019-11-27T04:57:53.7622804Z +    = help: add `#![feature(const_mut_refs)]` to the crate attributes to enable
2019-11-27T04:57:53.7622916Z 7 error[E0013]: constants cannot refer to statics, use a constant instead
2019-11-27T04:57:53.7623216Z 8   --> $DIR/issue-17718-const-bad-values.rs:5:46
2019-11-27T04:57:53.7623254Z 
2019-11-27T04:57:53.7623254Z 
2019-11-27T04:57:53.7623529Z 10 LL | const C2: &'static mut usize = unsafe { &mut S };
2019-11-27T04:57:53.7623633Z 12 
2019-11-27T04:57:53.7623914Z - error[E0017]: references in constants may only refer to immutable values
2019-11-27T04:57:53.7623984Z + error[E0658]: references in constants may only refer to immutable values
2019-11-27T04:57:53.7624242Z 14   --> $DIR/issue-17718-const-bad-values.rs:5:41
2019-11-27T04:57:53.7624242Z 14   --> $DIR/issue-17718-const-bad-values.rs:5:41
2019-11-27T04:57:53.7624292Z 15    |
2019-11-27T04:57:53.7624558Z 16 LL | const C2: &'static mut usize = unsafe { &mut S };
2019-11-27T04:57:53.7624647Z 17    |                                         ^^^^^^ constants require immutable values
2019-11-27T04:57:53.7624709Z +    |
2019-11-27T04:57:53.7624709Z +    |
2019-11-27T04:57:53.7625022Z +    = note: for more information, see ***/issues/57349
2019-11-27T04:57:53.7625095Z +    = help: add `#![feature(const_mut_refs)]` to the crate attributes to enable
2019-11-27T04:57:53.7625213Z 19 error: aborting due to 3 previous errors
2019-11-27T04:57:53.7625259Z 20 
2019-11-27T04:57:53.7625286Z 
2019-11-27T04:57:53.7625577Z - Some errors have detailed explanations: E0013, E0017.
2019-11-27T04:57:53.7625577Z - Some errors have detailed explanations: E0013, E0017.
2019-11-27T04:57:53.7625633Z + Some errors have detailed explanations: E0013, E0658.
2019-11-27T04:57:53.7625905Z 22 For more information about an error, try `rustc --explain E0013`.
2019-11-27T04:57:53.7625966Z 23 
2019-11-27T04:57:53.7625994Z 
2019-11-27T04:57:53.7626022Z 
2019-11-27T04:57:53.7626069Z The actual stderr differed from the expected stderr.
2019-11-27T04:57:53.7626448Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-17718-const-bad-values/issue-17718-const-bad-values.stderr
2019-11-27T04:57:53.7626733Z To update references, rerun the tests and pass the `--bless` flag
2019-11-27T04:57:53.7627213Z To only update this specific test, also pass `--test-args issues/issue-17718-const-bad-values.rs`
2019-11-27T04:57:53.7627314Z error: 1 errors occurred comparing output.
2019-11-27T04:57:53.7627371Z status: exit code: 1
2019-11-27T04:57:53.7627371Z status: exit code: 1
2019-11-27T04:57:53.7635655Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-17718-const-bad-values.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-17718-const-bad-values" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-17718-const-bad-values/auxiliary" "-A" "unused"
2019-11-27T04:57:53.7636276Z ------------------------------------------
2019-11-27T04:57:53.7636336Z 
2019-11-27T04:57:53.7636593Z ------------------------------------------
2019-11-27T04:57:53.7636662Z stderr:
2019-11-27T04:57:53.7636662Z stderr:
2019-11-27T04:57:53.7636904Z ------------------------------------------
2019-11-27T04:57:53.7637127Z error[E0658]: references in constants may only refer to immutable values
2019-11-27T04:57:53.7637471Z   --> /checkout/src/test/ui/issues/issue-17718-const-bad-values.rs:1:34
2019-11-27T04:57:53.7637547Z    |
2019-11-27T04:57:53.7637799Z LL | const C1: &'static mut [usize] = &mut [];
2019-11-27T04:57:53.7637859Z    |                                  ^^^^^^^ constants require immutable values
2019-11-27T04:57:53.7637924Z    |
2019-11-27T04:57:53.7638278Z    = note: for more information, see ***/issues/57349
2019-11-27T04:57:53.7638356Z    = help: add `#![feature(const_mut_refs)]` to the crate attributes to enable
2019-11-27T04:57:53.7638447Z error[E0013]: constants cannot refer to statics, use a constant instead
2019-11-27T04:57:53.7638749Z   --> /checkout/src/test/ui/issues/issue-17718-const-bad-values.rs:5:46
2019-11-27T04:57:53.7638829Z    |
2019-11-27T04:57:53.7638829Z    |
2019-11-27T04:57:53.7639085Z LL | const C2: &'static mut usize = unsafe { &mut S };
2019-11-27T04:57:53.7639195Z 
2019-11-27T04:57:53.7639246Z error[E0658]: references in constants may only refer to immutable values
2019-11-27T04:57:53.7639892Z   --> /checkout/src/test/ui/issues/issue-17718-const-bad-values.rs:5:41
2019-11-27T04:57:53.7639952Z    |
2019-11-27T04:57:53.7639952Z    |
2019-11-27T04:57:53.7640225Z LL | const C2: &'static mut usize = unsafe { &mut S };
2019-11-27T04:57:53.7640285Z    |                                         ^^^^^^ constants require immutable values
2019-11-27T04:57:53.7640335Z    |
2019-11-27T04:57:53.7640677Z    = note: for more information, see ***/issues/57349
2019-11-27T04:57:53.7640740Z    = help: add `#![feature(const_mut_refs)]` to the crate attributes to enable
2019-11-27T04:57:53.7640834Z error: aborting due to 3 previous errors
2019-11-27T04:57:53.7640878Z 
2019-11-27T04:57:53.7640926Z Some errors have detailed explanations: E0013, E0658.
2019-11-27T04:57:53.7641221Z For more information about an error, try `rustc --explain E0013`.
---
2019-11-27T04:57:53.7642683Z - error[E0017]: references in statics may only refer to immutable values
2019-11-27T04:57:53.7642775Z + error[E0658]: references in statics may only refer to immutable values
2019-11-27T04:57:53.7643031Z 2   --> $DIR/issue-46604.rs:1:25
2019-11-27T04:57:53.7643081Z 3    |
2019-11-27T04:57:53.7643143Z 4 LL | static buf: &mut [u8] = &mut [1u8,2,3,4,5,7];
2019-11-27T04:57:53.7643228Z 5    |                         ^^^^^^^^^^^^^^^^^^^^ statics require immutable values
2019-11-27T04:57:53.7643452Z +    |
2019-11-27T04:57:53.7643452Z +    |
2019-11-27T04:57:53.7643844Z +    = note: for more information, see ***/issues/57349
2019-11-27T04:57:53.7643919Z +    = help: add `#![feature(const_mut_refs)]` to the crate attributes to enable
2019-11-27T04:57:53.7643982Z 6 
2019-11-27T04:57:53.7644035Z 7 error[E0594]: cannot assign to `buf[_]`, as `buf` is an immutable static item
2019-11-27T04:57:53.7648040Z 8   --> $DIR/issue-46604.rs:6:5
2019-11-27T04:57:53.7648636Z 12 
2019-11-27T04:57:53.7648691Z 13 error: aborting due to 2 previous errors
2019-11-27T04:57:53.7665405Z 14 
2019-11-27T04:57:53.7665975Z - Some errors have detailed explanations: E0017, E0594.
---
2019-11-27T04:57:53.7666721Z 
2019-11-27T04:57:53.7666749Z 
2019-11-27T04:57:53.7666813Z The actual stderr differed from the expected stderr.
2019-11-27T04:57:53.7667310Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-46604/issue-46604.stderr
2019-11-27T04:57:53.7667645Z To update references, rerun the tests and pass the `--bless` flag
2019-11-27T04:57:53.7667957Z To only update this specific test, also pass `--test-args issues/issue-46604.rs`
2019-11-27T04:57:53.7668046Z error: 1 errors occurred comparing output.
2019-11-27T04:57:53.7668095Z status: exit code: 1
2019-11-27T04:57:53.7668095Z status: exit code: 1
2019-11-27T04:57:53.7669100Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-46604.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-46604" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-46604/auxiliary" "-A" "unused"
2019-11-27T04:57:53.7669517Z ------------------------------------------
2019-11-27T04:57:53.7669556Z 
2019-11-27T04:57:53.7669794Z ------------------------------------------
2019-11-27T04:57:53.7669856Z stderr:
2019-11-27T04:57:53.7669856Z stderr:
2019-11-27T04:57:53.7670091Z ------------------------------------------
2019-11-27T04:57:53.7670149Z error[E0658]: references in statics may only refer to immutable values
2019-11-27T04:57:53.7670422Z   --> /checkout/src/test/ui/issues/issue-46604.rs:1:25
2019-11-27T04:57:53.7670479Z    |
2019-11-27T04:57:53.7670535Z LL | static buf: &mut [u8] = &mut [1u8,2,3,4,5,7];   //~ ERROR E0017
2019-11-27T04:57:53.7670612Z    |                         ^^^^^^^^^^^^^^^^^^^^ statics require immutable values
2019-11-27T04:57:53.7670665Z    |
2019-11-27T04:57:53.7671067Z    = note: for more information, see ***/issues/57349
2019-11-27T04:57:53.7671147Z    = help: add `#![feature(const_mut_refs)]` to the crate attributes to enable
2019-11-27T04:57:53.7671185Z 
2019-11-27T04:57:53.7671250Z error[E0594]: cannot assign to `buf[_]`, as `buf` is an immutable static item
2019-11-27T04:57:53.7671581Z   --> /checkout/src/test/ui/issues/issue-46604.rs:6:5
2019-11-27T04:57:53.7671637Z    |
2019-11-27T04:57:53.7671691Z LL |     buf[0]=2;                                   //~ ERROR E0594
2019-11-27T04:57:53.7671794Z 
2019-11-27T04:57:53.7671844Z error: aborting due to 2 previous errors
2019-11-27T04:57:53.7671878Z 
2019-11-27T04:57:53.7671929Z Some errors have detailed explanations: E0594, E0658.
---
2019-11-27T04:57:53.7675194Z test result: FAILED. 9249 passed; 5 failed; 43 ignored; 0 measured; 0 filtered out
2019-11-27T04:57:53.7675236Z 
2019-11-27T04:57:53.7677438Z 
2019-11-27T04:57:53.7677488Z 
2019-11-27T04:57:53.7679382Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-11-27T04:57:53.7679714Z 
2019-11-27T04:57:53.7679744Z 
2019-11-27T04:57:53.7679795Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-11-27T04:57:53.7679869Z Build completed unsuccessfully in 1:04:36
2019-11-27T04:57:53.7679869Z Build completed unsuccessfully in 1:04:36
2019-11-27T04:57:53.7680214Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-11-27T04:57:53.7680281Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-11-27T04:57:53.7680352Z == clock drift check ==
2019-11-27T04:57:53.7680402Z   local time: Wed Nov 27 04:57:53 UTC 2019
2019-11-27T04:57:54.2991671Z   network time: Wed, 27 Nov 2019 04:57:54 GMT
2019-11-27T04:57:54.2995399Z == end clock drift check ==
2019-11-27T04:57:55.1466194Z 
2019-11-27T04:57:55.1574089Z ##[error]Bash exited with code '1'.
2019-11-27T04:57:55.1612190Z ##[section]Starting: Checkout
2019-11-27T04:57:55.1614253Z ==============================================================================
2019-11-27T04:57:55.1614322Z Task         : Get sources
2019-11-27T04:57:55.1614385Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

src/test/ui/consts/miri_unleashed/mutable_const.rs

src/test/ui/consts/miri_unleashed/mutable_references.rs

src/test/ui/consts/projection_qualif.stderr

src/test/ui/consts/static_mut_containing_mut_ref2.stderr

rust-highfive · 2019-11-28T18:30:06Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-28T17:21:32.3339713Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-28T17:21:32.3533460Z ##[command]git config gc.auto 0
2019-11-28T17:21:32.3587559Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-28T17:21:32.3644609Z ##[command]git config --get-all http.proxy
2019-11-28T17:21:32.3795844Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66606/merge:refs/remotes/pull/66606/merge
---
2019-11-28T18:19:03.7090739Z .................................................................................................... 1600/9308
2019-11-28T18:19:08.1992766Z .................................................................................................... 1700/9308
2019-11-28T18:19:20.4318635Z ........................................i........................................................... 1800/9308
2019-11-28T18:19:28.1560947Z .................................................................................................... 1900/9308
2019-11-28T18:19:41.4575442Z .........................iiiii...................................................................... 2000/9308
2019-11-28T18:19:51.2708035Z .................................................................................................... 2200/9308
2019-11-28T18:19:53.6801878Z .................................................................................................... 2300/9308
2019-11-28T18:19:58.0762386Z .................................................................................................... 2400/9308
2019-11-28T18:20:19.0664206Z .................................................................................................... 2500/9308
---
2019-11-28T18:22:54.2137357Z ..........................i...............i......................................................... 4800/9308
2019-11-28T18:23:04.2654789Z .................................................................................................... 4900/9308
2019-11-28T18:23:10.0167307Z .................................................................................................... 5000/9308
2019-11-28T18:23:17.7586892Z .................................................................................................... 5100/9308
2019-11-28T18:23:25.1216054Z ...............................ii.ii...........i.................................................... 5200/9308
2019-11-28T18:23:34.1710800Z .................................................................................................... 5400/9308
2019-11-28T18:23:43.9146915Z .................................................................................................... 5500/9308
2019-11-28T18:23:50.8331886Z .............i...................................................................................... 5600/9308
2019-11-28T18:23:56.7452015Z .................................................................................................... 5700/9308
2019-11-28T18:23:56.7452015Z .................................................................................................... 5700/9308
2019-11-28T18:24:07.6006079Z ...................................................................................................i 5800/9308
2019-11-28T18:24:19.4105889Z i...i..ii...........i............................................................................... 5900/9308
2019-11-28T18:24:36.9358889Z .................................................................................................... 6100/9308
2019-11-28T18:24:42.3566202Z .................................................................................................... 6200/9308
2019-11-28T18:24:42.3566202Z .................................................................................................... 6200/9308
2019-11-28T18:24:55.5512197Z ......................i..ii......................................................................... 6300/9308
2019-11-28T18:25:14.7484456Z ..........................................................................................i......... 6500/9308
2019-11-28T18:25:16.8878452Z .................................................................................................... 6600/9308
2019-11-28T18:25:18.9568845Z .................................................................................i.................. 6700/9308
2019-11-28T18:25:21.4688957Z .................................................................................................... 6800/9308
---
2019-11-28T18:29:59.3312328Z failures:
2019-11-28T18:29:59.3318335Z 
2019-11-28T18:29:59.3319310Z ---- [compile-fail] compile-fail/consts/const-fn-error.rs stdout ----
2019-11-28T18:29:59.3319348Z 
2019-11-28T18:29:59.3320169Z error: /checkout/src/test/compile-fail/consts/const-fn-error.rs:7: unexpected error: '7:14: 7:18: references in constant functions may only refer to immutable values [E0658]'
2019-11-28T18:29:59.3321186Z error: /checkout/src/test/compile-fail/consts/const-fn-error.rs:7: expected error not found: E0017
2019-11-28T18:29:59.3321391Z 
2019-11-28T18:29:59.3321550Z error: 1 unexpected errors found, 1 expected errors not found
2019-11-28T18:29:59.3321601Z status: exit code: 1
2019-11-28T18:29:59.3321601Z status: exit code: 1
2019-11-28T18:29:59.3322659Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/compile-fail/consts/const-fn-error.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail/consts/const-fn-error" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail/consts/const-fn-error/auxiliary" "-A" "unused"
2019-11-28T18:29:59.3322951Z unexpected errors (from JSON output): [
2019-11-28T18:29:59.3323170Z         line_num: 7,
2019-11-28T18:29:59.3323241Z         kind: Some(
2019-11-28T18:29:59.3323325Z             Error,
2019-11-28T18:29:59.3323534Z         ),
2019-11-28T18:29:59.3323534Z         ),
2019-11-28T18:29:59.3323602Z         msg: "7:14: 7:18: references in constant functions may only refer to immutable values [E0658]",
2019-11-28T18:29:59.3323994Z ]
2019-11-28T18:29:59.3324043Z 
2019-11-28T18:29:59.3324079Z not found errors (from test file): [
2019-11-28T18:29:59.3324153Z     Error {
---
2019-11-28T18:29:59.3326729Z 
2019-11-28T18:29:59.3329086Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-11-28T18:29:59.3331357Z 
2019-11-28T18:29:59.3331418Z 
2019-11-28T18:29:59.3333226Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/compile-fail" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "compile-fail" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-11-28T18:29:59.3334340Z 
2019-11-28T18:29:59.3334386Z 
2019-11-28T18:29:59.3339024Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-11-28T18:29:59.3339082Z Build completed unsuccessfully in 1:02:31
2019-11-28T18:29:59.3339082Z Build completed unsuccessfully in 1:02:31
2019-11-28T18:29:59.3391772Z == clock drift check ==
2019-11-28T18:29:59.3407996Z   local time: Thu Nov 28 18:29:59 UTC 2019
2019-11-28T18:29:59.6194981Z   network time: Thu, 28 Nov 2019 18:29:59 GMT
2019-11-28T18:29:59.6199854Z == end clock drift check ==
2019-11-28T18:30:00.4305469Z 
2019-11-28T18:30:00.4411715Z ##[error]Bash exited with code '1'.
2019-11-28T18:30:00.4445687Z ##[section]Starting: Checkout
2019-11-28T18:30:00.4447528Z ==============================================================================
2019-11-28T18:30:00.4447571Z Task         : Get sources
2019-11-28T18:30:00.4447621Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-11-28T20:56:27Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-28T19:19:32.8031904Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-28T19:19:32.8226816Z ##[command]git config gc.auto 0
2019-11-28T19:19:33.4311757Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-28T19:19:33.4315833Z ##[command]git config --get-all http.proxy
2019-11-28T19:19:33.4318873Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66606/merge:refs/remotes/pull/66606/merge
---
2019-11-28T20:13:22.7535449Z .................................................................................................... 1600/9309
2019-11-28T20:13:26.8657608Z .................................................................................................... 1700/9309
2019-11-28T20:13:37.7133555Z ........................................i........................................................... 1800/9309
2019-11-28T20:13:44.3875888Z .................................................................................................... 1900/9309
2019-11-28T20:13:56.0305583Z .........................iiiii...................................................................... 2000/9309
2019-11-28T20:14:04.6142776Z .................................................................................................... 2200/9309
2019-11-28T20:14:06.7611268Z .................................................................................................... 2300/9309
2019-11-28T20:14:10.6623086Z .................................................................................................... 2400/9309
2019-11-28T20:14:29.1893947Z .................................................................................................... 2500/9309
---
2019-11-28T20:16:46.7838123Z ..........................i...............i......................................................... 4800/9309
2019-11-28T20:16:55.8667278Z .................................................................................................... 4900/9309
2019-11-28T20:17:01.1196256Z .................................................................................................... 5000/9309
2019-11-28T20:17:08.0961301Z .................................................................................................... 5100/9309
2019-11-28T20:17:14.6021453Z ...............................ii.ii...........i.................................................... 5200/9309
2019-11-28T20:17:22.6627120Z .................................................................................................... 5400/9309
2019-11-28T20:17:31.7702744Z .................................................................................................... 5500/9309
2019-11-28T20:17:38.3052570Z .............i...................................................................................... 5600/9309
2019-11-28T20:17:43.6531502Z .................................................................................................... 5700/9309
2019-11-28T20:17:43.6531502Z .................................................................................................... 5700/9309
2019-11-28T20:17:53.2899072Z ...................................................................................................i 5800/9309
2019-11-28T20:18:03.9388093Z i...i..ii...........i............................................................................... 5900/9309
2019-11-28T20:18:19.3712754Z .................................................................................................... 6100/9309
2019-11-28T20:18:22.5039659Z .................................................................................................... 6200/9309
2019-11-28T20:18:22.5039659Z .................................................................................................... 6200/9309
2019-11-28T20:18:34.3478382Z ......................i..ii......................................................................... 6300/9309
2019-11-28T20:18:51.3454638Z ..........................................................................................i......... 6500/9309
2019-11-28T20:18:53.3150400Z .................................................................................................... 6600/9309
2019-11-28T20:18:55.2312802Z .................................................................................i.................. 6700/9309
2019-11-28T20:18:57.4548752Z .................................................................................................... 6800/9309
---
2019-11-28T20:23:36.1607637Z  finished in 5.374
2019-11-28T20:23:36.1830609Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-28T20:23:36.3579035Z 
2019-11-28T20:23:36.3581452Z running 164 tests
2019-11-28T20:23:38.9105393Z iiii....iii......iii..iiii...i.............................i..i..................i....i...........ii 100/164
2019-11-28T20:23:40.5822722Z .i.i..iiii..iiiiiii............i.........iii.i..........ii......
2019-11-28T20:23:40.5824035Z 
2019-11-28T20:23:40.5828258Z  finished in 4.401
2019-11-28T20:23:40.5996653Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-28T20:23:40.7534099Z 
---
2019-11-28T20:23:42.4469197Z  finished in 1.847
2019-11-28T20:23:42.4670714Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-28T20:23:42.6175311Z 
2019-11-28T20:23:42.6175690Z running 9 tests
2019-11-28T20:23:42.6176819Z iiiiiiiii
2019-11-28T20:23:42.6177191Z 
2019-11-28T20:23:42.6177230Z  finished in 0.150
2019-11-28T20:23:42.6339608Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-28T20:23:42.8059543Z 
---
2019-11-28T20:23:59.4293254Z  finished in 16.795
2019-11-28T20:23:59.4490007Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-28T20:23:59.6165552Z 
2019-11-28T20:23:59.6166271Z running 124 tests
2019-11-28T20:24:19.7893290Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i....ii...i.......ii 100/124
2019-11-28T20:24:24.0161043Z .i.i.i......iii.i.....ii
2019-11-28T20:24:24.0163336Z 
2019-11-28T20:24:24.0166093Z  finished in 24.567
2019-11-28T20:24:24.0172367Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-28T20:24:24.0173328Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-11-28T20:34:27.6791232Z 
2019-11-28T20:34:27.6796824Z    Doc-tests core
2019-11-28T20:34:32.1265727Z 
2019-11-28T20:34:32.1266612Z running 2421 tests
2019-11-28T20:34:41.2231208Z ......iiiii......................................................................................... 100/2421
2019-11-28T20:35:00.4285062Z .................................................................................................... 300/2421
2019-11-28T20:35:10.9230563Z ..i................................................................................................. 400/2421
2019-11-28T20:35:10.9230563Z ..i................................................................................................. 400/2421
2019-11-28T20:35:19.5412400Z ..................................................i..i..................iiii........................ 500/2421
2019-11-28T20:35:36.0615678Z .................................................................................................... 700/2421
2019-11-28T20:35:44.4975432Z .................................................................................................... 800/2421
2019-11-28T20:35:53.0053759Z .................................................................................................... 900/2421
2019-11-28T20:36:01.5566715Z .................................................................................................... 1000/2421
---
2019-11-28T20:39:24.7117669Z ..thread '<unnamed>' panicked at 'test panic in inner thread to poison RwLock', src/libstd/sync/rwlock.rs:768:13
2019-11-28T20:39:24.7126693Z ...thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/rwlock.rs:705:13
2019-11-28T20:39:24.7135388Z thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/rwlock.rs:635:13
2019-11-28T20:39:24.7135974Z thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/rwlock.rs:646:13
2019-11-28T20:39:24.7141170Z ....thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/rwlock.rs:611:13
2019-11-28T20:39:24.7146620Z thread '<unnamed>' panicked at '..explicit panic', src/libstd/sync/rwlock.rs:623:13
2019-11-28T20:39:26.7665585Z .......................thread '<unnamed>' panicked at 'What the answer to my lifetimes dilemma is?', src/libstd/sys_common/remutex.rs:233:13
2019-11-28T20:39:26.7793013Z .............................thread '<unnamed>' panicked at 'explicit panic', src/libstd/thread/mod.rs:1544:13
2019-11-28T20:39:27.3856281Z .............thread '<unnamed>' panicked at 'Box<Any>', src/libstd/thread/mod.rs:1676:13
2019-11-28T20:39:27.3856638Z thread '<unnamed>' panicked at 'owned string', src/libstd/thread/mod.rs:1662:13
2019-11-28T20:39:27.3856867Z thread '<unnamed>' panicked at 'static string', src/libstd/thread/mod.rs:1648:13
---
2019-11-28T20:39:33.8382668Z 
2019-11-28T20:39:33.8399489Z running 999 tests
2019-11-28T20:39:50.4479559Z i................................................................................................... 100/999
2019-11-28T20:40:00.0716568Z .................................................................................................... 200/999
2019-11-28T20:40:06.8723928Z ..................iii......i......i...i......i...................................................... 300/999
2019-11-28T20:40:11.4305687Z .................................................................................................... 400/999
2019-11-28T20:40:18.2167978Z ..........................................i..i.................................ii................... 500/999
2019-11-28T20:40:30.8158019Z .................................................................................................... 700/999
2019-11-28T20:40:30.8158019Z .................................................................................................... 700/999
2019-11-28T20:40:37.2192036Z .........................iiii....................................................................... 800/999
2019-11-28T20:40:50.0546859Z .................................................................................................... 900/999
2019-11-28T20:40:56.2413012Z ...............................................iiii................................................
2019-11-28T20:40:56.2413883Z 
2019-11-28T20:40:56.2466221Z  finished in 164.961
2019-11-28T20:40:56.2478635Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-28T20:40:56.4302248Z    Compiling term v0.0.0 (/checkout/src/libterm)
---
2019-11-28T20:56:21.2814939Z ---- /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0017 (line 304) stdout ----
2019-11-28T20:56:21.2815001Z error[E0658]: references in constants may only refer to immutable values
2019-11-28T20:56:21.2815224Z  --> /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md:309:22
2019-11-28T20:56:21.2815267Z   |
2019-11-28T20:56:21.2815312Z 7 | const CR: &mut i32 = &mut C;
2019-11-28T20:56:21.2815354Z   |                      ^^^^^^ constants require immutable values
2019-11-28T20:56:21.2815390Z   |
2019-11-28T20:56:21.2815738Z   = note: for more information, see ***/issues/57349
2019-11-28T20:56:21.2815790Z   = help: add `#![feature(const_mut_refs)]` to the crate attributes to enable
2019-11-28T20:56:21.2815866Z error[E0658]: references in statics may only refer to immutable values
2019-11-28T20:56:21.2816110Z  --> /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md:310:39
2019-11-28T20:56:21.2816157Z   |
2019-11-28T20:56:21.2816364Z 8 | static STATIC_REF: &'static mut i32 = &mut X;
2019-11-28T20:56:21.2816364Z 8 | static STATIC_REF: &'static mut i32 = &mut X;
2019-11-28T20:56:21.2816412Z   |                                       ^^^^^^ statics require immutable values
2019-11-28T20:56:21.2816449Z   |
2019-11-28T20:56:21.2816699Z   = note: for more information, see ***/issues/57349
2019-11-28T20:56:21.2816748Z   = help: add `#![feature(const_mut_refs)]` to the crate attributes to enable
2019-11-28T20:56:21.2816820Z error[E0596]: cannot borrow immutable static item `X` as mutable
2019-11-28T20:56:21.2817047Z  --> /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md:310:39
2019-11-28T20:56:21.2817088Z   |
2019-11-28T20:56:21.2817277Z 8 | static STATIC_REF: &'static mut i32 = &mut X;
---
2019-11-28T20:56:21.2817823Z   |
2019-11-28T20:56:21.2818011Z 9 | static CONST_REF: &'static mut i32 = &mut C;
2019-11-28T20:56:21.2818067Z   |                                      ^^^^^^ statics require immutable values
2019-11-28T20:56:21.2818103Z   |
2019-11-28T20:56:21.2818349Z   = note: for more information, see ***/issues/57349
2019-11-28T20:56:21.2818404Z   = help: add `#![feature(const_mut_refs)]` to the crate attributes to enable
2019-11-28T20:56:21.2818467Z error: aborting due to 4 previous errors
2019-11-28T20:56:21.2818492Z 
2019-11-28T20:56:21.2818535Z Some errors have detailed explanations: E0596, E0658.
2019-11-28T20:56:21.2818754Z For more information about an error, try `rustc --explain E0596`.
2019-11-28T20:56:21.2818754Z For more information about an error, try `rustc --explain E0596`.
2019-11-28T20:56:21.2818800Z Some expected error codes were not found: ["E0017"]
2019-11-28T20:56:21.2818878Z failures:
2019-11-28T20:56:21.2819129Z     /checkout/obj/build/x86_64-unknown-linux-gnu/test/error-index.md - Rust_Compiler_Error_Index::E0017 (line 304)
2019-11-28T20:56:21.2819161Z 
2019-11-28T20:56:21.2819209Z test result: FAILED. 793 passed; 1 failed; 28 ignored; 0 measured; 0 filtered out
---
2019-11-28T20:56:21.2823441Z   local time: Thu Nov 28 20:56:21 UTC 2019
2019-11-28T20:56:21.7875496Z   network time: Thu, 28 Nov 2019 20:56:21 GMT
2019-11-28T20:56:21.7877734Z == end clock drift check ==
2019-11-28T20:56:22.4494441Z 
2019-11-28T20:56:22.4579498Z ##[error]Bash exited with code '1'.
2019-11-28T20:56:22.4619183Z ##[section]Starting: Checkout
2019-11-28T20:56:22.4621960Z ==============================================================================
2019-11-28T20:56:22.4622025Z Task         : Get sources
2019-11-28T20:56:22.4622079Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

pvdrz · 2019-11-28T21:08:45Z

So this is basically making E0017 obsolete. Are we ok with this? @oli-obk @Centril

oli-obk · 2019-11-29T10:40:03Z

Yes, please retire it and all references to it.

src/librustc_error_codes/error_codes/E0017.md

rust-highfive · 2019-11-30T15:46:57Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-30T15:40:40.2961667Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-30T15:40:41.1149840Z ##[command]git config gc.auto 0
2019-11-30T15:40:41.1156193Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-30T15:40:41.1162227Z ##[command]git config --get-all http.proxy
2019-11-30T15:40:41.1167033Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66606/merge:refs/remotes/pull/66606/merge
---
2019-11-30T15:46:50.9251004Z * 589 error codes
2019-11-30T15:46:50.9251196Z * highest error code: E0745
2019-11-30T15:46:51.3264787Z * 274 features
2019-11-30T15:46:52.0876202Z Checking which error codes lack tests...
2019-11-30T15:46:52.2740654Z Couldn't read `/checkout/src/librustc_error_codes/./error_codes/E0017.md`: No such file or directory (os error 2)
2019-11-30T15:46:52.2958892Z Error code E0017 needs to have at least one UI test!
2019-11-30T15:46:52.2959086Z some tidy checks failed
2019-11-30T15:46:52.2959188Z Found 1 error codes with no tests
2019-11-30T15:46:52.2959274Z Done!
2019-11-30T15:46:52.2959307Z 
2019-11-30T15:46:52.2959337Z 
2019-11-30T15:46:52.2959337Z 
2019-11-30T15:46:52.2960201Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-11-30T15:46:52.2960348Z 
2019-11-30T15:46:52.2960377Z 
2019-11-30T15:46:52.2960450Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-11-30T15:46:52.2960508Z Build completed unsuccessfully in 0:01:31
2019-11-30T15:46:52.2960508Z Build completed unsuccessfully in 0:01:31
2019-11-30T15:46:52.3010060Z == clock drift check ==
2019-11-30T15:46:52.3032606Z   local time: Sat Nov 30 15:46:52 UTC 2019
2019-11-30T15:46:52.3858025Z   network time: Sat, 30 Nov 2019 15:46:52 GMT
2019-11-30T15:46:52.3878029Z == end clock drift check ==
2019-11-30T15:46:53.6696858Z 
2019-11-30T15:46:53.6805044Z ##[error]Bash exited with code '1'.
2019-11-30T15:46:53.6862199Z ##[section]Starting: Checkout
2019-11-30T15:46:53.6864415Z ==============================================================================
2019-11-30T15:46:53.6864478Z Task         : Get sources
2019-11-30T15:46:53.6864531Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

oli-obk · 2019-12-06T10:30:40Z

@bors r+

bors · 2019-12-06T10:30:41Z

📌 Commit e01ad6a has been approved by oli-obk

bors · 2019-12-06T10:56:15Z

⌛ Testing commit e01ad6a with merge 4e66dc63b5d28752120b745e005c12fa59ae8db6...

bors · 2019-12-06T14:05:04Z

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing 4e66dc63b5d28752120b745e005c12fa59ae8db6 to master...

bors · 2019-12-06T14:05:09Z

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

Mark-Simulacrum · 2019-12-06T15:41:03Z

@bors retry

@oli-obk

…n, r=oli-obk Add feature gate for mut refs in const fn r? @oli-obk

@ghost

Rollup of 10 pull requests Successful merges: - #66606 (Add feature gate for mut refs in const fn) - #66841 (Add `{f32,f64}::approx_unchecked_to<Int>` unsafe methods) - #67009 (Emit coercion suggestions in more places) - #67052 (Ditch `parse_in_attr`) - #67071 (Do not ICE on closure typeck) - #67078 (accept union inside enum if not followed by identifier) - #67090 (Change "either" to "any" in Layout::from_size_align's docs) - #67092 (Fix comment typos in src/libcore/alloc.rs) - #67094 (get rid of __ in field names) - #67102 (Add note to src/ci/docker/README.md about multiple docker images) Failed merges: - #67101 (use `#[allow(unused_attributes)]` to paper over incr.comp problem) r? @ghost

bors · 2019-12-07T02:45:37Z

⌛ Testing commit e01ad6a with merge 41601a8...

fix link to rust-lang/rust#66606

rust-highfive assigned oli-obk Nov 21, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 21, 2019

This comment has been minimized.

Sign in to view

oli-obk reviewed Nov 21, 2019

View reviewed changes

src/test/ui/consts/const_fn_mut_refs.rs Outdated Show resolved Hide resolved

pvdrz mentioned this pull request Nov 21, 2019

Make core::mem::zeroed() a const fn #62061

Closed

Centril reviewed Nov 21, 2019

View reviewed changes

src/test/ui/consts/const-eval/feature-gate-const_fn_mut_refs.rs Outdated Show resolved Hide resolved

src/libsyntax/feature_gate/active.rs Outdated Show resolved Hide resolved

src/test/ui/consts/const_fn_mut_refs.rs Outdated Show resolved Hide resolved

Centril added the F-const_mut_refs `#![feature(const_mut_refs)]` label Nov 21, 2019

This comment has been minimized.

Sign in to view

oli-obk reviewed Nov 23, 2019

View reviewed changes

src/test/ui/consts/const-mut-refs/const_mut_refs.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

oli-obk reviewed Nov 26, 2019

View reviewed changes

src/librustc_mir/transform/check_consts/ops.rs Show resolved Hide resolved

oli-obk reviewed Nov 26, 2019

View reviewed changes

src/test/ui/consts/const-mut-refs/mutable_references_ice.rs Outdated Show resolved Hide resolved

Centril reviewed Nov 26, 2019

View reviewed changes

src/librustc_mir/transform/check_consts/validation.rs Outdated Show resolved Hide resolved

Centril reviewed Nov 26, 2019

View reviewed changes

oli-obk reviewed Nov 27, 2019

View reviewed changes

src/test/ui/consts/miri_unleashed/mutable_const.rs Outdated Show resolved Hide resolved

oli-obk requested changes Nov 27, 2019

View reviewed changes

oli-obk reviewed Nov 30, 2019

View reviewed changes

src/librustc_error_codes/error_codes/E0017.md Outdated Show resolved Hide resolved

pvdrz added 12 commits December 2, 2019 09:03

Rename feature gate

d24ae25

Allow mutable borrows in constant bodies

1f420b9

Move and rewrite tests to use &mut in constants

de60f72

Allow mutable derefs with feature gate

d92e9b7

Extend test for const_mut_refs feature

e31a136

Disallow cell borrowing

683f5c9

Update miri_unleashed tests

681690d

Suggest feature for const_mut_refs errors

5e61e4c

Update miri unleashed tests

19ddfb5

Add dual tests for const_mut_refs

dc0117a

Correct other tests related to const_mut_refs

416b439

Remove E0017 from error codes index

e01ad6a

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 6, 2019

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 6, 2019

Centril added a commit to Centril/rust that referenced this pull request Dec 6, 2019

Rollup merge of rust-lang#66606 - christianpoveda:mut-refs-in-const-f…

2bd35c0

…n, r=oli-obk Add feature gate for mut refs in const fn r? @oli-obk

Centril mentioned this pull request Dec 6, 2019

Rollup of 10 pull requests #67104

Merged

bors merged commit e01ad6a into rust-lang:master Dec 7, 2019

tanriol added a commit to tanriol/this-week-in-rust that referenced this pull request Dec 12, 2019

fix link to rust-lang/rust#66606

d1ad696

nasa42 added a commit to rust-lang/this-week-in-rust that referenced this pull request Dec 13, 2019

Merge pull request #1099 from tanriol/patch-1

fbd91f8

fix link to rust-lang/rust#66606

RalfJung mentioned this pull request May 1, 2020

Miri: unleash all feature gates #71631

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add feature gate for mut refs in const fn #66606

Add feature gate for mut refs in const fn #66606

pvdrz commented Nov 21, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

oli-obk commented Nov 23, 2019

This comment has been minimized.

Centril commented Nov 23, 2019

pvdrz commented Nov 23, 2019

pvdrz commented Nov 25, 2019

Centril Nov 26, 2019

pvdrz Nov 26, 2019 •

edited

Loading

pvdrz Nov 27, 2019

rust-highfive commented Nov 27, 2019

rust-highfive commented Nov 28, 2019

rust-highfive commented Nov 28, 2019

pvdrz commented Nov 28, 2019

oli-obk commented Nov 29, 2019

rust-highfive commented Nov 30, 2019

oli-obk commented Dec 6, 2019

bors commented Dec 6, 2019

bors commented Dec 6, 2019

bors commented Dec 6, 2019

bors commented Dec 6, 2019

Mark-Simulacrum commented Dec 6, 2019

bors commented Dec 7, 2019

Add feature gate for mut refs in const fn #66606

Add feature gate for mut refs in const fn #66606

Conversation

pvdrz commented Nov 21, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

oli-obk commented Nov 23, 2019

This comment has been minimized.

Centril commented Nov 23, 2019

pvdrz commented Nov 23, 2019

pvdrz commented Nov 25, 2019

Centril Nov 26, 2019

Choose a reason for hiding this comment

pvdrz Nov 26, 2019 • edited Loading

Choose a reason for hiding this comment

pvdrz Nov 27, 2019

Choose a reason for hiding this comment

rust-highfive commented Nov 27, 2019

rust-highfive commented Nov 28, 2019

rust-highfive commented Nov 28, 2019

pvdrz commented Nov 28, 2019

oli-obk commented Nov 29, 2019

rust-highfive commented Nov 30, 2019

oli-obk commented Dec 6, 2019

bors commented Dec 6, 2019

bors commented Dec 6, 2019

bors commented Dec 6, 2019

bors commented Dec 6, 2019

Mark-Simulacrum commented Dec 6, 2019

bors commented Dec 7, 2019

pvdrz Nov 26, 2019 •

edited

Loading