Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize the `core::panic` module #66771

Open
wants to merge 3 commits into
base: master
from

Conversation

@SimonSapin
Copy link
Contributor

SimonSapin commented Nov 26, 2019

std::panic is already stable.

core::panic::PanicInfo and core::panic::Location are stable and can be used through that path because of a bug in stability checking: #15702

SimonSapin added 3 commits Nov 26, 2019
#44489 was closed when the `#[panic_handler]` attribute was stabilized.
`std::panic` is already stable.

`core::panic::PanicInfo` and `core::panic::Location` are stable
and can be used through that path because of a bug
in stability checking: #15702
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Nov 26, 2019

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@SimonSapin

This comment has been minimized.

Copy link
Contributor Author

SimonSapin commented Nov 26, 2019

@rfcbot fcp merge

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Nov 26, 2019

Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@SimonSapin

This comment has been minimized.

Copy link
Contributor Author

SimonSapin commented Dec 5, 2019

Checkbox ping @Kimundi @KodrAus @sfackler

@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Dec 5, 2019

semi-offtopic: I haven't seen Kimundi participating for years (?) does it still make sense to ping him?

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Dec 6, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.