Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize the `core::panic` module #66771

Merged
merged 3 commits into from Dec 16, 2019
Merged

Conversation

@SimonSapin
Copy link
Contributor

SimonSapin commented Nov 26, 2019

std::panic is already stable.

core::panic::PanicInfo and core::panic::Location are stable and can be used through that path because of a bug in stability checking: #15702

SimonSapin added 3 commits Nov 26, 2019
#44489 was closed when the `#[panic_handler]` attribute was stabilized.
`std::panic` is already stable.

`core::panic::PanicInfo` and `core::panic::Location` are stable
and can be used through that path because of a bug
in stability checking: #15702
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Nov 26, 2019

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@SimonSapin

This comment has been minimized.

Copy link
Contributor Author

SimonSapin commented Nov 26, 2019

@rfcbot fcp merge

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Nov 26, 2019

Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@SimonSapin

This comment has been minimized.

Copy link
Contributor Author

SimonSapin commented Dec 5, 2019

Checkbox ping @Kimundi @KodrAus @sfackler

@petrochenkov

This comment has been minimized.

Copy link
Contributor

petrochenkov commented Dec 5, 2019

semi-offtopic: I haven't seen Kimundi participating for years (?) does it still make sense to ping him?

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Dec 6, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Dec 16, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@KodrAus

This comment has been minimized.

Copy link
Contributor

KodrAus commented Dec 16, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 16, 2019

📌 Commit eab1dc9 has been approved by KodrAus

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 16, 2019

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

Centril added a commit to Centril/rust that referenced this pull request Dec 16, 2019
Stabilize the `core::panic` module

`std::panic` is already stable.

`core::panic::PanicInfo` and `core::panic::Location` are stable and can be used through that path because of a bug in stability checking: rust-lang#15702
bors added a commit that referenced this pull request Dec 16, 2019
Rollup of 7 pull requests

Successful merges:

 - #65778 (Stabilize `std::{rc,sync}::Weak::{weak_count, strong_count}`)
 - #66570 (stabilize Result::map_or)
 - #66735 (Add str::strip_prefix and str::strip_suffix)
 - #66771 (Stabilize the `core::panic` module)
 - #67317 (fix type_name_of_val doc comment)
 - #67324 (Fix repetition in matches/mod.rs)
 - #67325 (cleanup with push_fake_read)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Dec 16, 2019
Rollup of 7 pull requests

Successful merges:

 - #65778 (Stabilize `std::{rc,sync}::Weak::{weak_count, strong_count}`)
 - #66570 (stabilize Result::map_or)
 - #66735 (Add str::strip_prefix and str::strip_suffix)
 - #66771 (Stabilize the `core::panic` module)
 - #67317 (fix type_name_of_val doc comment)
 - #67324 (Fix repetition in matches/mod.rs)
 - #67325 (cleanup with push_fake_read)

Failed merges:

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 16, 2019

⌛️ Testing commit eab1dc9 with merge e7f3de6...

bors added a commit that referenced this pull request Dec 16, 2019
Stabilize the `core::panic` module

`std::panic` is already stable.

`core::panic::PanicInfo` and `core::panic::Location` are stable and can be used through that path because of a bug in stability checking: #15702
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 16, 2019

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-16T07:29:30.3030542Z Chocolatey installed 0/1 packages. 1 packages failed.
2019-12-16T07:29:30.3030809Z  See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
2019-12-16T07:29:30.3035331Z 
2019-12-16T07:29:30.3039642Z Failures
2019-12-16T07:29:30.3048407Z  - msys2 (exited 1) - msys2 not installed. An error occurred during installation:
2019-12-16T07:29:30.3048763Z  The remote server returned an error: (503) Server Unavailable. Service Unavailable
2019-12-16T07:29:30.7783574Z 
2019-12-16T07:29:30.7863035Z ##[error]Bash exited with code '1'.
2019-12-16T07:29:30.8048344Z ##[section]Starting: Checkout
2019-12-16T07:29:30.8254228Z ==============================================================================
2019-12-16T07:29:30.8254355Z Task         : Get sources
2019-12-16T07:29:30.8254445Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 16, 2019

💔 Test failed - checks-azure

bors added a commit that referenced this pull request Dec 16, 2019
Rollup of 7 pull requests

Successful merges:

 - #65778 (Stabilize `std::{rc,sync}::Weak::{weak_count, strong_count}`)
 - #66570 (stabilize Result::map_or)
 - #66735 (Add str::strip_prefix and str::strip_suffix)
 - #66771 (Stabilize the `core::panic` module)
 - #67317 (fix type_name_of_val doc comment)
 - #67324 (Fix repetition in matches/mod.rs)
 - #67325 (cleanup with push_fake_read)

Failed merges:

r? @ghost
@Centril

This comment has been minimized.

Copy link
Member

Centril commented Dec 16, 2019

@bors retry

bors added a commit that referenced this pull request Dec 16, 2019
Rollup of 7 pull requests

Successful merges:

 - #65778 (Stabilize `std::{rc,sync}::Weak::{weak_count, strong_count}`)
 - #66570 (stabilize Result::map_or)
 - #66735 (Add str::strip_prefix and str::strip_suffix)
 - #66771 (Stabilize the `core::panic` module)
 - #67317 (fix type_name_of_val doc comment)
 - #67324 (Fix repetition in matches/mod.rs)
 - #67325 (cleanup with push_fake_read)

Failed merges:

r? @ghost
@bors bors merged commit eab1dc9 into rust-lang:master Dec 16, 2019
4 of 5 checks passed
4 of 5 checks passed
homu Test failed
Details
pr #20191126.26 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.