Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle GlobalCtxt directly from librustc_interface query system #66791

Merged
merged 20 commits into from
Nov 30, 2019
Merged

Handle GlobalCtxt directly from librustc_interface query system #66791

merged 20 commits into from
Nov 30, 2019
+328 −256

Commits on Nov 24, 2019

  1. Isolate compiler queries inside the Queries type.

    @cjgillot
    cjgillot committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    266ede1 View commit details
    Browse the repository at this point in the history

  2. Move linking ouside the interface queries.

    @cjgillot
    cjgillot committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    5098ba6 View commit details
    Browse the repository at this point in the history

  3. Tidy.

    @cjgillot
    cjgillot committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    27513a2 View commit details
    Browse the repository at this point in the history

  4. Fix test.

    @cjgillot
    cjgillot committed Nov 24, 2019
    Configuration menu
    Copy the full SHA
    becfe5c View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2019

  1. Remove wrong comment.

    @cjgillot
    cjgillot committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    18bb912 View commit details
    Browse the repository at this point in the history

  2. Pass Queries by reference.

    @cjgillot
    cjgillot committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    ea1b803 View commit details
    Browse the repository at this point in the history

  3. Simplify early exits.

    @cjgillot
    cjgillot committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    7d01b6c View commit details
    Browse the repository at this point in the history

  4. Don't move stuff out of Compiler::enter.

    @cjgillot
    cjgillot committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    8ffc944 View commit details
    Browse the repository at this point in the history

  5. Superfluous lifetime.

    @cjgillot
    cjgillot committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    9d5f721 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2019

  1. Reduce righward drift.

    @cjgillot
    cjgillot committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    68b1ac9 View commit details
    Browse the repository at this point in the history

  2. Review nits.

    @cjgillot
    cjgillot committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    144d1c2 View commit details
    Browse the repository at this point in the history

  3. Make the HIR map own the Definitions.

    @cjgillot
    cjgillot committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    58a9c73 View commit details
    Browse the repository at this point in the history

  4. Have Queries own the GlobalCtxt. 

    The construction of the GlobalCtxt is moved from a generator's stack to
the Queries struct.  Since the GlobalCtxt requires the HIR Forest and the
arenas to live longer, those are moved into Queries the same way.

The resulting handling of objects is more brittle, because consumers of
the Once objects need to be careful of their initialisation.
    @cjgillot
    cjgillot committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    b99513b View commit details
    Browse the repository at this point in the history

  5. Formatting.

    @cjgillot
    cjgillot committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    7b71e9a View commit details
    Browse the repository at this point in the history

  6. Move local Arena to Queries.

    @cjgillot
    cjgillot committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    7e72b36 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2019

  1. Rename lifetimes.

    @cjgillot
    cjgillot committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    79e2324 View commit details
    Browse the repository at this point in the history

  2. Rename BoxedGlobalCtxt.

    @cjgillot
    cjgillot committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    e5ed101 View commit details
    Browse the repository at this point in the history

  3. Simplify handling of AllArenas.

    @cjgillot
    cjgillot committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    77a4c85 View commit details
    Browse the repository at this point in the history

  4. Misc renames.

    @cjgillot
    cjgillot committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    e321ba9 View commit details
    Browse the repository at this point in the history

  5. Allocate HIR Forest on arena.

    @cjgillot
    cjgillot committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    1e12f39 View commit details
    Browse the repository at this point in the history