Change how the input from rusti is formatted to allow duplicate definitions #6685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool. I wonder whether we should pick a command name like |
| match expr.node { | ||
| ast::expr_assign(*) | | ||
| ast::expr_assign_op(*) | | ||
| _ => {} | ||
| } | ||
| } |
There was a problem hiding this comment.
Is there a reason that this whole match arm can't be replaced with _ => {} ?
There was a problem hiding this comment.
That is a very good question. I originally didn't even look at it because it's what was there before. Looking at this though, this would cause the following input to fail in rusti:
let mut a = 4;
a = 5;
assert!(a == 5);The assignment operation wouldn't be recorded into the history, so I'll add a commit to this in a second which fixes that bug.
|
I have better ideas for what to do with rusti after recent discussions on the mailing list. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 11, 2021
Add new lint `filter_map_identity` <!-- Thank you for making Clippy better! We're collecting our changelog from pull request descriptions. If your PR only includes internal changes, you can just write `changelog: none`. Otherwise, please write a short comment explaining your change. If your PR fixes an issue, you can add "fixes #issue_number" into this PR description. This way the issue will be automatically closed when your PR is merged. If you added a new lint, here's a checklist for things that will be checked during review or continuous integration. - \[x] Followed [lint naming conventions][lint_naming] - \[x] Added passing UI tests (including committed `.stderr` file) - \[x] `cargo test` passes locally - \[x] Executed `cargo dev update_lints` - \[x] Added lint documentation - \[x] Run `cargo dev fmt` [lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints Note that you can skip the above if you are just opening a WIP PR in order to get feedback. Delete this line and everything above before opening your PR. --> This commit adds a new lint named filter_map_identity. This lint is the same as `flat_map_identity` except that it checks for the usage of `filter_map`. --- Closes rust-lang#6643 changelog: Added a new lint: `filter_map_identity`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5675, #6617, and #6772
This changes each recorded declaration/stmt to be in its own block to allow for duplicate names. It also fixes #6617 while I was at it by changing the generic
printtopp