Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable loop and while in constants behind a feature flag #67216

Merged
merged 19 commits into from
Dec 15, 2019
Merged

Enable loop and while in constants behind a feature flag #67216

merged 19 commits into from
Dec 15, 2019

Commits on Dec 13, 2019

  1. Get active features dynamically by their Symbol

    @ecstatic-morse
    ecstatic-morse committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    8f3021b View commit details
    Browse the repository at this point in the history

  2. Add feature gate for const_loop

    @ecstatic-morse
    ecstatic-morse committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    57959b2 View commit details
    Browse the repository at this point in the history

  3. Put MIR checks for loops behind the feature flag

    @ecstatic-morse
    ecstatic-morse committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    8f59902 View commit details
    Browse the repository at this point in the history

  4. Restructue HIR const-checker to handle features with multiple gates

    @ecstatic-morse
    ecstatic-morse committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    ee233c0 View commit details
    Browse the repository at this point in the history

  5. Extend control flow basics tests with loops

    @ecstatic-morse
    ecstatic-morse committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    99e132d View commit details
    Browse the repository at this point in the history

  6. Add qualif smoke tests for const loops

    @ecstatic-morse
    ecstatic-morse committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    1122404 View commit details
    Browse the repository at this point in the history

  7. Bless unrelated tests with new help message

    @ecstatic-morse
    ecstatic-morse committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    caa7c99 View commit details
    Browse the repository at this point in the history

  8. Bless modified tests

    @ecstatic-morse
    ecstatic-morse committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    3325671 View commit details
    Browse the repository at this point in the history

  9. Improve message when active feature indexing panics

    @ecstatic-morse
    ecstatic-morse committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    2add77d View commit details
    Browse the repository at this point in the history

  10. Improve comment

    @ecstatic-morse
    ecstatic-morse committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    a8e997c View commit details
    Browse the repository at this point in the history

  11. Look for "unstable feature" error code in test 

    Conditionals and loops now have unstable features, and `feature_err` has
its own error code. I think that `feature_err` should take an error code
as a parameter, but don't have the energy to make this change throughout
the codebase. Also, the error code system may be torn out entirely.
    @ecstatic-morse
    ecstatic-morse committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    a2a0774 View commit details
    Browse the repository at this point in the history

  12. Fix grammar in test description 

    Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
    @ecstatic-morse @Centril
    ecstatic-morse and Centril committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    b3aecd0 View commit details
    Browse the repository at this point in the history

  13. Apply suggestions from review

    @ecstatic-morse
    ecstatic-morse committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    2b5ae1c View commit details
    Browse the repository at this point in the history

  14. Replace Index impl with enabled method

    @ecstatic-morse
    ecstatic-morse committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    80581be View commit details
    Browse the repository at this point in the history

  15. Use better name for local containing required feature gates

    @ecstatic-morse
    ecstatic-morse committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    34ce0ba View commit details
    Browse the repository at this point in the history

  16. Ensure test actually uses dataflow, not simulation

    @ecstatic-morse
    ecstatic-morse committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    598bed6 View commit details
    Browse the repository at this point in the history

  17. Use correct nightly version for feature

    @ecstatic-morse
    ecstatic-morse committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    029725f View commit details
    Browse the repository at this point in the history

  18. Document Features::enabled 

    Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
    @ecstatic-morse @Centril
    ecstatic-morse and Centril committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    0f0bfc9 View commit details
    Browse the repository at this point in the history

  19. Correctly mark things as min_const_fn

    @ecstatic-morse
    ecstatic-morse committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    faa52d1 View commit details
    Browse the repository at this point in the history