Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make transparent enums more ordinary #67323

Merged
merged 1 commit into from Dec 16, 2019
Merged

make transparent enums more ordinary #67323

merged 1 commit into from Dec 16, 2019

Conversation

@Centril
Copy link
Member

Centril commented Dec 15, 2019

By recognizing that structs & unions have one variant, we can make the treatment of transparent enums less ad-hoc.

cc #60405

r? @davidtwco

@davidtwco

This comment has been minimized.

Copy link
Member

davidtwco commented Dec 16, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 16, 2019

📌 Commit 5d73af2 has been approved by davidtwco

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 16, 2019

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

Centril added a commit to Centril/rust that referenced this pull request Dec 16, 2019
make transparent enums more ordinary

By recognizing that structs & unions have one variant, we can make the treatment of transparent enums less ad-hoc.

cc rust-lang#60405

r? @davidtwco
Centril added a commit to Centril/rust that referenced this pull request Dec 16, 2019
make transparent enums more ordinary

By recognizing that structs & unions have one variant, we can make the treatment of transparent enums less ad-hoc.

cc rust-lang#60405

r? @davidtwco
bors added a commit that referenced this pull request Dec 16, 2019
Rollup of 8 pull requests

Successful merges:

 - #67249 (Improve code generated for `starts_with(<literal char>)`)
 - #67308 (Delete flaky test net::tcp::tests::fast_rebind)
 - #67318 (Improve typeck & lowering docs for slice patterns)
 - #67322 (use Self alias in place of macros)
 - #67323 (make transparent enums more ordinary)
 - #67336 (Fix JS error when loading page with search)
 - #67344 (.gitignore: Don't ignore a file that exists in the repository)
 - #67349 (Minor: update Unsize docs for dyn syntax)

Failed merges:

r? @ghost
@bors bors merged commit 5d73af2 into rust-lang:master Dec 16, 2019
4 checks passed
4 checks passed
pr #20191215.28 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@Centril Centril deleted the Centril:tes branch Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.