Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require const stability attributes on intrinsics to be able to use them in constant contexts #67466

Merged
merged 3 commits into from Dec 23, 2019

Conversation

@oli-obk
Copy link
Contributor

oli-obk commented Dec 20, 2019

r? @Centril

finally fixes #61495

cc @RalfJung

…em in constant contexts
@Centril

This comment has been minimized.

Copy link
Member

Centril commented Dec 20, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 20, 2019

📌 Commit 032d810 has been approved by Centril

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 20, 2019

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Dec 21, 2019

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-20T23:08:24.8145394Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-20T23:08:24.8337204Z ##[command]git config gc.auto 0
2019-12-20T23:08:24.8411974Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-20T23:08:24.8471764Z ##[command]git config --get-all http.proxy
2019-12-20T23:08:24.8672187Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67466/merge:refs/remotes/pull/67466/merge
---
2019-12-21T00:07:33.3586650Z .................................................................................................... 1600/9403
2019-12-21T00:07:37.9380176Z .................................................................................................... 1700/9403
2019-12-21T00:07:49.3051581Z ................................................................................i................... 1800/9403
2019-12-21T00:07:56.0975070Z .................................................................................................... 1900/9403
2019-12-21T00:08:04.3837126Z .................................................................iiiii.............................. 2000/9403
2019-12-21T00:08:22.7384444Z .................................................................................................... 2200/9403
2019-12-21T00:08:25.1602647Z .................................................................................................... 2300/9403
2019-12-21T00:08:27.9941051Z .................................................................................................... 2400/9403
2019-12-21T00:08:48.4290838Z .................................................................................................... 2500/9403
---
2019-12-21T00:11:25.2824130Z .........................................................................i...............i.......... 4800/9403
2019-12-21T00:11:32.9007242Z .................................................................................................... 4900/9403
2019-12-21T00:11:41.3181424Z .................................................................................................... 5000/9403
2019-12-21T00:11:46.1168929Z .................i.................................................................................. 5100/9403
2019-12-21T00:11:57.1867498Z ....................................................................................ii.ii........... 5200/9403
2019-12-21T00:12:01.0373199Z i................................................................................................... 5300/9403
2019-12-21T00:12:15.3481354Z .................................................................................................... 5500/9403
2019-12-21T00:12:22.0699016Z ..................................................................i................................. 5600/9403
2019-12-21T00:12:29.3216656Z .................................................................................................... 5700/9403
2019-12-21T00:12:36.7280793Z .................................................................................................... 5800/9403
2019-12-21T00:12:36.7280793Z .................................................................................................... 5800/9403
2019-12-21T00:12:45.7423279Z ......................................................ii...i..ii...........i........................ 5900/9403
2019-12-21T00:13:07.7512577Z .................................................................................................... 6100/9403
2019-12-21T00:13:15.8182280Z .................................................................................................... 6200/9403
2019-12-21T00:13:15.8182280Z .................................................................................................... 6200/9403
2019-12-21T00:13:24.6622883Z ...............................................................................i..ii................ 6300/9403
2019-12-21T00:13:59.3513555Z .................................................................................................... 6500/9403
2019-12-21T00:14:04.0359354Z .....................................................i.............................................. 6600/9403
2019-12-21T00:14:06.2241197Z .................................................................................................... 6700/9403
2019-12-21T00:14:08.4700075Z ..................................................i................................................. 6800/9403
---
2019-12-21T00:15:43.6398977Z .................................................................................................... 7400/9403
2019-12-21T00:15:47.6075994Z .................................................................................................... 7500/9403
2019-12-21T00:15:53.2488701Z .................................................................................................... 7600/9403
2019-12-21T00:16:01.1285727Z .................................................................................................... 7700/9403
2019-12-21T00:16:11.0573863Z ..........................................................................iiii...................... 7800/9403
2019-12-21T00:16:26.4460414Z .....i......i....................................................................................... 8000/9403
2019-12-21T00:16:31.5651520Z .................................................................................................... 8100/9403
2019-12-21T00:16:45.8798253Z .................................................................................................... 8200/9403
2019-12-21T00:16:54.6026251Z .................................................................................................... 8300/9403
---
2019-12-21T00:19:16.9634494Z  finished in 6.335
2019-12-21T00:19:16.9828506Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-21T00:19:17.1669045Z 
2019-12-21T00:19:17.1670077Z running 166 tests
2019-12-21T00:19:20.1751963Z iiii......i........ii..iiii...i.............................i..i..................i....i............ 100/166
2019-12-21T00:19:22.2817422Z i.i.i...iii..iiiiii.i......................iii............ii......
2019-12-21T00:19:22.2825365Z 
2019-12-21T00:19:22.2825439Z  finished in 5.299
2019-12-21T00:19:22.3005935Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-21T00:19:22.4654632Z 
---
2019-12-21T00:19:24.4364926Z  finished in 2.136
2019-12-21T00:19:24.4555347Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-21T00:19:24.6125743Z 
2019-12-21T00:19:24.6125994Z running 9 tests
2019-12-21T00:19:24.6126805Z iiiiiiiii
2019-12-21T00:19:24.6127386Z 
2019-12-21T00:19:24.6127491Z  finished in 0.157
2019-12-21T00:19:24.6316527Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-21T00:19:24.8122717Z 
---
2019-12-21T00:19:43.8921201Z  finished in 19.260
2019-12-21T00:19:43.9152743Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-21T00:19:44.0980755Z 
2019-12-21T00:19:44.0981076Z running 124 tests
2019-12-21T00:20:08.2511857Z .iiiii..ii.....i..i...i..i.i.i..i..i..iii....ii.ii....ii..........iiii..........i.....i..ii.......ii 100/124
2019-12-21T00:20:12.3999216Z .i.iii.....iiiiii.....ii
2019-12-21T00:20:12.4002974Z 
2019-12-21T00:20:12.4003254Z  finished in 28.485
2019-12-21T00:20:12.4008243Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-21T00:20:12.4009761Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-12-21T00:33:32.7113050Z 
2019-12-21T00:33:32.7114228Z    Doc-tests core
2019-12-21T00:33:37.1291339Z 
2019-12-21T00:33:37.1292481Z running 2439 tests
2019-12-21T00:33:46.0145377Z ......iiiii......................................................................................... 100/2439
2019-12-21T00:33:54.7997487Z ..................................................................................ii................ 200/2439
2019-12-21T00:34:15.0852151Z ................i................................................................................... 400/2439
2019-12-21T00:34:15.0852151Z ................i................................................................................... 400/2439
2019-12-21T00:34:24.4270370Z ................................................................i..i..................iiii.......... 500/2439
2019-12-21T00:34:40.4747970Z .................................................................................................... 700/2439
2019-12-21T00:34:48.9003776Z .................................................................................................... 800/2439
2019-12-21T00:34:57.1787759Z .................................................................................................... 900/2439
2019-12-21T00:35:05.5142953Z .................................................................................................... 1000/2439
---
2019-12-21T00:38:48.9665059Z 
2019-12-21T00:38:48.9666573Z running 1003 tests
2019-12-21T00:39:06.6922133Z i................................................................................................... 100/1003
2019-12-21T00:39:17.1121234Z .................................................................................................... 200/1003
2019-12-21T00:39:24.1503625Z ..................ii.i.....i......i...i......i...................................................... 300/1003
2019-12-21T00:39:28.9251336Z .................................................................................................... 400/1003
2019-12-21T00:39:35.6001288Z ..........................................i..i.....................................ii............... 500/1003
2019-12-21T00:39:48.1812114Z .................................................................................................... 700/1003
2019-12-21T00:39:48.1812114Z .................................................................................................... 700/1003
2019-12-21T00:39:54.5250682Z .............................iiii................................................................... 800/1003
2019-12-21T00:40:08.3304247Z .................................................................................................... 900/1003
2019-12-21T00:40:15.0953203Z ...................................................iiii............................................. 1000/1003
2019-12-21T00:40:15.1840587Z test result: ok. 983 passed; 0 failed; 20 ignored; 0 measured; 0 filtered out
2019-12-21T00:40:15.1840691Z 
2019-12-21T00:40:15.1971363Z  finished in 180.292
2019-12-21T00:40:15.1987537Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2019-12-21T00:57:19.6081315Z     Checking rustc-std-workspace-core v1.99.0 (/checkout/src/tools/rustc-std-workspace-core)
2019-12-21T00:57:20.5902856Z  Documenting alloc v0.0.0 (/checkout/src/liballoc)
2019-12-21T00:57:23.3276240Z     Finished release [optimized] target(s) in 22.68s
2019-12-21T00:57:23.6683387Z  Documenting core v0.0.0 (/checkout/src/libcore)
2019-12-21T00:57:34.6966130Z error: `[std::u32::rotate_right]` cannot be resolved, ignoring it.
2019-12-21T00:57:34.6968198Z      |
2019-12-21T00:57:34.6968198Z      |
2019-12-21T00:57:34.6969684Z 1340 |     /// [`std::u32::rotate_right`](../../std/primitive.u32.html#method.rotate_right
2019-12-21T00:57:34.6971582Z      |
2019-12-21T00:57:34.6972270Z note: lint level defined here
2019-12-21T00:57:34.6972819Z     --> src/libcore/lib.rs:64:9
2019-12-21T00:57:34.6973348Z      |
2019-12-21T00:57:34.6973348Z      |
2019-12-21T00:57:34.6973961Z 64   | #![deny(intra_doc_link_resolution_failure)] // rustdoc is run without -D warnings
2019-12-21T00:57:34.6975118Z      = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
2019-12-21T00:57:34.6975398Z 
2019-12-21T00:57:35.1365447Z error: aborting due to previous error
2019-12-21T00:57:35.1366233Z 
2019-12-21T00:57:35.1366233Z 
2019-12-21T00:57:35.1712283Z error: Could not document `core`.
2019-12-21T00:57:35.1713219Z 
2019-12-21T00:57:35.1713498Z Caused by:
2019-12-21T00:57:35.1714651Z   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --edition=2018 --crate-type lib --crate-name core src/libcore/lib.rs --target x86_64-unknown-linux-gnu -o /checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/doc --error-format=json --json=diagnostic-rendered-ansi --markdown-css rust.css --markdown-no-toc --generate-redirect-pages --resource-suffix 1.42.0 --index-page /checkout/src/doc/index.md -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/release/deps` (exit code: 1)
2019-12-21T00:57:35.1740470Z 
2019-12-21T00:57:35.1740470Z 
2019-12-21T00:57:35.1741632Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustdoc" "-Zconfig-profile" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "-Z" "unstable-options" "-p" "core" "--" "--markdown-css" "rust.css" "--markdown-no-toc" "--generate-redirect-pages" "--resource-suffix" "1.42.0" "--index-page" "/checkout/src/doc/index.md"
2019-12-21T00:57:35.1742094Z 
2019-12-21T00:57:35.1742229Z 
2019-12-21T00:57:35.1752595Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-12-21T00:57:35.1752980Z Build completed unsuccessfully in 1:43:02
2019-12-21T00:57:35.1752980Z Build completed unsuccessfully in 1:43:02
2019-12-21T00:57:35.1811551Z == clock drift check ==
2019-12-21T00:57:35.1830331Z   local time: Sat Dec 21 00:57:35 UTC 2019
2019-12-21T00:57:35.4701859Z   network time: Sat, 21 Dec 2019 00:57:35 GMT
2019-12-21T00:57:35.4702142Z == end clock drift check ==
2019-12-21T00:57:37.6551786Z 
2019-12-21T00:57:37.6650915Z ##[error]Bash exited with code '1'.
2019-12-21T00:57:37.6684004Z ##[section]Starting: Checkout
2019-12-21T00:57:37.6685917Z ==============================================================================
2019-12-21T00:57:37.6685984Z Task         : Get sources
2019-12-21T00:57:37.6686025Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril

This comment was marked as resolved.

Copy link
Member

Centril commented Dec 21, 2019

@bors r- ^--

@oli-obk

This comment has been minimized.

Copy link
Contributor Author

oli-obk commented Dec 23, 2019

@bors r=Centril

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 23, 2019

📌 Commit 63d2822 has been approved by Centril

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 23, 2019

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

Centril added a commit to Centril/rust that referenced this pull request Dec 23, 2019
Require const stability attributes on intrinsics to be able to use them in constant contexts

r? @Centril

finally fixes rust-lang#61495

cc @RalfJung
bors added a commit that referenced this pull request Dec 23, 2019
Rollup of 8 pull requests

Successful merges:

 - #67233 (Add PartialEq and Eq to Cursor)
 - #67466 (Require const stability attributes on intrinsics to be able to use them in constant contexts)
 - #67507 (Remove mem::uninitalized from tests)
 - #67527 (Results show too much)
 - #67536 (Move `{hir::lowering -> hir}::is_range_literal`)
 - #67538 (Improve diagnostics for invalid assignment)
 - #67546 (Fix ICE in mir interpretation)
 - #67559 (Document that calling Drop, even after it panics, is UB)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Dec 23, 2019
Rollup of 8 pull requests

Successful merges:

 - #67233 (Add PartialEq and Eq to Cursor)
 - #67466 (Require const stability attributes on intrinsics to be able to use them in constant contexts)
 - #67507 (Remove mem::uninitalized from tests)
 - #67527 (Results show too much)
 - #67536 (Move `{hir::lowering -> hir}::is_range_literal`)
 - #67538 (Improve diagnostics for invalid assignment)
 - #67546 (Fix ICE in mir interpretation)
 - #67559 (Document that calling Drop, even after it panics, is UB)

Failed merges:

r? @ghost
@bors bors merged commit 63d2822 into rust-lang:master Dec 23, 2019
4 checks passed
4 checks passed
pr Build #20191223.62 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@Centril

This comment has been minimized.

Copy link
Member

Centril commented Dec 23, 2019

@oli-obk Could you follow up with some adjustments to https://rust-lang.github.io/rustc-guide/stability.html ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.