Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset Formatter flags on exit from pad_integral #67784

Merged
merged 1 commit into from Jan 15, 2020

Commits on Jan 1, 2020

  1. Reset Formatter flags on exit from pad_integral

    This fixes a bug where after calling pad_integral with appropriate flags, the
    fill and alignment flags would be set to '0' and 'Right' and left as such even
    after exiting pad_integral, which meant that future calls on the same Formatter
    would get incorrect flags reported.
    
    This is quite difficult to observe in practice, as almost all formatting
    implementations in practice don't call `Display::fmt` directly, but rather use
    `write!` or a similar macro, which means that they cannot observe the effects of
    the wrong flags (as `write!` creates a fresh Formatter instance). However, we
    include a test case.
    Mark-Simulacrum committed Jan 1, 2020
    Copy the full SHA
    73996df View commit details
    Browse the repository at this point in the history