Update LLVM to fix crash on Emscripten targets #67976
Conversation
Pulls in a bug fix from upstream to resolve rust-lang#66308. Also adds a small Rust regression test. r? @alexcrichton
|
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ |
|
📌 Commit 914befe has been approved by |
bors
added
S-waiting-on-bors
|
FWIW, #68030 is rebasing to a new branch for LLVM 9.0.1, but I did include your backport. |
|
@bors rollup=never |
|
⌛ Testing commit 914befe with merge 40e44026d396ad251e58e51891e1bb51137db51b... |
|
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
|
☔ The latest upstream changes (presumably #68030) made this pull request unmergeable. Please resolve the merge conflicts. |
|
The patch has been picked up as part of #68030, so this can be reduced to just the test case. |
|
Given that there are already regression tests for this bug in LLVM, I don't feel the Rust test is too important to have. I'll just close this PR. |
|
@alexcrichton I've pushed the new fix to the same branch, so we can either reopen this PR (and go straight to the head of the bors queue) or I can make a new PR. Which would you prefer? |
|
I'm fine with either! The reopen button is grayed out for me though, so maybe a new PR for technical issues? |
Pulls in a bug fix from upstream to resolve #66308. Also adds a small
Rust regression test.
r? @alexcrichton