Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use the word "unwrap" to describe "unwrap" methods #68918

Merged
merged 3 commits into from
Feb 9, 2020
Merged

Don't use the word "unwrap" to describe "unwrap" methods #68918

merged 3 commits into from
Feb 9, 2020

Commits on Feb 5, 2020

  1. Reorder declarations of Result::export/unwrap to match Option

    @brson
    brson committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    c00d8aa View commit details
    Browse the repository at this point in the history

  2. Reorder declarations of Result::expect_err/unwrap_err to match Option

    @brson
    brson committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    db9b578 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2020

  1. Don't use the word 'unwrap' to describe core unwrapping functions 

    It's tautological, and Rust-specific Jargon.

This changes various Option/Result methods to consistently describe unwrapping
behavior using the words "return", "contain", "consume".

It also renames the closure argument of `Return::unwrap_or_else` to `default` to
be consistent with `Option`.
    @brson
    brson committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    8251e12 View commit details
    Browse the repository at this point in the history