Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine HaveBeenBorrowedLocals and IndirectlyMutableLocals into one dataflow analysis #69113

Merged
merged 12 commits into from
Feb 19, 2020
Merged

Combine HaveBeenBorrowedLocals and IndirectlyMutableLocals into one dataflow analysis #69113

merged 12 commits into from
Feb 19, 2020

Commits on Feb 12, 2020

  1. Impl GenKill for old dataflow framework's GenKillSet 

    This impl is temporary and will be removed along with the old dataflow
framework. It allows us to reuse the transfer function of new dataflow
analyses when defining old ones
    @ecstatic-morse
    ecstatic-morse committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    fc5c295 View commit details
    Browse the repository at this point in the history

  2. Implement Maybe{Mut,}BorrowedLocals analyses

    @ecstatic-morse
    ecstatic-morse committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    7d9dadc View commit details
    Browse the repository at this point in the history

  3. Remove outdated IndirectlyMutableLocals 

    `MaybeMutBorrowedLocals` serves the same purpose and has a better name.
    @ecstatic-morse
    ecstatic-morse committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    34783b7 View commit details
    Browse the repository at this point in the history

  4. Reenable peek test for indirect mutation analysis 

    This uses the new `MaybeMutBorrowedLocals` pass but we keep the
`rustc_peek_indirectly_mutable` since the two are interchangable except
when inspecting a local after it has been marked `StorageDead`.
    @ecstatic-morse
    ecstatic-morse committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    9972502 View commit details
    Browse the repository at this point in the history

  5. Use MaybeBorrowedLocals for generator analyses 

    It should have the same semantics as `HaveBeenBorrowedLocals`
    @ecstatic-morse
    ecstatic-morse committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    1d737fb View commit details
    Browse the repository at this point in the history

  6. Use MaybeMutBorrowedLocals for const-checking

    @ecstatic-morse
    ecstatic-morse committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    d045a17 View commit details
    Browse the repository at this point in the history

  7. Remove ignore and add explanation of indirect mutation peek test

    @ecstatic-morse
    ecstatic-morse committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    6f167e9 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2020

  1. Rename MaybeBorrowedLocals constructors

    @ecstatic-morse
    ecstatic-morse committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    15a5382 View commit details
    Browse the repository at this point in the history

  2. Ignore mut borrow from drop terminator in const-eval

    @ecstatic-morse
    ecstatic-morse committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    0984639 View commit details
    Browse the repository at this point in the history

  3. Update line # in test output

    @ecstatic-morse
    ecstatic-morse committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    668d2fe View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2020

  1. Use doc comment for explanation of shared_borrow_allows_mutation

    @ecstatic-morse
    ecstatic-morse committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    9d42395 View commit details
    Browse the repository at this point in the history

  2. Fix typo in comment

    @ecstatic-morse
    ecstatic-morse committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    077a93c View commit details
    Browse the repository at this point in the history