Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute the correct layout for variants of uninhabited enums #69767

Closed
wants to merge 1 commit into from
Closed

Compute the correct layout for variants of uninhabited enums #69767

wants to merge 1 commit into from

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Mar 6, 2020 •
edited
Loading

r? @eddyb
cc @RalfJung

fixes #69191
fixes #69763

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 6, 2020
eddyb
eddyb requested changes Mar 6, 2020
View reviewed changes
Copy link
Member

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the correct approach IMO, see #69763 (comment).

@oli-obk oli-obk closed this Mar 6, 2020
@oli-obk oli-obk changed the title Non-empty enums need to produce a layout with variants Compute the correct layout for variants of uninhabited enums Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyb eddyb eddyb requested changes

Assignees

@eddyb eddyb

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Layout and MIR field accesses are incoherent beta regression: ICE on Tried to access field 0 of union Layout
3 participants
@oli-obk @eddyb @rust-highfive