Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #70024

Merged
merged 18 commits into from
Mar 15, 2020
Merged

Rollup of 8 pull requests #70024

merged 18 commits into from
Mar 15, 2020

Commits on Mar 3, 2020

  1. Configuration menu
    Copy the full SHA
    2a29726 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. Add unborrow to reset RefCell borrow state

    This method is complementary for the feature refcell_leak added in an
    earlier PR. It allows reverting the effects of leaking a borrow guard by
    statically proving that such a guard could not longer exist. This was
    not added to the existing `get_mut` out of concern of impacting the
    complexity of the otherwise pure pointer cast and because the name
    `get_mut` poorly communicates the intent of resetting remaining borrows.
    HeroicKatora committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    51b9396 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2020

  1. Add stable feature name

    lopopolo committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    18feaa3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    533784d View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2020

  1. Configuration menu
    Copy the full SHA
    e809e02 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2020

  1. rustc_metadata: Remove rmeta::MacroDef

    Use `ast::MacroDef` instead.
    
    Also remove `Session::imported_macro_spans`, external macros have spans now.
    petrochenkov committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    01a0c6d View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2020

  1. Configuration menu
    Copy the full SHA
    d7e6649 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2020

  1. Configuration menu
    Copy the full SHA
    2093d83 View commit details
    Browse the repository at this point in the history
  2. Fix "since" field for Once::is_complete's #[stable] attribute

    It was accidentally merged with the wrong version.
    LukasKalbertodt committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    401a3f3 View commit details
    Browse the repository at this point in the history
  3. resolve: Prevent fresh bindings from shadowing ambiguity items

    Correctly treat const generic parameters in fresh binding disambiguation
    petrochenkov committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    78f01ec View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#69528 - HeroicKatora:finalize-ref-cell, r=d…

    …tolnay
    
    Add undo_leak to reset RefCell borrow state
    
    This method is complementary for the feature cell_leak added in an
    earlier PR. It allows *safely* reverting the effects of leaking a borrow guard by
    statically proving that such a guard could not longer exist. This was
    not added to the existing `get_mut` out of concern of impacting the
    complexity of the otherwise pure pointer cast and because the name
    `get_mut` poorly communicates the intent of resetting remaining borrows.
    
    This is a follow-up to rust-lang#68712 and uses the same tracking issue, rust-lang#69099,
    as these methods deal with the same mechanism and the idea came up
    [in a review comment](rust-lang#68712 (comment)).
    
    @dtolnay who reviewed the prior PR.
    cc @RalfJung
    Centril committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    83aad6b View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#69589 - petrochenkov:maccall, r=Centril

    ast: `Mac`/`Macro` -> `MacCall`
    
    It's now obvious that these refer to macro calls rather than to macro definitions.
    
    It's also a single name instead of two different names in different places.
    
    `rustc_expand` usually calls macro calls in a wide sense (including attributes and derives) "macro invocations", but structures and variants renamed in this PR are only relevant to fn-like macros, so it's simpler and clearer to just call them calls.
    
    cc rust-lang#63586 (comment)
    r? @eddyb
    Centril committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    d1e943f View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#69661 - lopopolo:string-from-mut-str, r=sfa…

    …ckler
    
    Implement From<&mut str> for String
    
    I ran into this missing impl when trying to do `String::from` on the result returned from this API in the `uuid` crate:
    
    https://docs.rs/uuid/0.8.1/uuid/adapter/struct.Hyphenated.html#method.encode_lower
    
    I wasn't sure what to put in the stability annotation. I'd appreciate some help with that :)
    Centril committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    cc16232 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#69988 - petrochenkov:nomacrodef, r=Centril

    rustc_metadata: Remove `rmeta::MacroDef`
    
    And other related cleanups.
    
    Follow-up to rust-lang#66364.
    r? @Centril
    Centril committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    8bca839 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#70006 - petrochenkov:fresh, r=Centril

    resolve: Fix two issues in fresh binding disambiguation
    
    Prevent fresh bindings from shadowing ambiguity items.
    Fixes rust-lang#46079
    
    Correctly treat const generic parameters in fresh binding disambiguation.
    Fixes rust-lang#68853
    Centril committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    d986a70 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#70011 - petrochenkov:asyncice, r=Centril

    def_collector: Fully visit async functions
    
    We forgot to visit attributes previously, it caused ICEs.
    
    Special treatment of async functions is also moved from `visit_item` to `visit_fn` to reuse more of the default visitor.
    
    Fixes rust-lang#67778.
    Centril committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    d74c5cd View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#70013 - ecstatic-morse:check-consts-feature…

    …-gate, r=oli-obk
    
    Return feature gate as a `Symbol`
    
    A minor refactoring that will be needed for rust-lang#68940. That PR is blocked on me changing the error comments in a whole lot of UI tests.
    
    r? @oli-obk
    Centril committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    b46ef3d View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#70018 - LukasKalbertodt:fix-once-is-complet…

    …e-since, r=Centril
    
    Fix "since" field for `Once::is_complete`'s `#[stable]` attribute
    
    It was accidentally merged with the wrong version in rust-lang#68945.  Thanks @jplatte for noticing.
    
    This also needs to be beta backported.
    Centril committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    bde77af View commit details
    Browse the repository at this point in the history