Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move arg/constraint partition check to validation & improve recovery #70261

Merged
merged 7 commits into from
Mar 28, 2020
Merged

Move arg/constraint partition check to validation & improve recovery #70261

merged 7 commits into from
Mar 28, 2020

Commits on Mar 27, 2020

  1. parse: move constraint/arg restriction to ast_validation.

    @Centril
    Centril committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    91194f7 View commit details
    Browse the repository at this point in the history

  2. split parse_angle_args into loop / single step

    @Centril
    Centril committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    abce488 View commit details
    Browse the repository at this point in the history

  3. parse_angle_arg: parse constraints first

    @Centril
    Centril committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    aa4999e View commit details
    Browse the repository at this point in the history

  4. extract parse_generic_arg

    @Centril
    Centril committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    f91de44 View commit details
    Browse the repository at this point in the history

  5. parse: improve recovery for assoc eq constraints.

    @Centril
    Centril committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    2972bb3 View commit details
    Browse the repository at this point in the history

  6. address some review comments

    @Centril
    Centril committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    2ddc359 View commit details
    Browse the repository at this point in the history

  7. add the label back but make it shorter

    @Centril
    Centril committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    42c5cfd View commit details
    Browse the repository at this point in the history