Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

must_use on split_off #70359

Merged
merged 1 commit into from
Mar 24, 2020
Merged

must_use on split_off #70359

merged 1 commit into from
Mar 24, 2020

Conversation

kornelski
Copy link
Contributor

A couple more for #70194

@rust-highfive
Copy link
Collaborator

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 24, 2020
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2020-03-24T15:03:37.7420265Z ========================== Starting Command Output ===========================
2020-03-24T15:03:37.7430395Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/f022f18a-1093-43c5-9a3c-43edd2cdea02.sh
2020-03-24T15:03:37.7430675Z 
2020-03-24T15:03:37.7434155Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-24T15:03:37.7451391Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70359/merge to s
2020-03-24T15:03:37.7454419Z Task         : Get sources
2020-03-24T15:03:37.7454723Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-24T15:03:37.7455003Z Version      : 1.0.0
2020-03-24T15:03:37.7455191Z Author       : Microsoft
---
2020-03-24T15:03:39.0686922Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-24T15:03:39.0693690Z ##[command]git config gc.auto 0
2020-03-24T15:03:39.0696699Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-24T15:03:39.0699121Z ##[command]git config --get-all http.proxy
2020-03-24T15:03:39.0704108Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/70359/merge:refs/remotes/pull/70359/merge
---
2020-03-24T15:09:58.0987212Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-03-24T15:10:05.5962731Z    Compiling rustc_session v0.0.0 (/checkout/src/librustc_session)
2020-03-24T15:10:10.3826617Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-03-24T15:10:19.5479045Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-03-24T15:10:21.6457572Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-03-24T15:10:22.6979775Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-03-24T15:10:47.8617877Z    Compiling rustc_ast_passes v0.0.0 (/checkout/src/librustc_ast_passes)
2020-03-24T15:10:54.1826267Z    Compiling rustc_expand v0.0.0 (/checkout/src/librustc_expand)
2020-03-24T15:11:31.4127071Z    Compiling rustc_builtin_macros v0.0.0 (/checkout/src/librustc_builtin_macros)
---
2020-03-24T15:26:49.5462008Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-03-24T15:26:50.4344929Z    Compiling rustc_session v0.0.0 (/checkout/src/librustc_session)
2020-03-24T15:26:58.7641059Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-03-24T15:27:07.7274852Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-03-24T15:27:11.8217986Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-03-24T15:27:12.9935074Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-03-24T15:27:46.2460417Z    Compiling rustc_ast_passes v0.0.0 (/checkout/src/librustc_ast_passes)
2020-03-24T15:27:53.8499930Z    Compiling rustc_expand v0.0.0 (/checkout/src/librustc_expand)
2020-03-24T15:28:42.5461866Z    Compiling rustc_builtin_macros v0.0.0 (/checkout/src/librustc_builtin_macros)
---
2020-03-24T15:46:18.9501409Z .................................................................................................... 1700/9832
2020-03-24T15:46:22.0366664Z .................................................................................................... 1800/9832
2020-03-24T15:46:29.6505130Z .......................................................................................i............ 1900/9832
2020-03-24T15:46:34.9039450Z .................................................................................................... 2000/9832
2020-03-24T15:46:39.6001484Z .............................................................................iiiii.................. 2100/9832
2020-03-24T15:46:55.4200011Z .................................................................................................... 2300/9832
2020-03-24T15:46:57.0935366Z .................................................................................................... 2400/9832
2020-03-24T15:46:58.9092542Z .................................................................................................... 2500/9832
2020-03-24T15:47:05.8528907Z .................................................................................................... 2600/9832
---
2020-03-24T15:49:21.1611666Z ....................................................i...............i............................... 5000/9832
2020-03-24T15:49:27.2007027Z .................................................................................................... 5100/9832
2020-03-24T15:49:32.8880251Z .................................................................................................i.. 5200/9832
2020-03-24T15:49:36.8863904Z .................................................................................................... 5300/9832
2020-03-24T15:49:45.2863474Z ................................................................................ii.ii........i...i.. 5400/9832
2020-03-24T15:49:51.3153909Z ....................i............................................................................... 5600/9832
2020-03-24T15:49:57.4344139Z .........................i.......................................................................... 5700/9832
2020-03-24T15:50:03.9587147Z ..........................................ii....................................i................... 5800/9832
2020-03-24T15:50:09.9460494Z .................................................................................................... 5900/9832
2020-03-24T15:50:09.9460494Z .................................................................................................... 5900/9832
2020-03-24T15:50:14.3691212Z .................................................................................................... 6000/9832
2020-03-24T15:50:21.8337944Z ..........................................................................ii...i..ii...........i.... 6100/9832
2020-03-24T15:50:37.9590532Z .................................................................................................... 6300/9832
2020-03-24T15:50:40.7561119Z .................................................................................................... 6400/9832
2020-03-24T15:50:43.5614448Z .................................................................................................... 6500/9832
2020-03-24T15:50:43.5614448Z .................................................................................................... 6500/9832
2020-03-24T15:50:53.1498355Z ....i..ii........................................................................................... 6600/9832
2020-03-24T15:51:08.4653740Z .................................................................................................... 6800/9832
2020-03-24T15:51:10.1330042Z ...i................................................................................................ 6900/9832
2020-03-24T15:51:11.7600268Z .................................................................................................... 7000/9832
2020-03-24T15:51:13.6095184Z ......................................i............................................................. 7100/9832
---
2020-03-24T15:52:28.5888066Z .................................................................................................... 7800/9832
2020-03-24T15:52:32.3743836Z .................................................................................................... 7900/9832
2020-03-24T15:52:37.5285498Z ..............................................................................................i..... 8000/9832
2020-03-24T15:52:43.6368232Z .................................................................................................... 8100/9832
2020-03-24T15:52:49.1602135Z ...........................................iiiiiiiiii.i............................................. 8200/9832
2020-03-24T15:52:59.7809349Z .................................................................................................... 8400/9832
2020-03-24T15:53:03.6943057Z .................................................................................................... 8500/9832
2020-03-24T15:53:13.9757525Z .................................................................................................... 8600/9832
2020-03-24T15:53:20.6565924Z .................................................................................................... 8700/9832
---
2020-03-24T15:55:07.3393336Z Suite("src/test/codegen") not skipped for "bootstrap::test::Codegen" -- not in ["src/tools/tidy"]
2020-03-24T15:55:07.3548086Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-24T15:55:07.5195092Z 
2020-03-24T15:55:07.5195312Z running 183 tests
2020-03-24T15:55:09.9690761Z iiii......i............ii.i..iiii....i....i...........i............i..i..................i....i..... 100/183
2020-03-24T15:55:12.0727356Z .......i.i.i...iii..iiiiiiiiiiiiiiii.......................iii.............ii......
2020-03-24T15:55:12.0734168Z 
2020-03-24T15:55:12.0738581Z  finished in 4.719
2020-03-24T15:55:12.0742609Z Suite("src/test/codegen-units") not skipped for "bootstrap::test::CodegenUnits" -- not in ["src/tools/tidy"]
2020-03-24T15:55:12.0913154Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-03-24T15:55:14.0755455Z Suite("src/test/assembly") not skipped for "bootstrap::test::Assembly" -- not in ["src/tools/tidy"]
2020-03-24T15:55:14.0936593Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-24T15:55:14.2208585Z 
2020-03-24T15:55:14.2208867Z running 9 tests
2020-03-24T15:55:14.2209983Z iiiiiiiii
2020-03-24T15:55:14.2211126Z 
2020-03-24T15:55:14.2211323Z  finished in 0.128
2020-03-24T15:55:14.2218631Z Suite("src/test/incremental") not skipped for "bootstrap::test::Incremental" -- not in ["src/tools/tidy"]
2020-03-24T15:55:14.2373652Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-03-24T15:55:32.1690759Z Suite("src/test/debuginfo") not skipped for "bootstrap::test::Debuginfo" -- not in ["src/tools/tidy"]
2020-03-24T15:55:32.1896920Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-24T15:55:32.9569381Z 
2020-03-24T15:55:32.9615295Z running 115 tests
2020-03-24T15:55:43.5128397Z iiiii..i......i.i...i..i.i.i..i..i..ii....i.i....ii..........iiii.........i.....i..i.......ii.i.ii.. 100/115
2020-03-24T15:55:44.9984155Z ...iiii.....ii.
2020-03-24T15:55:44.9985275Z 
2020-03-24T15:55:44.9991813Z  finished in 12.809
2020-03-24T15:55:44.9998541Z Suite("src/test/ui-fulldeps") not skipped for "bootstrap::test::UiFullDeps" -- not in ["src/tools/tidy"]
2020-03-24T15:55:45.0000036Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-03-24T16:02:57.4143088Z    Compiling alloc v0.0.0 (/checkout/src/liballoc)
2020-03-24T16:03:04.5169288Z error: unused return value of `std::string::String::split_off` that must be used
2020-03-24T16:03:04.5169875Z    --> src/liballoc/../liballoc/tests/string.rs:269:5
2020-03-24T16:03:04.5170240Z     |
2020-03-24T16:03:04.5170660Z 269 |     split.split_off(orig.len() + 1);
2020-03-24T16:03:04.5171526Z     |
2020-03-24T16:03:04.5171969Z     = note: `-D unused-must-use` implied by `-D warnings`
2020-03-24T16:03:04.5172507Z     = note: use `.truncate()` if you don't need the other half
2020-03-24T16:03:04.5172725Z 
2020-03-24T16:03:04.5172725Z 
2020-03-24T16:03:04.5179465Z error: unused return value of `std::string::String::split_off` that must be used
2020-03-24T16:03:04.5180082Z    --> src/liballoc/../liballoc/tests/string.rs:276:5
2020-03-24T16:03:04.5180498Z     |
2020-03-24T16:03:04.5180954Z 276 |     orig.split_off(1);
2020-03-24T16:03:04.5182138Z     |
2020-03-24T16:03:04.5182663Z     = note: use `.truncate()` if you don't need the other half
2020-03-24T16:03:04.5182917Z 
2020-03-24T16:03:04.6617658Z error: aborting due to 2 previous errors
---
2020-03-24T16:03:05.9499560Z   local time: Tue Mar 24 16:03:05 UTC 2020
2020-03-24T16:03:06.2234345Z   network time: Tue, 24 Mar 2020 16:03:06 GMT
2020-03-24T16:03:06.2240056Z == end clock drift check ==
2020-03-24T16:03:07.1581960Z 
2020-03-24T16:03:07.1634716Z ##[error]Bash exited with code '1'.
2020-03-24T16:03:07.1645181Z ##[section]Finishing: Run build
2020-03-24T16:03:07.1686595Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70359/merge to s
2020-03-24T16:03:07.1690400Z Task         : Get sources
2020-03-24T16:03:07.1690639Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-24T16:03:07.1690855Z Version      : 1.0.0
2020-03-24T16:03:07.1691021Z Author       : Microsoft
2020-03-24T16:03:07.1691021Z Author       : Microsoft
2020-03-24T16:03:07.1691261Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-24T16:03:07.1691536Z ==============================================================================
2020-03-24T16:03:07.4399091Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-24T16:03:07.4442524Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/70359/merge to s
2020-03-24T16:03:07.4506869Z Cleaning up task key
2020-03-24T16:03:07.4507821Z Start cleaning up orphan processes.
2020-03-24T16:03:07.4642854Z Terminate orphan process: pid (3439) (python)
2020-03-24T16:03:07.4799927Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 24, 2020

📌 Commit 42b10e5 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2020
@Centril Centril mentioned this pull request Mar 24, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 24, 2020
@bors
Auto merge of rust-lang#70371 - Centril:rollup-ywi1vo3, r=Centril
02046a5 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#70023 (clean up E0436 explanation)
 - rust-lang#70234 (#[track_caller] on core::ops::{Index, IndexMut}.)
 - rust-lang#70241 (Miri: move ModifiedStatic to ConstEval errors)
 - rust-lang#70342 (IoSlice/IoSliceMut should be Send and Sync)
 - rust-lang#70350 (Request "-Z unstable-options" for unstable options)
 - rust-lang#70355 (Clean up E0454)
 - rust-lang#70359 (must_use on split_off)
 - rust-lang#70368 (Mark hotplug_codegen_backend as ignore-stage1)

Failed merges:

r? @ghost
@bors bors merged commit db2c70b into rust-lang:master Mar 24, 2020
@kornelski kornelski deleted the mustsplit branch March 25, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sfackler sfackler

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kornelski @rust-highfive @Dylan-DPC-zz @bors @sfackler