Add ThreadSanitizer test case #70938
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
tmiasko
force-pushed
the
thread-test-case
branch
from
4d124a0
to
026c3a9
Compare
|
r? @Centril |
tmiasko
force-pushed
the
thread-test-case
branch
from
026c3a9
to
40a04c0
Compare
|
I don't feel qualified to review this. r? @hanna-kruppe @alexcrichton perhaps |
|
I am not familiar with the TSAN APIs used here or the test harness features this test relies on, but the reasoning in the comment seems good to me and the test code itself also looks good at a glance. Is this test exercised by any of our builders? If so, is it among the checks that run on every PR or only run by bors? |
tmiasko
force-pushed
the
thread-test-case
branch
from
40a04c0
to
688697d
Compare
|
They run on Linux x86_64-gnu and macOS x86_64-apple (not in any of PR runners, AFAIR). Which reminds me that this should be fine to run on macOS and I adjusted the test accordingly. |
|
Alright, then I'll approve this now, otherwise I would have waited for the PR builders going green. @bors r+ |
|
📌 Commit 688697d has been approved by |
bors
added
S-waiting-on-bors
Not a problem, as it will take some time before this gets rolled up, and the try-CI will finish before that |
Rollup of 9 pull requests Successful merges: - rust-lang#69745 (Use `PredicateObligation`s instead of `Predicate`s) - rust-lang#70938 (Add ThreadSanitizer test case) - rust-lang#70973 (Use forward traversal for unconditional recursion lint) - rust-lang#70978 (compiletest: let config flags overwrite -A unused) - rust-lang#70979 (Follow up on BTreeMap comments) - rust-lang#70981 (Rearrange BTreeMap::into_iter to match range_mut.) - rust-lang#70985 (Clean up E0512 explanation) - rust-lang#70988 (Setup the `@rustbot prioritize` command) - rust-lang#70991 (fix rustc-dev-guide's url in src/librustc_codegen_ssa) Failed merges: r? @ghost
No description provided.