Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dogfood or_patterns in the standard library #71220

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Dogfood or_patterns in the standard library #71220

merged 1 commit into from
Apr 17, 2020

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Apr 16, 2020

We can start using or_patterns in the standard library as a step toward stabilization.

cc #54883 @Centril

@rust-highfive
Copy link
Collaborator

r? @withoutboats

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2020
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

Seems reasonable.

@bors
Copy link
Contributor

bors commented Apr 16, 2020

📌 Commit 2edd123 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 17, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2020
@bors
Auto merge of rust-lang#71230 - Dylan-DPC:rollup-rofigbv, r=Dylan-DPC
861996e 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#70578 (Add long error explanation for E0657)
 - rust-lang#70910 (Hides default fns inside Fuse impl to avoid exposing it to any crate)
 - rust-lang#71164 (reword Miri validity errors: undefined -> uninitialized)
 - rust-lang#71182 (Add some regression tests)
 - rust-lang#71206 (Miri error messages: avoid try terminology)
 - rust-lang#71220 (Dogfood or_patterns in the standard library)
 - rust-lang#71225 (Fix typo in Default trait docs: Provides -> Provide)

Failed merges:

r? @ghost
@bors bors merged commit 28964b4 into rust-lang:master Apr 17, 2020
@cuviper cuviper deleted the std_or_patterns branch May 30, 2020 21:55
@Centril Centril mentioned this pull request Jun 30, 2020
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@withoutboats withoutboats

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cuviper @rust-highfive @Mark-Simulacrum @bors @withoutboats