Use min_specialization in liballoc #71321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewjasper
force-pushed
the
alloc-min-spec
branch
from
0fbe5c2
to
52faacf
Compare
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
sfackler
reviewed
Apr 19, 2020
| @@ -215,59 +215,6 @@ impl<K: Clone, V: Clone> Clone for BTreeMap<K, V> { | |||
| clone_subtree(self.root.as_ref().unwrap().as_ref()) | |||
| } | |||
| } | |||
|
|
|||
| fn clone_from(&mut self, other: &Self) { | |||
RalfJung
reviewed
Apr 19, 2020
Comment on lines
+366
to
+368
| // FIXME(matthewjasper) This allows copying a type that doesn't implement | ||
| // `Copy` because of unsatisfied lifetime bounds (copying `A<'_>` when only | ||
| // `A<'static>: Copy` and `A<'_>: Clone`). |
There was a problem hiding this comment.
Does this apply only to specialization or to all uses of Copy? I'm surprised there is no test that makes sure we fail to copy something when the Copy impl is lifetime-dependent.
There was a problem hiding this comment.
It's only for specializations.
8 tasks
matthewjasper
force-pushed
the
alloc-min-spec
branch
from
52faacf
to
7476600
Compare
|
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
- Remove a type parameter from `[A]RcFromIter`. - Remove an implementation of `[A]RcFromIter` that didn't actually specialize anything. - Remove unused implementation of `IsZero` for `Option<&mut T>`. - Change specializations of `[A]RcEqIdent` to use a marker trait version of `Eq`. - Remove `BTreeClone`. I couldn't find a way to make this work with `min_specialization`. - Add `rustc_unsafe_specialization_marker` to `Copy` and `TrustedLen`.
matthewjasper
force-pushed
the
alloc-min-spec
branch
from
7476600
to
cb27039
Compare
joelpalmer
added
S-waiting-on-review
joelpalmer
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit cb27039 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit cb27039 with merge adbeb04256d09dbc524d24e4922f9b330e35bab0... |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
May 14, 2020
…ckler Use min_specialization in liballoc - Remove a type parameter from `[A]RcFromIter`. - Remove an implementation of `[A]RcFromIter` that didn't actually specialize anything. - Remove unused implementation of `IsZero` for `Option<&mut T>`. - Change specializations of `[A]RcEqIdent` to use a marker trait version of `Eq`. - Remove `BTreeClone`. I couldn't find a way to make this work with `min_specialization`. - Add `rustc_unsafe_specialization_marker` to `Copy` and `TrustedLen`. After this only libcore is the only standard library crate using `feature(specialization)`. cc rust-lang#31844
|
@bors retry yield |
|
@Dylan-DPC did we race? I just created a rollup, hopefully we didn't both do that? |
|
⌛ Testing commit cb27039 with merge b9badca586f6cf1d3b2b58756f994f3b4606fcc4... |
|
@bors retry yield |
|
⌛ Testing commit cb27039 with merge 9a09b0537fb8a2ef090efda2d519777bff9dc879... |
|
@bors retry yield |
|
☀️ Test successful - checks-azure |
|
This was a perf regression for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[A]RcFromIter.[A]RcFromIterthat didn't actuallyspecialize anything.
IsZeroforOption<&mut T>.[A]RcEqIdentto use a marker trait versionof
Eq.BTreeClone. I couldn't find a way to make this work withmin_specialization.rustc_unsafe_specialization_markertoCopyandTrustedLen.After this only libcore is the only standard library crate using
feature(specialization).cc #31844