Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve substitutions when making trait obligations for suggestions #71618

Merged
merged 7 commits into from
May 24, 2020
Merged

Preserve substitutions when making trait obligations for suggestions #71618

merged 7 commits into from
May 24, 2020

Commits on May 22, 2020

  1. Preserve substitutions when trying to prove trait obligation 

    `mk_obligation_for_def_id` is only correct if the trait and self type do
not have any substitutions. Use a different method,
`mk_trait_obligation_with_new_self_ty` that is more clear about what is
happening.
    @ecstatic-morse
    ecstatic-morse committed May 22, 2020
    Configuration menu
    Copy the full SHA
    730c6f3 View commit details
    Browse the repository at this point in the history

  2. Add regression test for rust-lang#71394

    @ecstatic-morse
    ecstatic-morse committed May 22, 2020
    Configuration menu
    Copy the full SHA
    8ea828b View commit details
    Browse the repository at this point in the history

  3. Bless other example of rust-lang#71394

    @ecstatic-morse
    ecstatic-morse committed May 22, 2020
    Configuration menu
    Copy the full SHA
    4d9e9c6 View commit details
    Browse the repository at this point in the history

  4. Ensure that new_self_ty has no escaping bound vars 

    Otherwise inserting it to the `Binder` used by `trait_ref` would cause
problems. This is just to be extra carefult: we aren't going to
start recommending that the user start using HKTs anytime soon.
    @ecstatic-morse
    ecstatic-morse committed May 22, 2020
    Configuration menu
    Copy the full SHA
    d2bacb1 View commit details
    Browse the repository at this point in the history

  5. Document invariants of mk_trait_obligation_with_new_self_ty

    @ecstatic-morse
    ecstatic-morse committed May 22, 2020
    Configuration menu
    Copy the full SHA
    7278e29 View commit details
    Browse the repository at this point in the history

  6. Bail out if output_ty has bound variables

    @ecstatic-morse
    ecstatic-morse committed May 22, 2020
    Configuration menu
    Copy the full SHA
    f99519b View commit details
    Browse the repository at this point in the history

  7. Use mk_trait_obligation_with_new_self_ty for new suggestion

    @ecstatic-morse
    ecstatic-morse committed May 22, 2020
    Configuration menu
    Copy the full SHA
    1fad3b7 View commit details
    Browse the repository at this point in the history