Add a warning about infinite reading in read_(until|line) #72888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
looks fine to me @bors r=Dylan-DPC |
|
📌 Commit d8cc2c1 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 2, 2020
Rollup of 4 pull requests Successful merges: - rust-lang#72884 (RawString error reporting cleanup ) - rust-lang#72888 (Add a warning about infinite reading in read_(until|line)) - rust-lang#72914 (Minor: off-by-one error in RELEASES.md) - rust-lang#72916 (Update README.md) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #48788.
This PR adds a warning to
BufRead::read_lineandBufRead::read_untilabout the possibility of an attack using the behaviour of these functions.I did not mention a possible fix (using
Read::take, should I ?