Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ship rust analyzer #72978

Merged
merged 1 commit into from
Jul 4, 2020
Merged

ship rust analyzer #72978

merged 1 commit into from
Jul 4, 2020

Commits on Jul 3, 2020

  1. Add rust-analyzer submodule

    The current plan is that submodule tracks the `release` branch of
    rust-analyzer, which is updated once a week.
    
    rust-analyzer is a workspace (with a virtual manifest), the actual
    binary is provide by `crates/rust-analyzer` package.
    
    Note that we intentionally don't add rust-analyzer to `Kind::Test`,
    for two reasons.
    
    *First*, at the moment rust-analyzer's test suite does a couple of
    things which might not work in the context of rust repository. For
    example, it shells out directly to `rustup` and `rustfmt`. So, making
    this work requires non-trivial efforts.
    
    *Second*, it seems unlikely that running tests in rust-lang/rust repo
    would provide any additional guarantees. rust-analyzer builds with
    stable and does not depend on the specifics of the compiler, so
    changes to compiler can't break ra, unless they break stability
    guarantee. Additionally, rust-analyzer itself is gated on bors, so we
    are pretty confident that test suite passes.
    matklad committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    058c1b6 View commit details
    Browse the repository at this point in the history