Use LocalDefId directly in Resolver::export_map
#73090
Merged
+27
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
petrochenkov
reviewed
Jun 7, 2020
petrochenkov
added
S-waiting-on-author
marmeladema
force-pushed
the
resolver-outputs-local-def-id
branch
from
53a9edc
to
c896765
Compare
marmeladema
commented
Jun 7, 2020
jyn514
reviewed
Jun 7, 2020
petrochenkov
reviewed
Jun 7, 2020
petrochenkov
reviewed
Jun 7, 2020
marmeladema
force-pushed
the
resolver-outputs-local-def-id
branch
from
c896765
to
ab18ce7
Compare
petrochenkov
reviewed
Jun 7, 2020
|
r=me after squashing commits |
…ts` query This is to avoid the final conversion from `NodeId` to `HirId` during call to `Resolver::(clone|into)_outputs`.
marmeladema
force-pushed
the
resolver-outputs-local-def-id
branch
from
ab18ce7
to
e759222
Compare
|
@petrochenkov squashed 👍 |
|
Thanks! |
|
📌 Commit e759222 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jun 7, 2020
…def-id, r=petrochenkov Use `LocalDefId` directly in `Resolver::export_map` This is to avoid the final conversion from `NodeId` to `HirId` during call to `(clone|into)_outputs` This brings down the post-lowering uses of `NodeId` down to 2 calls to convert the `trait_map`. cc rust-lang#50928 r? @petrochenkov
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 8, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#71842 (doc: make impl block collapsible if it has an associated constant) - rust-lang#72912 (Add new E0758 error code) - rust-lang#73008 (Update RELEASES.md) - rust-lang#73090 (Use `LocalDefId` directly in `Resolver::export_map`) - rust-lang#73118 (Improve the wording in documentation of std::mem::drop) - rust-lang#73124 (Removed lifetime parameters from Explanation of E0207 ) - rust-lang#73138 (Use shorthand linker strip arguments in order to support MacOS) - rust-lang#73143 (Update books) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid the final conversion from
NodeIdtoHirIdduring call to
(clone|into)_outputsThis brings down the post-lowering uses of
NodeIddown to 2 calls to convert thetrait_map.cc #50928
r? @petrochenkov