Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A way forward for pointer equality in const eval #73398

Merged
merged 7 commits into from
Jun 23, 2020
Merged

A way forward for pointer equality in const eval #73398

merged 7 commits into from
Jun 23, 2020

Commits on Jun 19, 2020

  1. Remove the const_raw_ptr_comparison feature gate. 

    We can never supply a meaningful implementation of this.
Instead, the follow up commits will create two intrinsics
that approximate comparisons:

* `ptr_maybe_eq`
* `ptr_maybe_ne`

The fact that `ptr_maybe_eq(a, b)` is not necessarily the same
value as `!ptr_maybe_ne(a, b)` is a symptom of this entire
problem.
    @oli-obk
    oli-obk committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    9245ba8 View commit details
    Browse the repository at this point in the history

  2. Add fuzzy pointer comparison intrinsics

    @oli-obk
    oli-obk committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    e09b620 View commit details
    Browse the repository at this point in the history

  3. Tidy got confused on rustc_const_unstable issues

    @oli-obk
    oli-obk committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    84f1d73 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2020

  1. Refer just to the issue in the raw ptr cmp diagnostic instead of expl… 

    …aining everything in the diagnostic
    @oli-obk
    oli-obk committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    9e88b48 View commit details
    Browse the repository at this point in the history

  2. Satisfy tidy

    @oli-obk
    oli-obk committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    53686b9 View commit details
    Browse the repository at this point in the history

  3. Address review comments

    @oli-obk
    oli-obk committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    98e97a4 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2020

  1. icmp can handle raw pointers just fine, there's no need to cast to … 

    …int.
    @oli-obk
    oli-obk committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    e465b22 View commit details
    Browse the repository at this point in the history