Account for multiple impl/dyn Trait in return type when suggesting '_
#73496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
estebank
commented
Jun 19, 2020
Comment on lines
+26
to
+45
| error[E0759]: cannot infer an appropriate lifetime | ||
| --> $DIR/trait-object-nested-in-impl-trait.rs:41:31 | ||
| | | ||
| LL | fn iter(&self) -> impl Iterator<Item = Box<dyn Foo>> + '_ { | ||
| | ----- this data with an anonymous lifetime `'_`... | ||
| ... | ||
| LL | remaining: self.0.iter(), | ||
| | ------ ^^^^ | ||
| | | | ||
| | ...is captured here... | ||
| | | ||
| note: ...and is required to live as long as `'static` here | ||
| --> $DIR/trait-object-nested-in-impl-trait.rs:38:23 | ||
| | | ||
| LL | fn iter(&self) -> impl Iterator<Item = Box<dyn Foo>> + '_ { | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| help: to declare that the trait object captures data from argument `self`, you can add an explicit `'_` lifetime bound | ||
| | | ||
| LL | fn iter(&self) -> impl Iterator<Item = Box<dyn Foo + '_>> + '_ { | ||
| | ^^^^ |
There was a problem hiding this comment.
This was the main case I wanted to tackle in this PR. Avoiding giving an incorrect suggestion for '_ which is already present, and identifying that there are other places where '_ might be needed, in this case dyn Foo + '_.
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
opaque-missing-lts-in-fn-3
branch
from
b483526
to
93770ff
Compare
estebank
force-pushed
the
opaque-missing-lts-in-fn-3
branch
from
93770ff
to
562f496
Compare
nikomatsakis
approved these changes
Jun 22, 2020
src/librustc_infer/infer/error_reporting/nice_region_error/named_anon_conflict.rs
Show resolved
Hide resolved
|
r=me after nits fixed |
|
@bors r=nikomatsakis |
|
📌 Commit 3eb8eb9 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 23, 2020
…arth Rollup of 9 pull requests Successful merges: - rust-lang#72271 (Improve compiler error message for wrong generic parameter order) - rust-lang#72493 ( move leak-check to during coherence, candidate eval) - rust-lang#73398 (A way forward for pointer equality in const eval) - rust-lang#73472 (Clean up E0689 explanation) - rust-lang#73496 (Account for multiple impl/dyn Trait in return type when suggesting `'_`) - rust-lang#73515 (Add second message for LiveDrop errors) - rust-lang#73567 (Clarify --extern documentation.) - rust-lang#73572 (Fix typos in doc comments) - rust-lang#73590 (bootstrap: no `config.toml` exists regression) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
implanddynTrait lifetime suggestions a bit more resilient.Follow up to #72804.
r? @nikomatsakis