Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 13 pull requests #73756

Merged
merged 28 commits into from
Jun 26, 2020
Merged

Rollup of 13 pull requests #73756

merged 28 commits into from
Jun 26, 2020

Commits on May 27, 2020

  1. Omit DW_AT_linkage_name when it is the same as DW_AT_name

    The DWARF standard suggests that it might be useful to include
    `DW_AT_linkage_name` when it is *distinct* from the identifier name.
    tmiasko committed May 27, 2020
    Configuration menu
    Copy the full SHA
    e4b7d2c View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. Configuration menu
    Copy the full SHA
    e85df08 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2020

  1. Configuration menu
    Copy the full SHA
    8a816ca View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2020

  1. Configuration menu
    Copy the full SHA
    8d0e882 View commit details
    Browse the repository at this point in the history
  2. Update asm! documentation

    Amanieu committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    a98868d View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2020

  1. Make AssocOp Copy

    flip1995 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    2792014 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. Record span of const kw in GenericParamKind

    Context: this is needed to fix rust-lang/rustfmt#4263,
    which currently records the span of a const generic param incorrectly
    because the location of the `const` kw is not known.
    
    I am not sure how to add tests for this; any guidance in how to do so
    would be appreciated 🙂
    ayazhafiz committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    86f6c0e View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2020

  1. Update Chalk

    jackh726 committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    ecb8b9f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2735f43 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. emitter: column width defaults to 140

    This commit modifies the column width computation in the emitter when
    `termize::dimensions` returns `None` so that it uses the default value
    of 140 (which is used in UI testing currently) instead of `usize::MAX`
    which just ends up causing overflows in later computations. This is hard
    to test but appears to produce the same output as using saturating
    functions instead.
    
    Signed-off-by: David Wood <david@davidtw.co>
    davidtwco committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    11a3584 View commit details
    Browse the repository at this point in the history
  2. disable collectionbenches for android

    Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
    nellshamrell committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    f13d89e View commit details
    Browse the repository at this point in the history
  3. add exception for liballoc benches to tidy

    Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
    nellshamrell committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    5c88b51 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    77b0ed7 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2020

  1. Configuration menu
    Copy the full SHA
    d279b3c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    75983e1 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#72620 - tmiasko:linkage-name, r=eddyb

    Omit DW_AT_linkage_name when it is the same as DW_AT_name
    
    The DWARF standard suggests that it might be useful to include
    `DW_AT_linkage_name` when it is *distinct* from the identifier name.
    
    Fixes rust-lang#46487.
    Fixes rust-lang#59422.
    Manishearth committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    14dc103 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#72967 - integer32llc:prevent-default-arrows…

    …, r=kinnison
    
    Don't move cursor in search box when using arrows to navigate results
    
    ## What happens
    
    - Go to https://doc.rust-lang.org/stable/std/index.html
    - Press 's' to focus the search box
    - Type a query like 'test'
    - Press the down arrow one or more times to change which search result is highlighted
    - Press the up arrow once to go up one search result
    - Notice the cursor in the search box is now at the beginning of your query, such that if you now typed 'a' the search box would contain 'atest', when it would be expected that the cursor would have remained where it was and if you typed 'a' at this point it would result in 'testa'
    - Press the down arrow once to go down one search result
    - Now notice the cursor is at the end of your query again
    
    ## What I expected
    
    I expected that changing which search result was highlighted using the up and down arrows would have no effect on where the cursor was in the search box.
    
    ## The fix
    
    This PR prevents the default action of the up and down arrows when the custom keydown events are happening during a search.
    Manishearth committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    a25fbb9 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#73102 - petrochenkov:flatgroup, r=Aaron1011

    proc_macro: Stop flattening groups with dummy spans
    
    Reduce the scope of the hack described in rust-lang#72545 (comment).
    
    We still pass AST fragments to attribute and derive macros as single nonterminal tokens rather than as tokens streams, but now use a precise flag instead of the span-based heuristic that could do lead to incorrect behavior in unrelated cases.
    
    rust-lang#73345 attempts to fully resolve this issue, but there are some compatibility issues to be addressed.
    Manishearth committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    2aee608 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#73297 - ehuss:tool-warnings, r=Mark-Simulacrum

    Support configurable deny-warnings for all in-tree crates.
    
    This removes the hard-coded `deny(warnings)` on all in-tree tools, and allows it to be configured from the config.  This is just a personal preference, as I find `deny(warnings)` frustrating during development or doing small tests.
    
    This also fixes some regressions in terms of warning handling.  Warnings used to be dependent on `SourceType`, but in rust-lang#64316 it was changed to be based on `Mode`. This means tools like rustdoc no longer used the same settings as the rest of the tree. It also made `SourceType` useless since the only thing it was used for was warnings. I think it would be better for everything in the tree to use the same settings.
    
    Fixes rust-lang#64523
    Manishearth committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    10d655b View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#73507 - mati865:cleanup-mingw-llvm-linkage,…

    … r=matthewjasper
    
    Cleanup MinGW LLVM linkage workaround
    
    LLVM correctly passes `uuid` for a long time, GCC unwinding library (either static or dynamic) comes from [windows_gnu_base](https://github.com/rust-lang/rust/blob/06e47688bf15d0215edbe05b21603062f6d2eb5d/src/librustc_target/spec/windows_gnu_base.rs).
    Manishearth committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    25671fa View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#73588 - Amanieu:thumb-fp, r=nagisa

    Fix handling of reserved registers for ARM inline asm
    
    `r6` is now disallowed as an operand since LLVM sometimes uses it as a base pointer.
    
    The check against using the frame pointer as an operand now takes the platform into account and will block either `r7` or `r11` as appropriate.
    
    Fixes rust-lang#73450
    
    cc @cbiffle
    Manishearth committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    81d2d3c View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#73597 - ayazhafiz:i/const-span, r=ecstatic-…

    …morse
    
    Record span of `const` kw in GenericParamKind
    
    Context: this is needed for a fix of rust-lang/rustfmt#4263,
    which currently records the span of a const generic param incorrectly
    because the location of the `const` kw is not known.
    
    I am not sure how to add tests for this; any guidance in how to do so
    would be appreciated 🙂
    Manishearth committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    7f6dfb4 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#73629 - flip1995:assoc_op_copy_clone, r=Man…

    …ishearth
    
    Make AssocOp Copy
    
    Found that this enum is not `Copy` while reviewing this Clippy PR: rust-lang/rust-clippy#5727 (comment)
    
    There shouldn't be a reason why this should not be `Copy`.
    Manishearth committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    3d7521d View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#73681 - jackh726:chalk-0.14, r=nikomatsakis

    Update Chalk to 0.14
    
    Not a ton here. Notable changes:
    - Update to `0.14.0`
      - New dependency on `tracing`, in `librustc_traits` only
      - `FnAbi` from Chalk is `rustc_target::spec::abi::Abi`
      - `Dynamic` actually lowers region
      - Actually lower closures, with some tests. This doesn't 100% work, but can't confirm that's *only* because of closure lowering.
    - Use `FxIndexSet` instead of `FxHashSet` in `chalk_fulfill`, which seems to have fixed the non-deterministic test error ordering. Guess we'll see on CI
    - Actually implement `opaque_ty_data`, though I don't think this is sufficient for tests for them (I haven't added any)
    - Uncomment some of the chalk tests that now work
    
    r? @nikomatsakis
    Manishearth committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    1755e3b View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#73707 - LeSeulArtichaut:patch-3, r=kennytm

    Fix links in `SliceIndex` documentation
    
    See [this doc](https://doc.rust-lang.org/nightly/std/slice/trait.SliceIndex.html#tymethod.get_unchecked) whose links aren't active because of this missing newline.
    Manishearth committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    6061752 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#73719 - davidtwco:issue-72509-emitter-colum…

    …n-width, r=estebank
    
    emitter: column width defaults to 140
    
    Fixes rust-lang#72509.
    
    This PR modifies the column width computation in the emitter when `termize::dimensions` returns `None` so that it uses the default value of 140 (which is used in UI testing currently) instead of `usize::MAX` which just ends up causing overflows in later computations.
    
    I also tried changing the computations which used `column_width` with their saturating equivalent, but the output appeared the same - so I decided to go with this approach because I feel like it's less likely to accidentally re-introduce an ICE like this in future (e.g. adding a non-saturating operation on `column_width` in future).
    
    I haven't added a test because I couldn't come up with a MCVE. I stumbled upon this running rustc-perf with the `piston-image` benchmark (running in tmux; it only happened with stage two builds only; and only when running through Cargo, not rustc directly with the same flags). In addition, given the nature of the issue, I don't know that we *could* write a UI test for this. Open to suggestions here though.
    
    r? @estebank
    Manishearth committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    97ccd97 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#73729 - nellshamrell:disable-collectionsben…

    …ches-android, r=sfackler
    
    disable collectionbenches for android
    
    Fixes rust-lang#73535
    
    Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
    Manishearth committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    91a638d View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#73748 - jyn514:doc-fix, r=Manishearth

    Add code block to code in documentation of `List::rebase_onto`
    
    Closes rust-lang#73676
    
    @bors rollup=always
    Manishearth committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    a7eee3c View commit details
    Browse the repository at this point in the history