rustdoc: Rename invalid_codeblock_attribute lint to be plural #74131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
This will need to be backported to beta as that's the first version with this lint. |
ollie27
added
beta-nominated
|
I didn't know there was a convention for lints. TIL. Thanks a lot! @bors: r+ |
|
📌 Commit 56fb717 has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 7, 2020
…ttributes_name, r=GuillaumeGomez rustdoc: Rename invalid_codeblock_attribute lint to be plural Lint names should be plural as per the lint naming conventions: https://github.com/rust-lang/rfcs/blob/master/text/0344-conventions-galore.md#lints r? @GuillaumeGomez
|
⌛ Testing commit 56fb717 with merge acf6ddde7dd6593e8b24ccabc21dd3f783e14b14... |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
|
@bors retry p=3 (nominated) |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 56fb717 with merge 97365d567139e768a08c987a1a21d51488704883... |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 8, 2020
…ttributes_name, r=GuillaumeGomez rustdoc: Rename invalid_codeblock_attribute lint to be plural Lint names should be plural as per the lint naming conventions: https://github.com/rust-lang/rfcs/blob/master/text/0344-conventions-galore.md#lints r? @GuillaumeGomez
|
@bors retry yield |
|
⌛ Testing commit 56fb717 with merge 1de8e7d4c2c9288b7da765610b7c1c35cda49b29... |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 8, 2020
…ttributes_name, r=GuillaumeGomez rustdoc: Rename invalid_codeblock_attribute lint to be plural Lint names should be plural as per the lint naming conventions: https://github.com/rust-lang/rfcs/blob/master/text/0344-conventions-galore.md#lints r? @GuillaumeGomez
|
⌛ Testing commit 56fb717 with merge 239acb9e04f94f03f685cf56b6dc44f7ab145100... |
|
@bors retry yield |
|
☀️ Test successful - checks-actions, checks-azure |
|
discussed at today's T-compiler meeting. accepted for beta backport. |
pnkfelix
added
the
beta-accepted
Mark-Simulacrum
removed
the
beta-nominated
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 13, 2020
…ulacrum [beta] next Backports of: * rustdoc: Fix doc aliases with crate filtering rust-lang#73644 * rustdoc: Rename invalid_codeblock_attribute lint to be plural rust-lang#74131 * rustc_lexer: Simplify shebang parsing once more rust-lang#73596 * Perform obligation deduplication to avoid buggy `ExistentialMismatch` rust-lang#73485 * Reorder order in which MinGW libs are linked to fix recent breakage rust-lang#73184 * Change how compiler-builtins gets many CGUs rust-lang#73136 * Fix wasm32 being broken due to a NodeJS version bump rust-lang#73885
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint names should be plural as per the lint naming conventions: https://github.com/rust-lang/rfcs/blob/master/text/0344-conventions-galore.md#lints
r? @GuillaumeGomez