Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 18 pull requests #74461

Merged
merged 57 commits into from
Jul 18, 2020
Merged

Rollup of 18 pull requests #74461

merged 57 commits into from
Jul 18, 2020

Commits on Jul 1, 2020

  1. Add feature const_option

    a1phyr committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    e7d9944 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. Configuration menu
    Copy the full SHA
    efe634f View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2020

  1. Stop adding unreachable basic blocks to dataflow work queue

    Also adds some debug assertions to prevent API consumers from visiting
    those basic blocks by accident.
    ecstatic-morse committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    698e870 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2020

  1. Fix src/test/run-make/static-pie/test-aslr.rs

    Might be subject to the birthday paradox occasionally, causing spurious failures.
    
    Addresses: rust-lang#70740 (review)
    haraldh committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    6b9b2d9 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2020

  1. Configuration menu
    Copy the full SHA
    5269459 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2020

  1. Configuration menu
    Copy the full SHA
    aabca44 View commit details
    Browse the repository at this point in the history
  2. Apply review comments

    GuillaumeGomez committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    d70e6e1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3dc8544 View commit details
    Browse the repository at this point in the history
  4. Remove leftover from emscripten fastcomp support

    This is no longer used since rust-lang#63649
    bjorn3 committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    4497b9a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5f6c079 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    209991f View commit details
    Browse the repository at this point in the history
  7. Move hir::Place to librustc_middle/hir

    Needed to support rust-lang/project-rfc-2229#7
    
    Currently rustc_typeck depends on rustc_middle for definition TypeckTables, etc.
    For supporting project-rfc-2229#7, rustc_middle would've to depend on
    rustc_typeck for Place -- introducing a circular dependcy.
    
    This resembles the MIR equivalent of `Place` located in `lbrustc_middle/mir`.
    
    Co-authored-by: Aman Arora <me@aman-arora.com>
    Co-authored-by: Jennifer Wills <wills.jenniferg@gmail.com>
    Co-authored-by: Logan Mosier <logmosier@gmail.com>
    3 people committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    50f3dbd View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2ff13d9 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2020

  1. Configuration menu
    Copy the full SHA
    08b4b54 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6969b30 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3429ded View commit details
    Browse the repository at this point in the history
  4. Fix tidy issues

    GuillaumeGomez committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    83ffd5c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    91738d8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    53a1d6f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    69f43dd View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a7f067a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3fb3c0c View commit details
    Browse the repository at this point in the history
  10. Link Some(item)

    tesuji committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    1a90ba7 View commit details
    Browse the repository at this point in the history
  11. Remove code span for impl

    Because the old one is harder to read and confuse typing checkers.
    tesuji committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    67c1e89 View commit details
    Browse the repository at this point in the history
  12. Fix Arc::as_ptr docs

    As a none-native speaker I stumbled upon this, looked it up and couldn't find a phrase, so I made my own assumption that "in any way" was meant (which is the meaning I would've deduced anyway)
    Abendstolz committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    8aeecc6 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    5ffdd7c View commit details
    Browse the repository at this point in the history
  14. Add Arguments::as_str().

    m-ou-se committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    e73a23f View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    bc4e33e View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    e17c17a View commit details
    Browse the repository at this point in the history
  17. Teach bootstrap about target files vs target triples

    `rustc` allows passing in predefined target triples as well as JSON
    target specification files. This change allows bootstrap to have the
    first inkling about those differences. This allows building a
    cross-compiler for an out-of-tree architecture (even though that
    compiler won't work for other reasons).
    
    Even if no one ever uses this functionality, I think the newtype
    around the `Interned<String>` improves the readability of the code.
    shepmaster committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    e2b337d View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    87b4976 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    0c51f53 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    9c3353b View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    48fe5fc View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    2a9b51d View commit details
    Browse the repository at this point in the history
  23. Remove invalid test

    When ran on Windows `cp` will follow symlink: `checkout/build/<target>/<stage>/lib/rustlib/src/rust`.
    It points to `checkout` which means the test will get stuck in copying loop until there is no space left.
    mati865 committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    933a06d View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    fe98de2 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    af1d01e View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    69dab50 View commit details
    Browse the repository at this point in the history
  27. Rollup merge of rust-lang#71670 - GuillaumeGomez:enforce-codeblocks-a…

    …ttribute-check, r=Mark-Simulacrum
    
    Enforce even more the code blocks attributes check through rustdoc
    
    `rustdoc` now has a lint which allows it to warn if a code block attribute is malformated (which can end up in bad situations, even more in case of testing examples!). Now it'll fail if such a situation is encountered when testing markdown code blocks examples.
    
    r? @Mark-Simulacrum
    Manishearth committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    3006ea3 View commit details
    Browse the repository at this point in the history
  28. Rollup merge of rust-lang#73930 - a1phyr:feature_const_option, r=dtolnay

    Make some Option methods const
    
    Tracking issue: rust-lang#67441
    
    Constantify the following methods of `Option`:
    - `as_ref`
    - `is_some`
    - `is_none`
    - `iter` (not sure about this one, but it is possible, and will be useful when const traits are a thing)
    
    cc @rust-lang/wg-const-eval @rust-lang/libs
    Manishearth committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    f6cd31c View commit details
    Browse the repository at this point in the history
  29. Rollup merge of rust-lang#74009 - mati865:mingw-tests-implib, r=nikom…

    …atsakis
    
    Fix MinGW `run-make-fulldeps` tests
    
    `compiler-rt-works-on-mingw` and `libs-search-path` were not ran because `only-mingw` doesn't match any target.
    Enabled and verified few ignored tests with `windows-gnu` toolchain. They are still ignored on MSVC since I'm not experienced with this target.
    Manishearth committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    be3b972 View commit details
    Browse the repository at this point in the history
  30. Rollup merge of rust-lang#74056 - fusion-engineering-forks:fmt-argume…

    …nts-as-str, r=Amanieu
    
    Add Arguments::as_str().
    
    There exist quite a few macros in the Rust ecosystem which use `format_args!()` for formatting, but special case the one-argument case for optimization:
    
    ```rust
    #[macro_export]
    macro_rules! some_macro {
        ($s:expr) => { /* print &str directly, no formatting, no buffers */ };
        ($s:expr, $($tt:tt)*) => { /* use format_args to write to a buffer first */ }
    }
    ```
    
    E.g. [here](https://github.com/rust-embedded/cortex-m-semihosting/blob/7a961f0fbe6eb1b29a7ebde4bad4b9cf5f842b31/src/macros.rs#L48-L58), [here](https://github.com/rust-lang-nursery/failure/blob/20f9a9e223b7cd71aed541d050cc73a747fc00c4/src/macros.rs#L9-L17), and [here](https://github.com/fusion-engineering/px4-rust/blob/7b679cd6da9ffd95f36f6526d88345f8b36121da/px4/src/logging.rs#L45-L52).
    
    The problem with these is that a forgotten argument such as in `some_macro!("{}")` will not be diagnosed, but just prints `"{}"`.
    
    With this PR, it is possible to handle the no-arguments case separately *after* `format_args!()`, while simplifying the macro. Then these macros can give the proper error about a missing argument, just like `print!("{}")` does, while still using the same optimized implementation as before.
    
    This is even more important with [RFC 2795](rust-lang/rfcs#2795), to make sure `some_macro!("{some_variable}")` works as expected.
    Manishearth committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    9c84c6b View commit details
    Browse the repository at this point in the history
  31. Rollup merge of rust-lang#74169 - ecstatic-morse:dataflow-unreachable…

    …, r=pnkfelix
    
    Stop processing unreachable blocks when solving dataflow
    
    ...instead we `debug_assert` that the user is not checking the dataflow state for an unreachable block. This resolves a FIXME in the dataflow engine. The old behavior was an artifact of the previous dataflow framework. Things should run a tiny bit faster now, but I suspect not enough to show up in benchmarks. AFAIK, only the generator transform runs dataflow on MIR with unreachable basic blocks.
    
    This PR also adds some utility methods to `mir::traversal`.
    
    r? @pnkfelix
    Manishearth committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    10b7eec View commit details
    Browse the repository at this point in the history
  32. Rollup merge of rust-lang#74251 - shepmaster:bootstrap-target-files, …

    …r=Mark-Simulacrum
    
    Teach bootstrap about target files vs target triples
    
    `rustc` allows passing in predefined target triples as well as JSON
    target specification files. This change allows bootstrap to have the
    first inkling about those differences. This allows building a
    cross-compiler for an out-of-tree architecture (even though that
    compiler won't work for other reasons).
    
    Even if no one ever uses this functionality, I think the newtype
    around the `Interned<String>` improves the readability of the code.
    Manishearth committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    7d4e6c0 View commit details
    Browse the repository at this point in the history
  33. Rollup merge of rust-lang#74288 - haraldh:test_aslr, r=petrochenkov

    Fix src/test/run-make/static-pie/test-aslr.rs
    
    Might be subject to the birthday paradox occasionally, causing spurious failures.
    
    Addresses: rust-lang#70740 (review)
    Manishearth committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    6b2ccc7 View commit details
    Browse the repository at this point in the history
  34. Rollup merge of rust-lang#74300 - lzutao:iterator-intra, r=jyn514

    Use intra-doc links in core::iter module
    
    This will make core::iter doc depend less on std doc.
    Manishearth committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    c9010d6 View commit details
    Browse the repository at this point in the history
  35. Rollup merge of rust-lang#74364 - lcnr:lazy-norm-tests, r=nikomatsakis

    add lazy normalization regression tests
    
    We previously didn't have simple tests which fail if we aren't careful around lazy normalization.
    
    We now do.
    Manishearth committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    344b5e0 View commit details
    Browse the repository at this point in the history
  36. Rollup merge of rust-lang#74368 - GuillaumeGomez:css-tidy-check, r=Ma…

    …rk-Simulacrum
    
    Add CSS tidy check
    
    r? @Mark-Simulacrum
    Manishearth committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    ef0540b View commit details
    Browse the repository at this point in the history
  37. Rollup merge of rust-lang#74394 - bjorn3:remove_emscripten_leftover, …

    …r=spastorino
    
    Remove leftover from emscripten fastcomp support
    
    This is no longer used since rust-lang#63649
    Manishearth committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    105cd4b View commit details
    Browse the repository at this point in the history
  38. Rollup merge of rust-lang#74411 - jonas-schievink:unbreak-mir, r=matt…

    …hewjasper
    
    Don't assign `()` to `!` MIR locals
    
    Implements the fix described in rust-lang#73860 (comment).
    
    Fixes rust-lang#73860
    
    r? @matthewjasper
    Manishearth committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    87d01d1 View commit details
    Browse the repository at this point in the history
  39. Rollup merge of rust-lang#74416 - NieDzejkob:linker-locale-utf8, r=ol…

    …i-obk
    
    Use an UTF-8 locale for the linker.
    
    Using a `C` locale breaks unicode filenames on Guix, where the linker is wrapped by a Guile program.
    Manishearth committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    eef22da View commit details
    Browse the repository at this point in the history
  40. Rollup merge of rust-lang#74424 - sexxi-goose:move_hir_place, r=nikom…

    …atsakis
    
    Move hir::Place to librustc_middle/hir
    
    Needed to support rust-lang/project-rfc-2229#7
    
    Currently rustc_typeck depends on rustc_middle for definition TypeckTables, etc.
    For supporting project-rfc-2229#7, rustc_middle would've to depend on
    rustc_typeck for Place -- introducing a circular dependency.
    
    This resembles the MIR equivalent of `Place` located in `lbrustc_middle/mir`.
    
    Separate PR for this move will make the actual PR for using Places to represent captures cleaner/more focused.
    
    r? @nikomatsakis  @matthewjasper
    Manishearth committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    222d250 View commit details
    Browse the repository at this point in the history
  41. Rollup merge of rust-lang#74428 - tshepang:better-filter-map-doc, r=j…

    …onas-schievink
    
    docs: better demonstrate that None values are skipped as many times a…
    
    …s needed
    Manishearth committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    3b7e286 View commit details
    Browse the repository at this point in the history
  42. Rollup merge of rust-lang#74438 - RalfJung:uninit-lint, r=davidtwco

    warn about uninitialized multi-variant enums
    
    Fixes rust-lang#73608
    Manishearth committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    cdedae8 View commit details
    Browse the repository at this point in the history
  43. Rollup merge of rust-lang#74440 - Abendstolz:patch-1, r=hanna-kruppe

    Fix Arc::as_ptr docs
    
    As a non-native speaker I stumbled upon this, looked it up and couldn't find a phrase, so I made my own assumption that "in any way" was meant (which is the meaning I would've deduced anyway)
    Manishearth committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    ff1c53f View commit details
    Browse the repository at this point in the history
  44. Rollup merge of rust-lang#74452 - Manishearth:module-type-ns, r=jyn514

    intra-doc links: resolve modules in the type namespace
    
    Fixes rust-lang#62830
    
    Modules actually live in the type namespace, not all three, and it's not possible to clash a type with a module.
    Manishearth committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    c587386 View commit details
    Browse the repository at this point in the history