Move almost all compiler crates to compiler/ #74862

mark-i-m · 2020-07-28T04:37:01Z

This PR implements rust-lang/compiler-team#336 and moves all rustc_* crates from src to the new compiler directory.

librustc_foo directories are renamed to rustc_foo.
src directories are introduced inside rustc_* directories to mirror the scheme already use for library crates.

rust-highfive · 2020-07-28T04:37:04Z

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

rust-highfive · 2020-07-28T04:37:06Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

mark-i-m · 2020-07-28T04:37:28Z

r? @ghost for now

Cargo.toml

petrochenkov · 2020-07-28T04:50:11Z

LGTM.
I had some reservations regarding llvm (including #74787) and tests, but they are not moved here.

Do you plan to introduce the inner src directories though?
They were added to library but not here.

mark-i-m · 2020-07-28T05:02:08Z

Do you plan to introduce the inner src directories though?

Yes, you beat me to it :) I just pushed a commit.

I had some reservations regarding llvm (including #74787) and tests,

Yeah, I think those will be the big questions here... It might be reasonable to do those in a followup PR.

petrochenkov · 2020-08-15T14:00:01Z

ping @mark-i-m
Will you be able to update the PR to mergeable state in the near future?

mark-i-m · 2020-08-16T19:31:19Z

@petrochenkov sure, but this rebase will be rather painful. Would it make sense to get it nominated and fcp'ed first? It seems like we have general consensus on the changes made in this PR, and we can leave more controversial things like LLVM or tests for followup PRs.

mark-i-m · 2020-08-28T03:58:57Z

@petrochenkov I've finally managed to fix up the PR. Should we do an FCP?

mark-i-m · 2020-08-28T04:20:26Z

Hmm... well, it looks like we still need to fix tidy and other tools. @Dylan-DPC you had mentioned that you were interested in helping with this MCP? Do you happen to have a good machine where you can run ./x.py test until it works?

mati865 · 2020-08-28T06:11:46Z

I could help with 2700X based machine but I won't have time today for it.

petrochenkov · 2020-08-28T06:25:01Z

@mark-i-m

Should we do an FCP?

Again? This is already accepted.

petrochenkov · 2020-08-28T06:30:18Z

Similarly to #73265 the commits will need to be squashed before the merged.
The PR description also needs an update.

mark-i-m · 2020-08-28T13:27:28Z

Oh, I guess I misunderstood the process. I was under the impression the MCP was on the general direction, rather than the specifics of this PR.

What in particular do you want me to update in the op?

Dylan-DPC-zz · 2020-08-28T13:34:29Z

you had mentioned that you were interested in helping with this MCP? Do you happen to have a good machine where you can run ./x.py test until it works?

Sadly I don't :/

cynecx · 2020-08-30T18:17:24Z

Mhh. This change makes it really hard to view the history of a file through github. Because almost every file will have this change as their only “commit”.

dtolnay · 2020-08-30T18:20:21Z

For blame, git sees these correctly as moves. See for example the correct blame information by line on https://github.com/rust-lang/rust/blame/85fbf49ce0e2274d0acf798f6e703747674feec3/compiler/rustc_ast/src/lib.rs.

This is bare though: https://github.com/rust-lang/rust/commits/85fbf49ce0e2274d0acf798f6e703747674feec3/compiler/rustc_ast/src/lib.rs. That's not great.

Feature request for GitHub: a "follow" link to the history of a file beyond a move, like Phabricator does:

cynecx · 2020-08-30T18:33:09Z

This is apparently a known issue: isaacs/github#900.

mark-i-m · 2020-08-30T18:34:26Z

Thanks for the help @petrochenkov!

matklad · 2020-08-30T22:36:07Z

I think the auto-publish script needs adjustment: https://github.com/alexcrichton/rustc-auto-publish

vandenheuvel · 2020-08-31T11:33:02Z

Is this documentation still accurate?

mark-i-m · 2020-08-31T18:02:46Z

@vandenheuvel I just made a PR to update that. It is accurate now.

ecstatic-morse · 2020-09-01T02:22:17Z

Not quite worthy of inclusion in this weeks perf triage report, but this PR caused a small regression on doc builds across all benchmarks and a very small regression on some check builds.

Clearly we need to switch to shorter directory names. I propose that we switch to r for "rust", remove repeated phrases, and start using common abbreviations, so compiler/rustc_middle would become r/mid, etc.

petrochenkov · 2020-09-01T16:16:53Z

@mark-i-m
Looks like highfive bot wasn't updated properly, all compiler PRs are still assigned to nikomatsakis.

Dylan-DPC-zz · 2020-09-01T16:23:43Z

yeah i try to reassign some of them especially the smaller ones :D

Mark-Simulacrum · 2020-09-01T16:29:55Z

I hope to fix highfive later today, I'm not sure why the change we made didn't work. Will need to debug.

https://github.com/rust-lang/rust/blob/master/src/librustc_session/lint/builtin.rs returns page not found. The following is the background of the move. First rust-lang#74862 moves from src/librustc_session/lint/builtin.rs to compiler/rustc_session/src/lint/builtin.rs Then rust-lang@23018a5 moves from compiler/rustc_session/src/lint/builtin.rs to compiler/rustc_lint_defs/src/builtin.rs So, the current correct link is https://github.com/rust-lang/rust/blob/master/compiler/rustc_lint_defs/src/builtin.rs This PR fixes a broken link on the following page: https://doc.rust-lang.org/beta/unstable-book/language-features/plugin.html

…nstable_book, r=ehuss Fix an incorrect link in The Unstable Book https://github.com/rust-lang/rust/blob/master/src/librustc_session/lint/builtin.rs returns page not found. The following is the background of the move. First rust-lang#74862 moves from src/librustc_session/lint/builtin.rs to compiler/rustc_session/src/lint/builtin.rs. Then rust-lang@23018a5 moves from compiler/rustc_session/src/lint/builtin.rs to compiler/rustc_lint_defs/src/builtin.rs. So, the current correct link is https://github.com/rust-lang/rust/blob/master/compiler/rustc_lint_defs/src/builtin.rs. This PR fixes a broken link on the following page: https://doc.rust-lang.org/beta/unstable-book/language-features/plugin.html

Follow up rust-lang/rust#74862. https://github.com/rust-lang/rust/blob/master/src/librustc_errors/json.rs returns page not found. This PR fixes the incorrect URL.

rust-highfive assigned nikomatsakis Jul 28, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 28, 2020

mark-i-m unassigned nikomatsakis Jul 28, 2020

petrochenkov reviewed Jul 28, 2020

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

This was referenced Jul 28, 2020

Move rustllvm into compiler/rustc_llvm #74787

Merged

cleanup: Remove duplicate library names from Cargo.tomls #74668

Merged

This comment has been minimized.

Sign in to view

Muirrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2020

petrochenkov mentioned this pull request Aug 15, 2020

Move the compiler to a new compiler/ directory rust-lang/compiler-team#336

Closed

3 tasks

mark-i-m marked this pull request as ready for review August 28, 2020 03:59

mark-i-m force-pushed the mv-compiler branch from ad7a81c to 0053243 Compare August 28, 2020 03:59

mark-i-m changed the title ~~[WIP] Move almost all compiler crates to compiler/~~ Move almost all compiler crates to compiler/ Aug 28, 2020

mark-i-m force-pushed the mv-compiler branch from 0053243 to 05c5cab Compare August 28, 2020 04:02

petrochenkov self-assigned this Aug 28, 2020

This comment has been minimized.

Sign in to view

mark-i-m deleted the mv-compiler branch August 31, 2020 02:06

Dylan-DPC-zz mentioned this pull request Sep 7, 2020

Tracking issue for renaming crates inside compiler directory #76425

Closed

49 tasks

LeSeulArtichaut mentioned this pull request Jan 24, 2021

Update links to librustc_llvm and rustllvm rust-lang/rustc-dev-guide#1039

Merged

koic mentioned this pull request May 6, 2022

Fix an incorrect link in The Unstable Book #96781

Merged

koic added a commit to koic/rls that referenced this pull request May 7, 2022

Fix an incorrect URL

677c075

Follow up rust-lang/rust#74862. https://github.com/rust-lang/rust/blob/master/src/librustc_errors/json.rs returns page not found. This PR fixes the incorrect URL.

koic mentioned this pull request May 7, 2022

Fix an incorrect URL rust-lang/rls#1774

Merged

cuviper added this to the 1.48.0 milestone May 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move almost all compiler crates to compiler/ #74862

Move almost all compiler crates to compiler/ #74862

mark-i-m commented Jul 28, 2020 •

edited by petrochenkov

Loading

rust-highfive commented Jul 28, 2020

rust-highfive commented Jul 28, 2020

mark-i-m commented Jul 28, 2020

petrochenkov commented Jul 28, 2020

mark-i-m commented Jul 28, 2020

This comment has been minimized.

petrochenkov commented Aug 15, 2020

mark-i-m commented Aug 16, 2020

mark-i-m commented Aug 28, 2020

mark-i-m commented Aug 28, 2020

mati865 commented Aug 28, 2020

petrochenkov commented Aug 28, 2020

petrochenkov commented Aug 28, 2020

This comment has been minimized.

mark-i-m commented Aug 28, 2020

Dylan-DPC-zz commented Aug 28, 2020

cynecx commented Aug 30, 2020

dtolnay commented Aug 30, 2020 •

edited

Loading

cynecx commented Aug 30, 2020

mark-i-m commented Aug 30, 2020

matklad commented Aug 30, 2020

vandenheuvel commented Aug 31, 2020

mark-i-m commented Aug 31, 2020

ecstatic-morse commented Sep 1, 2020 •

edited

Loading

petrochenkov commented Sep 1, 2020

Dylan-DPC-zz commented Sep 1, 2020

Mark-Simulacrum commented Sep 1, 2020

Move almost all compiler crates to compiler/ #74862

Move almost all compiler crates to compiler/ #74862

Conversation

mark-i-m commented Jul 28, 2020 • edited by petrochenkov Loading

rust-highfive commented Jul 28, 2020

rust-highfive commented Jul 28, 2020

mark-i-m commented Jul 28, 2020

petrochenkov commented Jul 28, 2020

mark-i-m commented Jul 28, 2020

This comment has been minimized.

petrochenkov commented Aug 15, 2020

mark-i-m commented Aug 16, 2020

mark-i-m commented Aug 28, 2020

mark-i-m commented Aug 28, 2020

mati865 commented Aug 28, 2020

petrochenkov commented Aug 28, 2020

petrochenkov commented Aug 28, 2020

This comment has been minimized.

mark-i-m commented Aug 28, 2020

Dylan-DPC-zz commented Aug 28, 2020

cynecx commented Aug 30, 2020

dtolnay commented Aug 30, 2020 • edited Loading

cynecx commented Aug 30, 2020

mark-i-m commented Aug 30, 2020

matklad commented Aug 30, 2020

vandenheuvel commented Aug 31, 2020

mark-i-m commented Aug 31, 2020

ecstatic-morse commented Sep 1, 2020 • edited Loading

petrochenkov commented Sep 1, 2020

Dylan-DPC-zz commented Sep 1, 2020

Mark-Simulacrum commented Sep 1, 2020

mark-i-m commented Jul 28, 2020 •

edited by petrochenkov

Loading

dtolnay commented Aug 30, 2020 •

edited

Loading

ecstatic-morse commented Sep 1, 2020 •

edited

Loading