Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mk: fix clean-llvm for cross-compile #7492

Merged
merged 1 commit into from
Jul 1, 2013
Merged

mk: fix clean-llvm for cross-compile #7492

merged 1 commit into from
Jul 1, 2013

Conversation

yichoi
Copy link
Contributor

@yichoi yichoi commented Jun 30, 2013

fix clean-llvm in mk/clean.mk for cross-compile

after #7442 landed, below error produced while android cross-compile

make[1]: *** No rule to make target `clean-llvmarm-linux-androideabi', needed by `clean-llvm'.  Stop.
make[1]: Leaving directory `/home/yichoi/rust_latest/build'
make: *** [rustllvm/llvm-auto-clean-stamp] Error 2

@yichoi
Copy link
Contributor Author

yichoi commented Jun 30, 2013

hope no more breakage 😢

@brson
Copy link
Contributor

brson commented Jun 30, 2013

Thanks, @yichoi. I think this can be solved in a simpler way. See my explanation of the bug in #7491. Rewriting this line to use CFG_HOST_TRIPLES instead of CFG_TARGET_TRIPLES is probably sufficient.

@yichoi
Copy link
Contributor Author

yichoi commented Jun 30, 2013

right that's easier way. push-forced again.

@yichoi
Copy link
Contributor Author

yichoi commented Jun 30, 2013

hmm need to be landed with priority

bors added a commit that referenced this pull request Jul 1, 2013
fix clean-llvm in mk/clean.mk for cross-compile

after #7442 landed, below error produced while android cross-compile
```
make[1]: *** No rule to make target `clean-llvmarm-linux-androideabi', needed by `clean-llvm'.  Stop.
make[1]: Leaving directory `/home/yichoi/rust_latest/build'
make: *** [rustllvm/llvm-auto-clean-stamp] Error 2
```
@bors bors closed this Jul 1, 2013
@bors bors merged commit 0a3f6bc into rust-lang:master Jul 1, 2013
@yichoi yichoi deleted the fix_cleanllvm branch July 1, 2013 09:25
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 29, 2021
Explain flags missing in cargo check in --help

This commit closes rust-lang#7389. As stated in the issue, `cargo clippy --help`
provides explanation for some flags and states that the rest are same
as in `cargo check --help`, even though some clippy specific flags
exist.

This commit extends the `cargo clippy --help` with two additional flags,
  - `cargo clippy --fix`
  - `cargo clippy --no-deps`

If there are more flags which are not present in `cargo check --help`
please bring these to my attention, I will include these aswell.
For now, I noticed only the two flags mentioned above.

changelog: `cargo clippy --help` now explains additional flags missing in `cargo check --help`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants