Make mem::size_of_val and mem::align_of_val unstably const
#74930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
ecstatic-morse
force-pushed
the
const-size-align-of-val
branch
from
7f4a5c0
to
34eaffb
Compare
ecstatic-morse
force-pushed
the
const-size-align-of-val
branch
from
34eaffb
to
88fd494
Compare
|
@bors r+ Please also open a PR against miri, removing the intrinsics there |
|
📌 Commit 88fd494 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
Resolved in rust-lang/miri#1492 (thanks Ralf!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #46571 but does not stabilize it. I wanted this while working on something today.
The only reason not to immediately stabilize are concerns around custom DSTs. That proposal has made zero progress in the last two years and const eval is rich enough to support pretty much any user-defined
lenfunction as long as nightly features are allowed (raw_ptr_deref).Currently, this raises a
const_errlint when passed anextern type.r? @oli-obk
cc @rust-lang/wg-const-eval