Note when a a move/borrow error is caused by a deref coercion #75304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @lcnr (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
lcnr
reviewed
Aug 8, 2020
|
hmm, I don't see any obvious problems here, but am not really familiar enough with what's touched here, maybe r? @estebank |
estebank
reviewed
Aug 11, 2020
estebank
reviewed
Aug 11, 2020
estebank
reviewed
Aug 11, 2020
estebank
reviewed
Aug 11, 2020
| | | ||
| LL | type Target = NotCopy; | ||
| | ^^^^^^^^^^^^^^^^^^^^^^ | ||
| = note: move occurs because `val.first` has type `NotCopy`, which does not implement the `Copy` trait |
There was a problem hiding this comment.
This note seems like it could go as the label of the main span in the previous note.
There's something missing in the new output, but I can't quite put my finger on it. Having said that, we can land this PR and improve it later.
There was a problem hiding this comment.
I don't think we should attach it to the span of val.inner;, since that's referring to the borrow. However, I think it would make sense to reorder it to go before the 'deref defined here' note.
Aaron1011
force-pushed
the
feature/diag-deref-move-out
branch
from
0c52521
to
3cf4bbc
Compare
|
@estebank I've addressed your comments |
|
@estebank Are there any changes that you'd like me to make? |
This comment has been minimized.
This comment has been minimized.
Aaron1011
force-pushed
the
feature/diag-deref-move-out
branch
from
6c1030e
to
6893db8
Compare
|
@estebank: I've resolved the merge conflicts. |
This comment has been minimized.
This comment has been minimized.
Aaron1011
force-pushed
the
feature/diag-deref-move-out
branch
2 times, most recently
from
57f8be6
to
67d9ee6
Compare
This comment has been minimized.
This comment has been minimized.
Fixes rust-lang#73268 When a deref coercion occurs, we may end up with a move error if the base value has been partially moved out of. However, we do not indicate anywhere that a deref coercion is occuring, resulting in an error message with a confusing span. This PR adds an explicit note to move errors when a deref coercion is involved. We mention the name of the type that the deref-coercion resolved to, as well as the `Deref::Target` associated type being used.
Aaron1011
force-pushed
the
feature/diag-deref-move-out
branch
from
67d9ee6
to
d18b4bb
Compare
|
@estebank: This is now ready for review |
jyn514
added
A-diagnostics
|
@bors r+ |
|
📌 Commit d18b4bb has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 16, 2020
Rollup of 10 pull requests Successful merges: - rust-lang#73955 (deny(unsafe_op_in_unsafe_fn) in libstd/process.rs) - rust-lang#75146 (Detect overflow in proc_macro_server subspan) - rust-lang#75304 (Note when a a move/borrow error is caused by a deref coercion) - rust-lang#75749 (Consolidate some duplicate code in the sys modules.) - rust-lang#75882 (Use translated variable for test string) - rust-lang#75886 (Test that bounds checks are elided for [..index] after .position()) - rust-lang#76048 (Initial support for riscv32gc_unknown_linux_gnu) - rust-lang#76198 (Make some Ordering methods const) - rust-lang#76689 (Upgrade to pulldown-cmark 0.8.0) - rust-lang#76763 (Update cargo) Failed merges: r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73268
When a deref coercion occurs, we may end up with a move error if the
base value has been partially moved out of. However, we do not indicate
anywhere that a deref coercion is occuring, resulting in an error
message with a confusing span.
This PR adds an explicit note to move errors when a deref coercion is
involved. We mention the name of the type that the deref-coercion
resolved to, as well as the
Deref::Targetassociated type being used.