[WIP] Remove fake IDs in rustdoc #75355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're confusing, cause crashes, and aren't necessary.
jyn514
added
C-cleanup
|
Some changes occurred in intra-doc-links. cc @jyn514 |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This code path was never taken before because all the ids were fake. So the ids would never have been seen before.
|
@jyn514: Fake DefIds exist to handle 'synthetic' auto trait impls, which don't have a real |
|
@Aaron1011 do you know what the |
|
@jyn514: |
|
☔ The latest upstream changes (presumably #75549) made this pull request unmergeable. Please resolve the merge conflicts. |
jyn514
added
S-waiting-on-author
|
Closing this because I think it needs more design work in rustdoc (#76382), the current approach isn't going to work. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 18, 2020
Pass a `TyCtxt` through to `FormatRender` This is the next step after rust-lang#79957 for rust-lang#76382. Eventually I plan to use this to remove `stability`, `const_stability`, and `deprecation` from `Item`, but that needs more extensive changes (in particular, rust-lang#75355 or something like it). This has no actual changes to behavior, it's just moving types around. ccc rust-lang#80014 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're confusing and cause crashes. Part of an ongoing effort to debug #75176.
Not sure why the tests are failing, probably I'm not understanding why fake IDs were added in the first place.