use type folder + normalization for MIR assignment type-checking #75419
Conversation
|
r? @lcnr (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
RalfJung
force-pushed
the
mir-assign-check
branch
from
38472f9
to
31a0251
Compare
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
|
⌛ Trying commit 31a0251 with merge 0caf8b37da267b885ad6f55b86dde01b897d7068... |
|
As per #75313 (comment), we likely shouldn't need to land this, once we fix normalization of |
|
☀️ Try build successful - checks-actions, checks-azure |
|
Queued 0caf8b37da267b885ad6f55b86dde01b897d7068 with parent cbe7c5c, future comparison URL. |
|
Finished benchmarking try commit (0caf8b37da267b885ad6f55b86dde01b897d7068): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
|
Perf seems to be mostly noise? |
Do we want to wait for that or just land this as is, can try that change locally and see if it breaks something 🤔 |
|
opened #75443 for this, let's see if niko finds a problem with that approach |
If CI passes there then that's definitely the better solution I'd say. :) |
|
#75443 landed, closing in favor of that. |
revert rust-lang#75443, update mir validator This PR reverts rust-lang#75443 to fix rust-lang#75992 and instead uses rust-lang#75419 to fix rust-lang#75313. Adapts rust-lang#75419 to correctly deal with unevaluated constants as otherwise some `feature(const_evaluatable_checked)` tests would ICE. Note that rust-lang#72793 was also fixed by rust-lang#75443, but as that issue only concerns `feature(type_alias_impl_trait)` I deleted that test case for now and would reopen that issue. rust-lang#75443 may have also allowed some other code to now successfully compile which would make this revert a breaking change after 2 stable versions, but I hope that this is a purely theoretical concern. See https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/generator.20upvars/near/214617274 for more reasoning about this. r? `@nikomatsakis` `@eddyb` `@RalfJung`
Fixes #75313
Thanks to @eddyb who did all the hard work, I just implemented his suggestions.^^
@lcnr Unfortunately this loses the type relator, we normalize the entire thing instead. There might be a perf hit.