Disable cancel-outdated-builds for auto-fallible #75995
Merged
+22
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors p=10 We'll want this to land ASAP, to get insights on whether we can migrate to GitHub Actions for macOS too. |
|
@bors r+ rollup It sounds like this will potentially cause us to enqueue a bunch of macOS builds if we're seeing builds fail on other platforms, but I don't expect that to be much of an issue so approving. Feel free to ping me on Zulip if there's urgent stuff like this too :) |
|
📌 Commit 19e70bf has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 28, 2020
…2, r=Mark-Simulacrum Run cancel-outdated-builds after fully setting up the env This PR fixes rust-lang#75995 not working as expected. Due to GitHub Actions limitations the environment variables set in the build matrix definition are not added by the GHA runner, but by the `setup-environment.sh` script. Before this PR the `cancel-outdated-builds` action was started before that script, so it was never able to detect the "suppression" variable added in rust-lang#75995. This PR reorders the jobs to make sure `setup-environment.sh` runs before the action. r? @Mark-Simulacrum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cancel-outdated-buildsdoesn't need to be enabled on fallible jobs, and it's actually making it harder for us to see if #71988 is fixed. This adds some temporary code to avoidauto-falliblejobs from being cancelled by our tooling.r? @Mark-Simulacrum