Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert repetitive target_pointer_width checks to const solution. #76481

Merged
merged 2 commits into from
Sep 10, 2020
Merged

Convert repetitive target_pointer_width checks to const solution. #76481

merged 2 commits into from
Sep 10, 2020

Conversation

moonheart08
Copy link
Contributor

Simply a quick code tidying change. Not sure if more needs to be said.

@moonheart08
Convert MAXIMUM_ZST_CAPACITY to be calculated in a
c3c84ad 
const instead of multiple target_pointer_width checks.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 8, 2020
@sfackler
Copy link
Member

sfackler commented Sep 8, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 8, 2020

📌 Commit c3c84ad has been approved by sfackler

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2020
@moonheart08 @m-ou-se
Update library/alloc/src/collections/vec_deque.rs
e02952c 
Replace lshift with multiply

Co-authored-by: Mara Bos <m-ou.se@m-ou.se>
@jyn514
Copy link
Member

jyn514 commented Sep 9, 2020

@bors r=sfackler

I really wish bors would switch the labels when you add more commits.

@bors
Copy link
Contributor

bors commented Sep 9, 2020

📌 Commit e02952c has been approved by sfackler

@jyn514
Copy link
Member

jyn514 commented Sep 9, 2020

@bors rollup

@jyn514 jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Sep 9, 2020
@tmandry tmandry mentioned this pull request Sep 9, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 9, 2020
@bors
Auto merge of rust-lang#76540 - tmandry:rollup-5ogt8x0, r=tmandry
97eb606 
Rollup of 14 pull requests

Successful merges:

 - rust-lang#75094 (Add `-Z combine_cgu` flag)
 - rust-lang#75984 (Improve unresolved use error message)
 - rust-lang#76141 (Address review comments about config.toml from rustc-dev-guide PR)
 - rust-lang#76313 (Improved the MIR spanview output)
 - rust-lang#76430 (Add align to rustc-attrs unstable book)
 - rust-lang#76465 (Add a script to automatically update Rust/Clang versions in documentation)
 - rust-lang#76473 (Add missed spaces to GCC-WARNING.txt)
 - rust-lang#76481 (Convert repetitive target_pointer_width checks to const solution.)
 - rust-lang#76493 (Remove a stray ignore-tidy-undocumented-unsafe)
 - rust-lang#76504 (Capitalize safety comments)
 - rust-lang#76515 (SessionDiagnostic: Fix non-determinism in generated format string.)
 - rust-lang#76516 (Enable GitHub Releases synchronization)
 - rust-lang#76522 (remove redundant clones)
 - rust-lang#76523 (Remove unused PlaceContext::NonUse(NonUseContext::Coverage))

Failed merges:

r? `@ghost`
@bors bors merged commit 0d20cf8 into rust-lang:master Sep 10, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 10, 2020
@moonheart08 moonheart08 deleted the vec_deque_constify branch September 10, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuviper cuviper cuviper left review comments

@m-ou-se m-ou-se m-ou-se left review comments

Assignees

@sfackler sfackler

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@moonheart08 @rust-highfive @sfackler @bors @jyn514 @cuviper @m-ou-se @rustbot