Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to pulldown-cmark 0.8.0 #76689

Merged
merged 3 commits into from
Sep 16, 2020
Merged

Upgrade to pulldown-cmark 0.8.0 #76689

merged 3 commits into from
Sep 16, 2020

Commits on Sep 14, 2020

  1. Upgrade to pulldown-cmark 0.8.0 

    Thanks to marcusklaas' hard work in pulldown-cmark/pulldown-cmark#469, this fixes a lot of rustdoc bugs!

- Get rid of unnecessary `RefCell`
- Fix duplicate warnings for broken implicit reference link
- Remove unnecessary copy of links
    @jyn514
    jyn514 committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    e4c28bf View commit details
    Browse the repository at this point in the history

  2. Don't use link.span yet 

    This shows the span of the _whole_ link, including the brackets.
But rustdoc only wants to warn about the link text.
    @jyn514
    jyn514 committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    f7983ca View commit details
    Browse the repository at this point in the history

  3. Use .as_str() instead of CowStr::Borrowed

    @jyn514
    jyn514 committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    6f2e1c6 View commit details
    Browse the repository at this point in the history