Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config option to add only debug! (and not trace!) calls #76752

Closed
wants to merge 1 commit into from

Conversation

guswynn
Copy link
Contributor

@guswynn guswynn commented Sep 15, 2020

in #76588, @jyn514 mentioned that one way we could possibly turn on logging by default is to separate debug! and trace! calls

even if we don't go with it as default, its still nice to separate them so we can have granularity if we want it, AND so we can actually test the perf lost by making it default

r? @jyn514 @Mark-Simulacrum

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 15, 2020
@guswynn
Copy link
Contributor Author

guswynn commented Sep 15, 2020

@rustbot modify labels +A-rustbuild

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Sep 15, 2020
@jyn514
Copy link
Member

jyn514 commented Sep 15, 2020

I'm not sure who the expected audience for this is. Very few parts of the compiler distinguish between trace! and debug!, so this doesn't have much of a performance impact, and personally I would still keep trace level logging on even if you added this option.

The idea I was thinking of was to move some logging from debug! to trace!. However, that will require building a consensus with the relevant parts of the compiler team that this is a useful thing to do. If you're interested in that route, take a look at the zulip for t-compiler, especially 'improving bootstrap times for contributor fun and profit'.

As-is, though, I don't see much point to this.

@guswynn
Copy link
Contributor Author

guswynn commented Sep 15, 2020

Ill read more into this!

@guswynn guswynn closed this Sep 15, 2020
@jyn514
Copy link
Member

jyn514 commented Sep 15, 2020

See also tokio-rs/tracing#975, which has some more discussion.

@guswynn guswynn deleted the debug_trace branch February 19, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants