Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing the alloc() to accept &self instead of &mut self #76993

Merged
merged 7 commits into from
Sep 24, 2020
Merged

Changing the alloc() to accept &self instead of &mut self #76993

merged 7 commits into from
Sep 24, 2020

Conversation

blitzerr
Copy link
Contributor

Fixes: #55

This is the first cut. It only makes the change for alloc method.

@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 21, 2020
@blitzerr
Copy link
Contributor Author

r? @Amanieu cc @TimDiekmann

@blitzerr blitzerr changed the title Changing the alloc() to accept &self instead of &mut self [WIP] Changing the alloc() to accept &self instead of &mut self Sep 21, 2020
@TimDiekmann
Copy link
Member

Could you rebase onto master and force push so we don't have the changes from all the other commits?

@Amanieu
Copy link
Member

Amanieu commented Sep 21, 2020

Can you also change the other methods of AllocRef in this PR?

@blitzerr
Copy link
Contributor Author

blitzerr commented Sep 21, 2020 •
edited
Loading

Could you rebase onto master and force push so we don't have the changes from all the other commits?

Ohh ! I am so sorry for all the junk. I thought I did force push but apparently not :)

Now it is done

@blitzerr
Copy link
Contributor Author

blitzerr commented Sep 21, 2020 •
edited
Loading

Can you also change the other methods of AllocRef in this PR?

@Amanieu I will certainly do that. :) This is my first PR into stdlib. So I wanted all builds to pass cleanly with just the alloc changes. Then I will make the change for all methods in AllocRef. Does that sound okay ?

@blitzerr
Copy link
Contributor Author

blitzerr commented Sep 22, 2020 •
edited
Loading

Awesome ! Thanks for being proactive with the PR. I will incorporate all the suggestions.

@blitzerr blitzerr changed the title [WIP] Changing the alloc() to accept &self instead of &mut self Changing the alloc() to accept &self instead of &mut self Sep 23, 2020
@Amanieu
Copy link
Member

Amanieu commented Sep 23, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Sep 23, 2020

📌 Commit 2b19b14 has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Sep 23, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 23, 2020
@bors
Auto merge of rust-lang#77102 - Dylan-DPC:rollup-2jfrg3u, r=Dylan-DPC
c351775 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#76898 (Record `tcx.def_span` instead of `item.span` in crate metadata)
 - rust-lang#76939 (emit errors during AbstractConst building)
 - rust-lang#76965 (Add cfg(target_has_atomic_equal_alignment) and use it for Atomic::from_mut.)
 - rust-lang#76993 (Changing the alloc() to accept &self instead of &mut self)
 - rust-lang#76994 (fix small typo in docs and comments)
 - rust-lang#77017 (Add missing examples on Vec iter types)
 - rust-lang#77042 (Improve documentation for ToSocketAddrs)
 - rust-lang#77047 (Miri: more informative deallocation error messages)
 - rust-lang#77055 (Add #[track_caller] to more panicking Cell functions)

Failed merges:

r? `@ghost`
@bors bors merged commit a40d79c into rust-lang:master Sep 24, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 24, 2020
al3xtjames added a commit to al3xtjames/r-efi-alloc that referenced this pull request Oct 1, 2020
@al3xtjames
alloc: align with AllocRef trait changes in nightly
42e787d 
Needed since rust-lang/rust#76993

Signed-off-by: Alex James <theracermaster@gmail.com>
@al3xtjames al3xtjames mentioned this pull request Oct 1, 2020
Merged
dvdhrm pushed a commit to r-efi/r-efi-alloc that referenced this pull request Oct 1, 2020
@al3xtjames @dvdhrm
alloc: align with AllocRef trait changes in nightly
58c7085 
Needed since rust-lang/rust#76993

Signed-off-by: Alex James <theracermaster@gmail.com>
parasyte pushed a commit to parasyte/allocator-suite that referenced this pull request Oct 21, 2020
Update for experimental allocator_api
60b7791 
- Incorporates changes for:
  - rust-lang/rust#76993
  - rust-lang/rust#77315
@parasyte parasyte mentioned this pull request Oct 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amanieu Amanieu Amanieu left review comments

@TimDiekmann TimDiekmann TimDiekmann left review comments

Assignees

@Amanieu Amanieu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.

Change AllocRef to take &self
7 participants
@blitzerr @rust-highfive @TimDiekmann @Amanieu @bors @joshtriplett @rustbot